Skip to content

fix(statics): the natural-level test of the object balance cannot cycle - #135

Merged
SMI-Lab-Inha merged 2 commits into
devfrom
fix/point-static-cycle
Nov 9, 2026
Merged

SMI-Lab-Inha merged 2 commits into
devfrom
fix/point-static-cycle

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

A Connect point between a near-vertical heavy chain and a wire lying nearly taut on the seabed failed the static solve from every seed (fuzz campaign case pointsys_07092).

The balance of objects accepts a trial step that grows the residual when the Newton step from the trial point is at most half the current one (a taut line swinging about its anchor). That test compared only against the previous step, so a long step at a slack/taut kink reset the measure and the iterates could cycle forever. The test is now |dx_c| <= 0.5*min(|dx_n|, the shortest Newton step accepted in the phase), which cannot cycle.

Check. An independent elastic-catenary balance on a frictionless seabed puts the equilibrium at (−46.28, −215.17, −385.52). CableDyn now converges to (−45.53, −215.82, −385.97) on the deck mesh and to (−46.03, −215.39, −385.64) on the 2× mesh.

Test. point_static_cycle: four translations of the deck plus the 2× mesh. Its tolerance is 1.5 m on the coarse mesh, whose own discretisation offset is 1.09 m. CTest passes on both BLAS kernels; examples are identical apart from one round-off digit in a log line.

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T00:39:45.833848Z 052600a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

read-the-docs-community Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35741990 | 📁 Comparing 052600a against latest (e8f88f5)

  🔍 Preview build  

12 files changed · ± 12 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: de189afde2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@SMI-Lab-Inha
SMI-Lab-Inha force-pushed the fix/point-static-cycle branch from de189af to 72780a8 Compare November 8, 2026 17:11
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 72780a85c5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha force-pushed the fix/point-static-cycle branch from 72780a8 to 0067394 Compare November 8, 2026 20:07
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 0067394160

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@SMI-Lab-Inha
SMI-Lab-Inha force-pushed the fix/point-static-cycle branch from 0067394 to e2cd0f4 Compare November 8, 2026 22:28
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: e2cd0f468c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

The static balance of Connect/Free points, bodies and rods accepts a trial
step that raises the force residual when the Newton step from it is at most
half the current one (a taut line swinging about its anchor, which every
straight step overstretches by its sagitta). Near the slack/taut kink of a
line the analytic Jacobian is nearly singular and the Newton step grows
again; that resets the measure, and the iterates cycled: a massless Connect
point between a near-vertical heavy chain and two wires on the seabed went
4e4 N -> 6e6 N -> 4e5 N -> 1.6e5 N -> 4e4 N and around, every four steps, until
the solve failed with "static point equilibrium not found" from every seed,
at the deck position, at three translations and at the balance itself. An
independent solution with elastic catenaries on a frictionless seabed puts
the balance 5.6 m above the seabed.

Such a step is now accepted only when the new Newton step is also at most
half the shortest Newton step of the phase so far. Steps that lower the
residual are unchanged; every example gives the same output (one log digit
of a 1e-5 N force component apart).

The new point_static_cycle test solves the deck at four translations and on
twice its mesh, within 1.5 m (deck mesh) and 0.5 m (refined) of the
independent balance.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one
change, so that they do not conflict with each other.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@SMI-Lab-Inha
SMI-Lab-Inha force-pushed the fix/point-static-cycle branch from e2cd0f4 to 052600a Compare November 9, 2026 00:38
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 052600ad19

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit d8620a1 into dev Nov 9, 2026
22 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/point-static-cycle branch November 9, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant