Skip to content

fix(statics): the drag arclength continuation takes a Rigid end connection - #136

Merged
SMI-Lab-Inha merged 2 commits into
devfrom
fix/arclength-rigid-end
Nov 9, 2026
Merged

SMI-Lab-Inha merged 2 commits into
devfrom
fix/arclength-rigid-end

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

The drag pseudo-arclength continuation of the finite-EI static solve was switched off whenever an end was Rigid. Only plain load steps were left, and they fail on a hairpin with a clamped end (fuzz campaign case dynexc_45265).

The arclength now carries the Rigid end's basis: CD_EndConn_Basis of the end direction, with the two transverse tangent components held. The drag load is rotated into that basis, as the residual and tangent already are, and each solved increment and tangent is rotated back to global components before the bordered update.

Test. arclength_rigid_end: on the 100-element deck at u = 1.12, the Rigid result matches a 1e9 N·m/rad spring end within 1e-3. CTest passes on both BLAS kernels. Examples are unchanged.

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T02:44:40.257687Z 11863e7 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

read-the-docs-community Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35743444 | 📁 Comparing 11863e7 against latest (e8f88f5)

  🔍 Preview build  

13 files changed · ± 13 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 27afd1c1d9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@SMI-Lab-Inha
SMI-Lab-Inha force-pushed the fix/arclength-rigid-end branch from 27afd1c to 5e1c6df Compare November 8, 2026 17:11
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 5e1c6df2cd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@SMI-Lab-Inha
SMI-Lab-Inha force-pushed the fix/arclength-rigid-end branch from 5e1c6df to 0341a45 Compare November 8, 2026 20:06
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 0341a456f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha force-pushed the fix/arclength-rigid-end branch from 0341a45 to a0f9c54 Compare November 8, 2026 22:28
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: a0f9c5435e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@SMI-Lab-Inha
SMI-Lab-Inha force-pushed the fix/arclength-rigid-end branch from a0f9c54 to 1107a25 Compare November 9, 2026 00:39
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 1107a25b53

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…ction

When the drag load steps of a finite-EI static solve in a current stall at a
limit point in the drag fraction, a pseudo-arclength continuation follows the
path around it. It was skipped for a line with a Rigid end connection, whose
end tangent the static solve takes in the basis of its direction, so such a
line failed ("current load stepping stopped at drag fraction 0.519") where
the same line with a 1e9 N m/rad rotational spring, or pinned, solved: a
2982 m cable clamped at its fairlead in a 1.1 m/s current that folds its
grounded run back past the anchor.

The continuation now carries a Rigid end as the static solve does: the
residual and tangent come in the end-direction basis (CD_EndConn_Basis), the
drag load is turned into it, the two transverse components of the end tangent
are held, and each solved increment and path tangent is turned back to global
components. Decks whose load steps converge are unchanged; every example gives
the same output.

The new arclength_rigid_end test solves the clamped cable and requires its end
tensions within 1e-3 of the 1e9 N m/rad spring line's.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one
change, so that they do not conflict with each other.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@SMI-Lab-Inha
SMI-Lab-Inha force-pushed the fix/arclength-rigid-end branch from 1107a25 to 11863e7 Compare November 9, 2026 02:43
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 11863e7d01

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 7fb8a31 into dev Nov 9, 2026
22 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/arclength-rigid-end branch November 9, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant