Repository navigation
fix(statics): the drag arclength continuation takes a Rigid end connection - #136
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
27afd1c to
5e1c6df
Compare
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
5e1c6df to
0341a45
Compare
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
0341a45 to
a0f9c54
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
a0f9c54 to
1107a25
Compare
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…ction
When the drag load steps of a finite-EI static solve in a current stall at a
limit point in the drag fraction, a pseudo-arclength continuation follows the
path around it. It was skipped for a line with a Rigid end connection, whose
end tangent the static solve takes in the basis of its direction, so such a
line failed ("current load stepping stopped at drag fraction 0.519") where
the same line with a 1e9 N m/rad rotational spring, or pinned, solved: a
2982 m cable clamped at its fairlead in a 1.1 m/s current that folds its
grounded run back past the anchor.
The continuation now carries a Rigid end as the static solve does: the
residual and tangent come in the end-direction basis (CD_EndConn_Basis), the
drag load is turned into it, the two transverse components of the end tangent
are held, and each solved increment and path tangent is turned back to global
components. Decks whose load steps converge are unchanged; every example gives
the same output.
The new arclength_rigid_end test solves the clamped cable and requires its end
tensions within 1e-3 of the 1e9 N m/rad spring line's.
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one change, so that they do not conflict with each other. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
1107a25 to
11863e7
Compare
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The drag pseudo-arclength continuation of the finite-EI static solve was switched off whenever an end was Rigid. Only plain load steps were left, and they fail on a hairpin with a clamped end (fuzz campaign case dynexc_45265).
The arclength now carries the Rigid end's basis:
CD_EndConn_Basisof the end direction, with the two transverse tangent components held. The drag load is rotated into that basis, as the residual and tangent already are, and each solved increment and tangent is rotated back to global components before the bordered update.Test.
arclength_rigid_end: on the 100-element deck at u = 1.12, the Rigid result matches a 1e9 N·m/rad spring end within 1e-3. CTest passes on both BLAS kernels. Examples are unchanged.