Skip to content

fix(syrope): every element of a one-section rope takes its own static secant - #138

Merged
SMI-Lab-Inha merged 3 commits into
devfrom
fix/syrope-element-secants
Nov 8, 2026
Merged

SMI-Lab-Inha merged 3 commits into
devfrom
fix/syrope-element-secants

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

A single-section Syrope rope took one secant EA from its working curve, at the rope's mean strain. On a long or inclined taut rope the tension varies along the rope by up to 15 %, so elements away from the mean started off their curve. Their slow strains then settled the line after the start: held at rest, the fairlead tension moved by 1.2e-4 to 6.1e-4 in 1 s (3.4e-4 on a 991 m rope).

Every Syrope line now runs the per-element secant iteration that composite lines already used, with the same convergence and table checks. A single-section line still starts that iteration from the secant at the strain its taut geometry fixes.

Check. All 125 Syrope lines of the fuzz campaign now start at rest to 1e-6.

Test. syrope_taut_rest holds three deep ropes (481 to 991 m) at rest for 1 s, to 1e-6. CTest passes on both BLAS kernels; pytest passes.

Result changes. Static tensions of single-section Syrope lines move by up to 3.2e-4 (relative). The Syrope example, a short level rope, and every other example are unchanged.

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T20:08:01.817529Z 6d7c8d7 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

read-the-docs-community Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35738704 | 📁 Comparing 6d7c8d7 against latest (e8f88f5)

  🔍 Preview build  

10 files changed · ± 10 modified

± Modified

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2eac9c979d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/CableDyn_DeckDriver.f90 Resolved
@SMI-Lab-Inha
SMI-Lab-Inha force-pushed the fix/syrope-element-secants branch from 2eac9c9 to bb6924c Compare November 8, 2026 17:11
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: bb6924c2ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 6af1eda09a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

… secant

The static start of a Syrope line solves its elements on the rest curve of
their load history with secant EAs. A composite line iterates one secant per
element, from the curve's strain at the element's tension; a single-section
line took one secant for the whole rope, from the curve at its mean strain.
On a long or inclined taut rope the weight makes the tension vary along it,
so the elements away from the mean started off their curve and their slow
strains settled the line at rest: three deep polyester ropes (481 to 991 m,
tension falling by up to 15 % to the anchor) moved their fairlead tension by
1.2e-4 to 6.1e-4 in 1 s held at rest; 63 of 125 random Syrope lines drifted
by more than 1e-5.

Every Syrope line now takes the per-element iteration (a single-section line
starts it from the secant at the strain its taut geometry fixes), with the
same convergence and table checks a composite line has. The 125 lines start
at rest to 1e-6, their static tensions move by up to 3.2e-4, and the Syrope
example, whose rope is short and level, gives the same output.

The new syrope_taut_rest test holds the three ropes at rest for 1 s and
requires their end tensions at the static values to 1e-6.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one
change, so that they do not conflict with each other.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…he secant step

With every one-section rope on the per-element tension update, a strongly
concave working curve (secant far above tangent) made the update overshoot
the curve's crossing and cycle: T = 1e6 eps^0.4 on a vertical 20 m rope of
two elements cycled between about 108 and 560 kN and the statics failed
after 50 iterations.

An update that reverses the previous one and is at least half of it now
takes the secant step on the line's response (response_root) where it lies
between the secant and the update, else half the update. A response of fixed
strain (a taut rope whose geometry sets its strain) crosses the curve at that
strain. Updates in the same direction, and alternating ones that contract,
are unchanged: both Syrope examples are byte-identical.

test_syrope_taut_rest gains the concave rope (it failed before); it starts
at rest to 1e-6. CTest 372/372 on both BLAS kernels.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@SMI-Lab-Inha
SMI-Lab-Inha force-pushed the fix/syrope-element-secants branch from 6af1eda to 6d7c8d7 Compare November 8, 2026 20:06
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 6d7c8d7862

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 252501e into dev Nov 8, 2026
22 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/syrope-element-secants branch November 9, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant