Repository navigation
fix(deck): a line of EI = 0 and finite-EI sections runs standalone as on the aggregate - #139
Merged
Merged
Conversation
… on the aggregate Every route classifies a line by line_is_finite_ei: a line with any finite-EI section is a finite-EI cable, whose EI = 0 sections carry no bending. The C API and OpenFAST aggregate build such a line that way, and so does the standalone driver when the deck also has a separate EI = 0 line (it then runs on the aggregate). Without one, the standalone finite-EI march refused the deck, because its guard required every section of every line to be finite-EI. The guard now refuses only a line without a finite-EI section, the case the standalone executable never sends there, and builds the split line with the same builder (build_one_hermite_cable) as the aggregate. all_lines_have_finite_ei has no other use and goes. The validator rule refusing the split line on the deck-driver route goes with the refusal. A split line driven by a prescribed surge reports the same channels through the driver and through the C API's stepping of the same deck, to the eight digits of the output file (largest relative difference 4.0e-8, as for an all-finite-EI line, 3.9e-8), with the EI = 0 section at either end. Tests: test_objects compares the driver run with the C API stepping over ten steps for both section orders (fails before: the driver refused the deck); test_deck_driver runs the split line; the parity cases accept it. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one change, so that they do not conflict with each other. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every other route (the C API, OpenFAST, the aggregate) treats a line that combines EI = 0 and finite-EI sections as one finite-EI cable, using the same predicate and the same builder. Only the guard of the standalone finite-EI march demanded that every section be finite-EI, so such a line was refused unless the deck also had a separate EI = 0 line.
The guard now refuses only a line with no finite-EI section, which the executable never sends to that route. The now-unused
all_lines_have_finite_eihelper is removed, and the Python validator accepts the line, as the solver now does. This reverses the named refusal that #127 added for such lines.Check. The same deck was stepped through the driver (with a motion file) and through the C API, under a smooth 0.5 m surge over 20 steps. The largest relative difference is:
These are at the 8-digit precision of the output file.
Test. A driver-vs-C-API test in
test_objectsfor both section orders; it failed before because the driver refused the deck. CTest passes on both BLAS kernels; pytest passes.