Skip to content

fix(deck): a line of EI = 0 and finite-EI sections runs standalone as on the aggregate - #139

Merged
SMI-Lab-Inha merged 2 commits into
devfrom
fix/split-line-route
Nov 8, 2026
Merged

SMI-Lab-Inha merged 2 commits into
devfrom
fix/split-line-route

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

Every other route (the C API, OpenFAST, the aggregate) treats a line that combines EI = 0 and finite-EI sections as one finite-EI cable, using the same predicate and the same builder. Only the guard of the standalone finite-EI march demanded that every section be finite-EI, so such a line was refused unless the deck also had a separate EI = 0 line.

The guard now refuses only a line with no finite-EI section, which the executable never sends to that route. The now-unused all_lines_have_finite_ei helper is removed, and the Python validator accepts the line, as the solver now does. This reverses the named refusal that #127 added for such lines.

Check. The same deck was stepped through the driver (with a motion file) and through the C API, under a smooth 0.5 m surge over 20 steps. The largest relative difference is:

Deck Largest relative difference
EI = 0 section at the fairlead 4.0e-8
EI = 0 section at the anchor 4.8e-8
All finite-EI control 3.9e-8

These are at the 8-digit precision of the output file.

Test. A driver-vs-C-API test in test_objects for both section orders; it failed before because the driver refused the deck. CTest passes on both BLAS kernels; pytest passes.

… on the aggregate

Every route classifies a line by line_is_finite_ei: a line with any finite-EI
section is a finite-EI cable, whose EI = 0 sections carry no bending. The C API
and OpenFAST aggregate build such a line that way, and so does the standalone
driver when the deck also has a separate EI = 0 line (it then runs on the
aggregate). Without one, the standalone finite-EI march refused the deck,
because its guard required every section of every line to be finite-EI.

The guard now refuses only a line without a finite-EI section, the case the
standalone executable never sends there, and builds the split line with the
same builder (build_one_hermite_cable) as the aggregate. all_lines_have_finite_ei
has no other use and goes. The validator rule refusing the split line on the
deck-driver route goes with the refusal.

A split line driven by a prescribed surge reports the same channels through
the driver and through the C API's stepping of the same deck, to the eight
digits of the output file (largest relative difference 4.0e-8, as for an
all-finite-EI line, 3.9e-8), with the EI = 0 section at either end.

Tests: test_objects compares the driver run with the C API stepping over ten
steps for both section orders (fails before: the driver refused the deck);
test_deck_driver runs the split line; the parity cases accept it.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
The [Unreleased] entries of the open changes are added together in one
change, so that they do not conflict with each other.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T17:50:37.832188Z 9fbee9c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 9fbee9cb5f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35737055 | 📁 Comparing 9fbee9c against latest (e8f88f5)

  🔍 Preview build  

10 files changed · ± 10 modified

± Modified

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 0a29d9e into dev Nov 8, 2026
22 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/split-line-route branch November 9, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant