Skip to content

feat: in-line VIV of finite-EI cables (the VIV section) - #145

Merged
SMI-Lab-Inha merged 1 commit into
devfrom
feat/inline-viv
Nov 11, 2026
Merged

SMI-Lab-Inha merged 1 commit into
devfrom
feat/inline-viv

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

Summary

Adds the in-line vortex-shedding force of Ulveseter, Thorsen, Sævik and Larsen (Mar. Struct. 60, 2018, 241–260) to finite-EI cables. You turn it on with an optional VIV deck section:

--------------------- VIV ----------------------------------------------
TypeName   ClX    alpha
(-)        (-)    (-)
riser      0.85   0.15
  • Force: per unit length 1/2 rho D ClX cos(phi_x) U v_n, along the relative normal flow (the drag direction).
  • Phase: d phi_x/dt = 2 (d phi/dt) [1 + alpha sin(phi_xd - phi_x)]. It is slaved to twice the cross-flow shedding rate, within the band alpha (default 0.15). ClX > 0 needs the type's LINE TYPES Cl > 0.
  • Kernels (CableDyn_VIV): the node and per-length in-line forces with exact Jacobians, the in-line motion, and the phase rate. They are shared, so the EI = 0 path can use them next.
  • Hermite cable:
    • the force is integrated with the lift at its Gauss points;
    • the phase is explicit with the Heun commit, and its end rate comes from the end cross-flow rate;
    • the phase is part of the step-recovery and snapshot state and of the HFMF checkpoint, which adds 3 nn values to the VIV block.
  • Deck:
    • both readers take the section;
    • both refuse, by name: malformed rows, unknown or repeated types, ClX on a type without the lift, alpha outside [0, 1), and in-line VIV on an EI = 0 line (that path is a follow-up PR);
    • the Python builder writes and reads the section.
  • Example and docs: a new example, viv_taut_cable_inline.dat; docs in the theory, driver-format, capabilities, outputs and examples pages. The LINE TYPES Cl dF cF columns, which were undocumented in driver_format.md, are now described there too.

Validation

The test case is the taut line of the lock-in benchmark, run as a finite-EI cable. Over 50–100 s:

Mid-span cross-flow Quarter-span in-line
With in-line VIV 0.294 Hz 0.574 Hz (ratio 1.95); A/D 0.19
Cross-flow lift only — A/D 0.025

On the Hermite march the ratio is 2.000.

Other checks:

  • kernel forces and Jacobians match central differences (element Jacobians to 7e-10);
  • ClX = 0 reproduces the cross-flow-only run bit for bit;
  • snapshot replay, the recovering step and the HFMF mirror round trip are bit-exact;
  • the Python validator and the native driver agree on 15 accept/refuse decks.

Checks

  • Full ctest, default OpenBLAS kernel: 411/412 on the first run. The one failure was example_deck_style, because the new example lacked the full OPTIONS block. After the fix it passes with the 60 example tests, but I did not rerun the full suite on this kernel.
  • Full ctest, Prescott kernel: 412/412.
  • Debug -fcheck=all: the VIV, damping, Hermite, HFMF and deck subsets pass (46 tests).
  • Example scan: 62 decks on two kernels, 0 flagged lines, no exit-code differences.
  • Python: 2180 passed. Sphinx -W: clean. pre-commit: clean.

The synchronisation model carried the cross-flow lift only. A finite-EI
line type now takes the in-line shedding force of Ulveseter, Thorsen,
Saevik and Larsen (Mar. Struct. 60, 2018), an optional VIV section row
TypeName ClX [alpha]: per unit length 1/2 rho D ClX cos(phi_x) U v_n
along the relative normal flow, the direction of the drag, with its
phase slaved to twice the cross-flow one,
d phi_x/dt = 2 (d phi/dt) [1 + alpha sin(phi_xd - phi_x)], phi_xd the
phase of the in-line motion from the running RMS values (alpha 0.15 by
default). ClX > 0 needs the type's cross-flow Cl > 0.

The kernels give the node and per-length forces with exact Jacobians and
the in-line motion and phase rate. The Hermite cable integrates the force
with the lift at its Gauss points; the phase is explicit with the Heun
commit (its end rate from the end cross-flow rate) and sits in the
step-recovery, snapshot and HFMF checkpoint state (3 nn more values in
the VIV block). Both deck readers take the section and refuse malformed
rows, unknown or repeated types, ClX on a type without the lift, alpha
outside [0, 1) and in-line VIV on an EI = 0 line, which follows later;
the Python builder writes and reads it.

Tests: kernel forces and Jacobians against central differences; on the
taut line of the lock-in benchmark the in-line response runs at twice
the cross-flow frequency (2.000 on the Hermite march, 1.95 through the
deck) with A/D 0.19 against 0.03 from the lift alone; ClX 0 reproduces
the cross-flow-only run bit for bit; snapshot replay, the recovering
step and the mirror round trip are bit-exact. New example
viv_taut_cable_inline.dat.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T06:07:36.377661Z cadd933 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35805106 | 📁 Comparing cadd933 against latest (789cb6d)

  🔍 Preview build  

9 files changed · ± 9 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: cadd933db2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 7e6350c into dev Nov 11, 2026
22 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the feat/inline-viv branch November 11, 2026 08:38
SMI-Lab-Inha added a commit that referenced this pull request Nov 11, 2026
#145 gave finite-EI cables the in-line shedding force of Ulveseter et
al. (2018) and refused it on EI = 0 lines (the two-node elements with
consistent mass). Those lines now take it too, so a VIV section row
acts wherever the cross-flow lift does.

On an EI = 0 line the in-line force is a node force like the lift,
1/4 rho d C_x (l_i + l_i+1) U cos(phi_x) v_n, with the lift's wetted
fractions, node tangent and neighbour-averaged kinematics, and its
exact velocity and neighbour-position Jacobians. The in-line phase
starts at twice the cross-flow phase and advances with the Heun
commit, its end-state rate slaved to the end cross-flow rate, as on
the cable.

The in-line phase and mean squares follow the cross-flow state
everywhere it goes: the sub-step slots, step recovery, the system's
rollback and frame snapshot, model copies, and the OpenFAST line
checkpoint (3 more reals per node).

Checks:
- the deck of #145 as an EI = 0 line matches the finite-EI cable:
  CF A/D 0.8228 vs 0.8219, IL A/D 0.1915 vs 0.1905, the same
  frequencies;
- coupled restart and rewind with in-line VIV continue bit for bit,
  and a rebuild without the VIV state does not;
- the sub-stepping restore of tests/test_model carries the in-line
  state;
- full ctest 412/412 on the default and Prescott kernels, Debug
  -fcheck=all on the VIV, model and system tests, pytest, the example
  fallback scan clean.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant