Repository navigation
feat: in-line VIV of finite-EI cables (the VIV section) - #145
Merged
Merged
Conversation
The synchronisation model carried the cross-flow lift only. A finite-EI line type now takes the in-line shedding force of Ulveseter, Thorsen, Saevik and Larsen (Mar. Struct. 60, 2018), an optional VIV section row TypeName ClX [alpha]: per unit length 1/2 rho D ClX cos(phi_x) U v_n along the relative normal flow, the direction of the drag, with its phase slaved to twice the cross-flow one, d phi_x/dt = 2 (d phi/dt) [1 + alpha sin(phi_xd - phi_x)], phi_xd the phase of the in-line motion from the running RMS values (alpha 0.15 by default). ClX > 0 needs the type's cross-flow Cl > 0. The kernels give the node and per-length forces with exact Jacobians and the in-line motion and phase rate. The Hermite cable integrates the force with the lift at its Gauss points; the phase is explicit with the Heun commit (its end rate from the end cross-flow rate) and sits in the step-recovery, snapshot and HFMF checkpoint state (3 nn more values in the VIV block). Both deck readers take the section and refuse malformed rows, unknown or repeated types, ClX on a type without the lift, alpha outside [0, 1) and in-line VIV on an EI = 0 line, which follows later; the Python builder writes and reads it. Tests: kernel forces and Jacobians against central differences; on the taut line of the lock-in benchmark the in-line response runs at twice the cross-flow frequency (2.000 on the Hermite march, 1.95 through the deck) with A/D 0.19 against 0.03 from the lift alone; ClX 0 reproduces the cross-flow-only run bit for bit; snapshot replay, the recovering step and the mirror round trip are bit-exact. New example viv_taut_cable_inline.dat. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
SMI-Lab-Inha
added a commit
that referenced
this pull request
Nov 11, 2026
#145 gave finite-EI cables the in-line shedding force of Ulveseter et al. (2018) and refused it on EI = 0 lines (the two-node elements with consistent mass). Those lines now take it too, so a VIV section row acts wherever the cross-flow lift does. On an EI = 0 line the in-line force is a node force like the lift, 1/4 rho d C_x (l_i + l_i+1) U cos(phi_x) v_n, with the lift's wetted fractions, node tangent and neighbour-averaged kinematics, and its exact velocity and neighbour-position Jacobians. The in-line phase starts at twice the cross-flow phase and advances with the Heun commit, its end-state rate slaved to the end cross-flow rate, as on the cable. The in-line phase and mean squares follow the cross-flow state everywhere it goes: the sub-step slots, step recovery, the system's rollback and frame snapshot, model copies, and the OpenFAST line checkpoint (3 more reals per node). Checks: - the deck of #145 as an EI = 0 line matches the finite-EI cable: CF A/D 0.8228 vs 0.8219, IL A/D 0.1915 vs 0.1905, the same frequencies; - coupled restart and rewind with in-line VIV continue bit for bit, and a rebuild without the VIV state does not; - the sub-stepping restore of tests/test_model carries the in-line state; - full ctest 412/412 on the default and Prescott kernels, Debug -fcheck=all on the VIV, model and system tests, pytest, the example fallback scan clean. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the in-line vortex-shedding force of Ulveseter, Thorsen, Sævik and Larsen (Mar. Struct. 60, 2018, 241–260) to finite-EI cables. You turn it on with an optional
VIVdeck section:1/2 rho D ClX cos(phi_x) U v_n, along the relative normal flow (the drag direction).d phi_x/dt = 2 (d phi/dt) [1 + alpha sin(phi_xd - phi_x)]. It is slaved to twice the cross-flow shedding rate, within the bandalpha(default 0.15).ClX > 0needs the type's LINE TYPESCl > 0.CableDyn_VIV): the node and per-length in-line forces with exact Jacobians, the in-line motion, and the phase rate. They are shared, so the EI = 0 path can use them next.ClXon a type without the lift,alphaoutside [0, 1), and in-line VIV on an EI = 0 line (that path is a follow-up PR);viv_taut_cable_inline.dat; docs in the theory, driver-format, capabilities, outputs and examples pages. The LINE TYPESCl dF cFcolumns, which were undocumented indriver_format.md, are now described there too.Validation
The test case is the taut line of the lock-in benchmark, run as a finite-EI cable. Over 50–100 s:
On the Hermite march the ratio is 2.000.
Other checks:
ClX = 0reproduces the cross-flow-only run bit for bit;Checks
example_deck_style, because the new example lacked the full OPTIONS block. After the fix it passes with the 60 example tests, but I did not rerun the full suite on this kernel.-fcheck=all: the VIV, damping, Hermite, HFMF and deck subsets pass (46 tests).-W: clean. pre-commit: clean.