Repository navigation
feat: in-line VIV on EI = 0 lines - #146
Merged
Merged
Conversation
#145 gave finite-EI cables the in-line shedding force of Ulveseter et al. (2018) and refused it on EI = 0 lines. The lumped-mass line now takes it too, so a VIV section row acts wherever the cross-flow lift does. On an EI = 0 line the in-line force is a node force like the lift, 1/4 rho d C_x (l_i + l_i+1) U cos(phi_x) v_n, with the lift's wetted fractions, node tangent and neighbour-averaged kinematics, and its exact velocity and neighbour-position Jacobians. The in-line phase starts at twice the cross-flow phase and advances with the Heun commit, its end-state rate slaved to the end cross-flow rate, as on the cable. The in-line phase and mean squares follow the cross-flow state everywhere it goes: the sub-step slots, step recovery, the system's rollback and frame snapshot, model copies, and the OpenFAST line checkpoint (3 more reals per node). Checks: - the deck of #145 as an EI = 0 line matches the finite-EI cable: CF A/D 0.8228 vs 0.8219, IL A/D 0.1915 vs 0.1905, the same frequencies; - coupled restart and rewind with in-line VIV continue bit for bit, and a rebuild without the VIV state does not; - the sub-stepping restore of tests/test_model carries the in-line state; - full ctest 412/412 on the default and Prescott kernels, Debug -fcheck=all on the VIV, model and system tests, pytest, the example fallback scan clean. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#145 gave finite-EI cables the in-line shedding force of Ulveseter et
al. (2018) and refused it on EI = 0 lines (the two-node elements with
consistent mass). Those lines now take it too, so a VIV section row
acts wherever the cross-flow lift does.
On an EI = 0 line the in-line force is a node force like the lift,
1/4 rho d C_x (l_i + l_i+1) U cos(phi_x) v_n, with the lift's wetted
fractions, node tangent and neighbour-averaged kinematics, and its
exact velocity and neighbour-position Jacobians. The in-line phase
starts at twice the cross-flow phase and advances with the Heun
commit, its end-state rate slaved to the end cross-flow rate, as on
the cable.
The in-line phase and mean squares follow the cross-flow state
everywhere it goes: the sub-step slots, step recovery, the system's
rollback and frame snapshot, model copies, and the OpenFAST line
checkpoint (3 more reals per node).
Checks:
CF A/D 0.8228 vs 0.8219, IL A/D 0.1915 vs 0.1905, the same
frequencies;
and a rebuild without the VIV state does not;
state;
-fcheck=all on the VIV, model and system tests, pytest, the example
fallback scan clean.