Skip to content

feat: in-line VIV on EI = 0 lines - #146

Merged
SMI-Lab-Inha merged 1 commit into
devfrom
feat/inline-viv-ei0
Nov 11, 2026
Merged

SMI-Lab-Inha merged 1 commit into
devfrom
feat/inline-viv-ei0

Conversation

@SMI-Lab-Inha

@SMI-Lab-Inha SMI-Lab-Inha commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

#145 gave finite-EI cables the in-line shedding force of Ulveseter et
al. (2018) and refused it on EI = 0 lines (the two-node elements with
consistent mass). Those lines now take it too, so a VIV section row
acts wherever the cross-flow lift does.

On an EI = 0 line the in-line force is a node force like the lift,
1/4 rho d C_x (l_i + l_i+1) U cos(phi_x) v_n, with the lift's wetted
fractions, node tangent and neighbour-averaged kinematics, and its
exact velocity and neighbour-position Jacobians. The in-line phase
starts at twice the cross-flow phase and advances with the Heun
commit, its end-state rate slaved to the end cross-flow rate, as on
the cable.

The in-line phase and mean squares follow the cross-flow state
everywhere it goes: the sub-step slots, step recovery, the system's
rollback and frame snapshot, model copies, and the OpenFAST line
checkpoint (3 more reals per node).

Checks:

  • the deck of feat: in-line VIV of finite-EI cables (the VIV section) #145 as an EI = 0 line matches the finite-EI cable:
    CF A/D 0.8228 vs 0.8219, IL A/D 0.1915 vs 0.1905, the same
    frequencies;
  • coupled restart and rewind with in-line VIV continue bit for bit,
    and a rebuild without the VIV state does not;
  • the sub-stepping restore of tests/test_model carries the in-line
    state;
  • full ctest 412/412 on the default and Prescott kernels, Debug
    -fcheck=all on the VIV, model and system tests, pytest, the example
    fallback scan clean.

#145 gave finite-EI cables the in-line shedding force of Ulveseter et
al. (2018) and refused it on EI = 0 lines. The lumped-mass line now
takes it too, so a VIV section row acts wherever the cross-flow lift
does.

On an EI = 0 line the in-line force is a node force like the lift,
1/4 rho d C_x (l_i + l_i+1) U cos(phi_x) v_n, with the lift's wetted
fractions, node tangent and neighbour-averaged kinematics, and its
exact velocity and neighbour-position Jacobians. The in-line phase
starts at twice the cross-flow phase and advances with the Heun
commit, its end-state rate slaved to the end cross-flow rate, as on
the cable.

The in-line phase and mean squares follow the cross-flow state
everywhere it goes: the sub-step slots, step recovery, the system's
rollback and frame snapshot, model copies, and the OpenFAST line
checkpoint (3 more reals per node).

Checks:
- the deck of #145 as an EI = 0 line matches the finite-EI cable:
  CF A/D 0.8228 vs 0.8219, IL A/D 0.1915 vs 0.1905, the same
  frequencies;
- coupled restart and rewind with in-line VIV continue bit for bit,
  and a rebuild without the VIV state does not;
- the sub-stepping restore of tests/test_model carries the in-line
  state;
- full ctest 412/412 on the default and Prescott kernels, Debug
  -fcheck=all on the VIV, model and system tests, pytest, the example
  fallback scan clean.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T08:49:47.262746Z ac60c84 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35807809 | 📁 Comparing ac60c84 against latest (789cb6d)

  🔍 Preview build  

9 files changed · ± 9 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: ac60c84876

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 4a91d68 into dev Nov 11, 2026
22 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the feat/inline-viv-ei0 branch November 11, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant