Repository navigation
feat: load power channels VIVPow, DragPow and DampPow - #147
Merged
Merged
Conversation
A VIV study needs the energy ledger of the response: what the VIV loads put into a line against what the drag and the structural damping take out, along the line and over the run. The OUTPUTS channels VIVPow<L>, DragPow<L> and DampPow<L> [W] report the power these loads deliver to line L at the committed state, and <name><L>N<J> [W/m] the same per unit unstretched length about node J. The power of a load on an element is its nodal (finite-EI: generalised) load times the element's velocities, the exact rate of work of the load the solver applies; a node load delivers f . v at its node. A node takes half of each of its elements' power, so the node values sum to the line total, and an element's damping power, hence a node's, is never positive. - VIV: the cross-flow lift and the in-line force of a VIV section row. - Drag: the Morison drag, and on a finite-EI line its ATTACHMENTS' drag. - Damping: the axial dashpot BA, and the bending dashpot Bb on a finite-EI line. The torsional Bt and the viscoelastic and Syrope laws' internal damping are not included (documented). They run on EI = 0 lines and finite-EI cables, on the single-line, point-system, multibody, coupled (OpenFAST, FAST.Farm) and C API routes; a static run reports 0. The residual-only Morison drag call of the finite-EI element, written out three times, is one helper now (element_drag_load), with the same arguments as before. Checks: - tests/test_hermite_load_power: the work of the three loads closes a weightless cable's energy balance within 0.04 % of the largest work in a bending-dashpot decay, an axial-dashpot decay, a still-water drag decay and a VIV run in a current; - tests/test_load_power_deck: on the locked-in in-line VIV line the means balance within 0.04 % of the VIV power as a finite-EI cable, an EI = 0 line and two EI = 0 lines joined at a free point; the per-length channels of all nodes sum to the line total; malformed channels are refused by name; - tests/test_viv_coupled: on the coupled route both lines balance within 0.01 %; - the Python deck reader and builder mirror the channels (native parity of 13 spellings); - full ctest 414/414 on the default and Prescott kernels, Debug -fcheck=all on the new and touched tests, pytest, the example fallback scan clean. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A VIV study needs the energy ledger of the response: what the VIV loads
put into a line against what the drag and the structural damping take
out, along the line and over the run. The OUTPUTS channels
VIVPow, DragPow and DampPow [W] report the power these loads
deliver to line L at the committed state, and N [W/m] the
same per unit unstretched length about node J.
The power of a load on an element is its nodal (finite-EI:
generalised) load times the element's velocities, the exact rate of
work of the load the solver applies; a node load delivers f . v at its
node. A node takes half of each of its elements' power, so the node
values sum to the line total, and an element's damping power, hence a
node's, is never positive.
drag.
finite-EI line. The torsional Bt and the viscoelastic and Syrope
laws' internal damping are not included (documented).
They run on EI = 0 lines and finite-EI cables, on the single-line,
point-system, multibody, coupled (OpenFAST, FAST.Farm) and C API
routes; a static run reports 0. The residual-only Morison drag call of
the finite-EI element, written out three times, is one helper now
(element_drag_load), with the same arguments as before.
Checks:
weightless cable's energy balance within 0.04 % of the largest work
in a bending-dashpot decay, an axial-dashpot decay, a still-water
drag decay and a VIV run in a current;
means balance within 0.04 % of the VIV power as a finite-EI cable,
an EI = 0 line and two EI = 0 lines joined at a free point; the
per-length channels of all nodes sum to the line total; malformed
channels are refused by name;
within 0.01 %;
parity of 13 spellings);
-fcheck=all on the new and touched tests, pytest, the example
fallback scan clean.