Repository navigation
feat: section-point stress and fatigue of biaxial bending - #149
Merged
Merged
Conversation
The stress recovery for fatigue took the curvature magnitude at the two extreme fibres, T/A +/- E kappa r, so it did not follow the bending plane. Under combined cross-flow and in-line VIV the plane turns, and a whirling section, whose curvature magnitude stays constant, showed no cycles and no damage, although every point around it reverses once a revolution. section_stress takes the curvature vector on the section axes, the CurvX/CurvY channels of a finite-EI line (bending strain -(kx x + ky y)), and returns the stress at points around the section, sigma(theta) = T/A - E r (kappa_x cos theta + kappa_y sin theta). damage_along_arc(..., quantity="section", points=16) counts each point, keeps the largest damage and reports its angle (critical_angle on DamageProfile, None for the other quantities). The node-channel reader now knows the CurvX and CurvY prefixes. Checks: the stress of a known curvature vector point by point; in a fixed bending plane the extreme points are cable_stress's two fibres; a whirling section has no damage under "stress" and its point-by-point damage under "section"; missing or mismatched channels and a T-N curve are refused. pytest, ruff, mypy strict, Sphinx -W. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stress recovery for fatigue took the curvature magnitude at the two
extreme fibres, T/A +/- E kappa r, so it did not follow the bending
plane. Under combined cross-flow and in-line VIV the plane turns, and a
whirling section, whose curvature magnitude stays constant, showed no
cycles and no damage, although every point around it reverses once a
revolution.
section_stress takes the curvature vector on the section axes, the
CurvX/CurvY channels of a finite-EI line (bending strain -(kx x + ky y)),
and returns the stress at points around the section,
sigma(theta) = T/A - E r (kappa_x cos theta + kappa_y sin theta).
damage_along_arc(..., quantity="section", points=16) counts each point,
keeps the largest damage and reports its angle (critical_angle on
DamageProfile, None for the other quantities). The node-channel reader
now knows the CurvX and CurvY prefixes.
Checks: the stress of a known curvature vector point by point; in a
fixed bending plane the extreme points are cable_stress's two fibres;
a whirling section has no damage under "stress" and its point-by-point
damage under "section"; missing or mismatched channels and a T-N curve
are refused. pytest, ruff, mypy strict, Sphinx -W.