Skip to content

feat: VIV columns after the 14-column finite-EI LINE TYPES row - #152

Merged
SMI-Lab-Inha merged 1 commit into
devfrom
feat/viv-torsion-row
Nov 12, 2026
Merged

SMI-Lab-Inha merged 1 commit into
devfrom
feat/viv-torsion-row

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

Summary

Lets a line restrained in torsion take cross-flow VIV. Until now, a torsion-restrained power cable had no way to get VIV.

Such a line takes GJ and Irn from the 14-column LINE TYPES row (GAs GJ Irt Irn), and that row had no room for the VIV columns. It now accepts Cl, or Cl dF cF, after its fourteen columns.

Deck input

Row width Columns after the 14th Defaults
14 none no VIV
15 Cl dF = 0.08, cF = 0.18
17 Cl dF cF none

The values are checked as in the 11- and 13-column rows. The VIV wiring depends neither on the row width nor on the nodal twist, so nothing else changes.

Python

  • DeckFile accepts the 15- and 17-column widths, reads Cl dF cF after the fourteenth column and names them cl, df and cf in the field paths.
  • builder writes them after the wide row instead of refusing the combination.

Checks

  • tests/test_viv_inline_deck.f90 D6:
    • a 17-column row free in torsion reproduces the 13-column deck to the printed digits;
    • a 15-column row equals the 17-column one with 0.08 and 0.18;
    • with the line rigid in torsion at both ends (nodal twist solved), the lift locks the cable in at A/D 0.66 and 0.292 Hz. These are the amplitude and frequency of the line free in torsion, as expected with no torque–tension coupling.
  • Python: rows are read, kept and refused as the native reader does them (test_deck_file.py), and the builder round-trips them (test_builder.py).
  • Full ctest under the default and Prescott BLAS kernels; pytest, ruff, mypy, Sphinx -W and pre-commit.

A line restrained in torsion takes GJ and Irn from the 14-column
LINE TYPES row (GAs GJ Irt Irn), and that row could not carry
MoorDyn's cross-flow VIV columns: a torsion-restrained power cable had
no way to get VIV. The row now takes Cl, or Cl dF cF, after its
fourteen columns (15 or 17 columns), with MoorDyn's dF = 0.08 and
cF = 0.18 where only Cl is given and the checks of the 11- and
13-column rows. The VIV wiring does not depend on the row width or on
the nodal twist, so nothing else changes.

The Python deck reader takes the widths, reads Cl dF cF after the
fourteenth column and names them cl, df, cf in the field paths; the
builder writes them after the wide row instead of refusing the
combination.

Checks (tests/test_viv_inline_deck.f90, D6): a 17-column row free in
torsion is the 13-column deck to the printed digits; a 15-column row
is the 17-column one with 0.08 and 0.18; on the line rigid in torsion
at both ends (nodal twist solved) the lift locks the cable in at A/D
0.66 and 0.292 Hz, the amplitude and frequency of the line free in
torsion, as it must be with no torque-tension coupling. Python: read,
kept and refused like the native reader (test_deck_file.py), builder
round trip (test_builder.py). Full ctest under both BLAS kernels,
pytest, ruff, mypy, Sphinx -W, pre-commit.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T09:44:24.255159Z 67b4240 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35835167 | 📁 Comparing 67b4240 against latest (789cb6d)

  🔍 Preview build  

12 files changed · ± 12 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 67b4240969

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit df0324f into dev Nov 12, 2026
22 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the feat/viv-torsion-row branch November 12, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant