Repository navigation
feat: VIV columns after the 14-column finite-EI LINE TYPES row - #152
Merged
Merged
Conversation
A line restrained in torsion takes GJ and Irn from the 14-column LINE TYPES row (GAs GJ Irt Irn), and that row could not carry MoorDyn's cross-flow VIV columns: a torsion-restrained power cable had no way to get VIV. The row now takes Cl, or Cl dF cF, after its fourteen columns (15 or 17 columns), with MoorDyn's dF = 0.08 and cF = 0.18 where only Cl is given and the checks of the 11- and 13-column rows. The VIV wiring does not depend on the row width or on the nodal twist, so nothing else changes. The Python deck reader takes the widths, reads Cl dF cF after the fourteenth column and names them cl, df, cf in the field paths; the builder writes them after the wide row instead of refusing the combination. Checks (tests/test_viv_inline_deck.f90, D6): a 17-column row free in torsion is the 13-column deck to the printed digits; a 15-column row is the 17-column one with 0.08 and 0.18; on the line rigid in torsion at both ends (nodal twist solved) the lift locks the cable in at A/D 0.66 and 0.292 Hz, the amplitude and frequency of the line free in torsion, as it must be with no torque-tension coupling. Python: read, kept and refused like the native reader (test_deck_file.py), builder round trip (test_builder.py). Full ctest under both BLAS kernels, pytest, ruff, mypy, Sphinx -W, pre-commit. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lets a line restrained in torsion take cross-flow VIV. Until now, a torsion-restrained power cable had no way to get VIV.
Such a line takes
GJandIrnfrom the 14-columnLINE TYPESrow (GAs GJ Irt Irn), and that row had no room for the VIV columns. It now acceptsCl, orCl dF cF, after its fourteen columns.Deck input
CldF = 0.08,cF = 0.18Cl dF cFThe values are checked as in the 11- and 13-column rows. The VIV wiring depends neither on the row width nor on the nodal twist, so nothing else changes.
Python
DeckFileaccepts the 15- and 17-column widths, readsCl dF cFafter the fourteenth column and names themcl,dfandcfin the field paths.builderwrites them after the wide row instead of refusing the combination.Checks
tests/test_viv_inline_deck.f90D6:test_deck_file.py), and the builder round-trips them (test_builder.py).-Wand pre-commit.