Repository navigation
feat: wake-oscillator VIV on finite-EI cables (WAKE OSCILLATOR section) - #154
Conversation
CableDyn's VIV follows the synchronisation model of Thorsen et al. The other model class in common use is the wake oscillator: a van der Pol oscillator stands for the near wake and drives the lift. A model-form comparison needs both on the same line. An optional WAKE OSCILLATOR section row TypeName CL0 [St [eps [A]]] gives a line type the wake oscillator of Facchinetti, de Langre and Biolley (J. Fluids Struct. 19, 2004), distributed along the line as in Violette et al. (2010): q'' + eps om (q^2 - 1) q' + om^2 q = (A/D) y'', om = 2 pi St U_a/D, lift per unit length 1/4 rho D CL0 q U^2 across the relative flow, with y'' the node's cross-flow acceleration (their acceleration coupling), U_a the ambient flow speed normal to the line (their free stream, so the cable's own cross-flow velocity does not modulate the wake frequency), U the relative normal flow speed of the lift (as the synchronisation lift), and the defaults St 0.2, eps 0.3, A 12 they fix from forced-wake data (checked in the PDF). Their fluid damping gamma om rho D^2 y', gamma = Cd/(4 pi St), is the linearised Morison drag CableDyn applies in full, so the wake adds the lift only. It replaces the synchronisation lift of the type, which keeps Cl 0; a line takes one VIV model. It is a mode of the cable's VIV configuration: Set_VIV takes the per-element (St, eps, A), the lift scale is 1/4 rho D CL0, and the element lift takes q at its end nodes in place of cos(phi), with the exact Jacobians at fixed q. The state (q, q') per node is advanced beside the cable like the phase: a predictor under the step-start acceleration for the step's lift, then from the committed state with the acceleration linear to the converged end one, at the step-start wake frequency (classical Runge-Kutta in sub-steps of om dt <= 0.1, CD_VIV_Wake_Advance). q starts on its limit cycle at the VIV phase seed, q = 2 cos(phi_0). The state is in the step-recovery, snapshot and checkpoint state and the OpenFAST mirror (2 nn values after the in-line block). Finite-EI cables only for now; an EI = 0 line with the wake oscillator is refused by name, as is a line mixing the models. The Python deck reader takes the section with the native checks, the builder writes it (LineType.wake_cl0, wake_st, wake_eps, wake_a). Checks: - tests/test_viv_wake_kernel.f90: the free oscillator settles on q = 2 at its period (the van der Pol shift eps^2/16); forced at its own frequency it follows the lift magnification of Facchinetti's Eq. 17 within 0.2 % at y0 = 0.05 and 1.9 % at 0.5 (the third harmonic their one-harmonic balance leaves out; halving the step changes K by 2e-5), and the sub-stepped advance converges at fourth order; - tests/test_viv_wake_deck.f90: on the taut cable of the in-line VIV gate with Cl 0 and CL0 0.3 the wake locks the cable in at 0.282 Hz, below its own 0.300 Hz, at a steady A/D 0.585; uncoupled (A 0) it drives the cable at 0.298 Hz at A/D 0.099; over the lock-in the drag and damping take out the wake lift's 2.84 W within 0.21 %; CL0 0 is the deck without the section to the printed digits; eleven refusals; - tests/test_viv_coupled.f90: on the coupled route the cable's checkpoint block grows by 2 nn, the restarted run continues bit for bit, a rebuild without the VIV state does not, and a rewound step repeats; - Python: rows read, kept and refused as natively; the builder writes the values given; five native/Python parity decks agree. Full ctest under both BLAS kernels, Debug -fcheck=all on the new tests, pytest, ruff, mypy, Sphinx -W, pre-commit. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0193895c53
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CD_VIV_Wake_Advance chose its RK4 sub-steps from om dt <= 0.1 alone. The van der Pol damping eps om (q^2 - 1) is a faster rate for a large eps, which the deck accepts: with eps 20 and om 1 the unforced oscillator from (2, 0) went non-finite within 0.5 s in 0.1 s calls. The sub-steps now satisfy r dt <= 0.1 with r = om max(1, eps q^2) at the start of the interval, and the interval is redone from its start with twice the sub-steps should the rate exceed 0.2/dt on the way or the result not be finite (up to 1e6 sub-steps). For the default eps 0.3 the count is unchanged until |q| > 1.83, so one call still equals two half calls to round-off; every documented wake result is unchanged at its printed digits. tests/test_viv_wake_kernel.f90 K4: eps 20 from (2, 0) in 0.1 s calls stays finite and matches 1 ms calls within 1e-13 at t = 1 s ((1.967, -0.034)). The theory text gives the new rule. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Adds the wake oscillator as a second VIV model for finite-EI cables, next to the synchronisation model of the
Clcolumn. A new optionalWAKE OSCILLATORsection gives a line type the van der Pol wake oscillator of Facchinetti, de Langre & Biolley (2004) with acceleration coupling, distributed along the line as in Violette et al. (2010).St,epsandAare optional. Their defaults (0.2, 0.3, 12) are the values Facchinetti et al. fit to forced-wake data. The type keepsCl = 0, and a line uses one VIV model.Model
At each node a van der Pol oscillator in the reduced lift coefficient$q = 2C_L/C_{L0}$ is forced by the node's cross-flow acceleration:
The lift per unit length acts across the relative normal flow, in the same direction as the synchronisation lift:
The paper's fluid damping,$\gamma\,\omega_f\,\rho D^2\dot y$ with $\gamma = C_D/(4\pi\,\mathrm{St})$ , is the linearised Morison drag, and CableDyn already applies that drag in full. The wake therefore contributes the lift only.
Implementation
Set_VIVtakes the per-element(St, eps, A). The element lift usesCD_VIV_Wake_Advance).2*nnvalues after the in-line block.LineType.wake_cl0,wake_st,wake_epsandwake_a.EI = 0line with the wake oscillator, a line mixing the two models, andCL0 > 0on a type withCl > 0.Verification
test_viv_wake_kerneltest_viv_wake_deckCl 0,CL0 0.3A = 0CL0 = 0test_viv_coupled2*nn. A restart continues bit for bit; a rebuild without the VIV state does not; a rewound step repeatsRun before opening:
ctestunder the default andOPENBLAS_CORETYPE=Prescottkernels;-fcheck=allon the new tests;pytest,ruff,mypy, Sphinx-W,pre-commit.Docs
doc/driver_format.md: the new section.doc/theory.rst: the Wake oscillator subsection.doc/references.rst: Facchinetti et al. (2004), doi:10.1016/j.jfluidstructs.2003.12.004, and Violette et al. (2010), doi:10.1016/j.jfluidstructs.2010.01.002.doc/capabilities.rstandCHANGELOG.md.The wake oscillator on
EI = 0lines is left for a follow-up, as was done for in-line VIV (#145 → #146).