Repository navigation
feat: diameter of the VIV model apart from the hydrodynamic one (VIV DIAMETER section) - #156
Merged
Merged
Conversation
…DIAMETER section) A lazy-wave cable's buoyancy modules are ATTACHMENTS rows on the bare cable: their mass, volume and drag are point loads, and the cable's line type keeps its own diameter for its drag, added mass and buoyancy. Its VIV then also took that diameter, while the shedding of a module zone is set by the larger module diameter. An optional VIV DIAMETER section row TypeName Dviv gives the VIV model of a line type a diameter of its own: the shedding frequency and band (or the wake frequency and its coupling A/D), the lift, in-line and higher-harmonic forces and the amplitude ratio of a VIV AMPLITUDE table take Dviv, the drag, added mass, buoyancy and contact keep Diam. A module zone is a section with a copy of the cable's type, Dviv the module diameter and its own coefficients; the docs say how, and that the shedding of alternating modules and bare cable has no established model. The type needs VIV (Cl > 0 or a WAKE OSCILLATOR row); one row a type. EI = 0 lines take it through the diameter CD_Set_Model_VIV already has; finite-EI cables through Set_VIV dviv (per element, 0 = the drag diameter, kept across a later Set_Drag), which viv_drag_terms and the amplitude-table helpers read. The Python deck reader mirrors the checks, the builder writes the row (LineType.viv_diameter). Checks: - tests/test_viv_diameter_deck.f90, on the taut gate line as an EI = 0 line and a finite-EI cable: Dviv = Diam is the deck without the section bit for bit; with the synchronisation lift the line locks in at 0.287 Hz, and with Dviv 0.2 m its band (0.075-0.195 Hz) lies below the mode and the phase runs at its top, 0.196 Hz; an uncoupled wake oscillator drives the cable at 0.149 Hz against St U/Dviv = 0.15 Hz; six refusals; - Python: rows read, kept and refused as natively, the builder writes them, six native/Python parity decks agree. Full ctest under both BLAS kernels, Debug -fcheck=all on the VIV tests, pytest, ruff, mypy, Sphinx -W, pre-commit. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a diameter of the VIV model apart from the hydrodynamic one. A new optional
VIV DIAMETERsection gives a line type's VIV model its own diameterDviv:The motivating case is a lazy-wave cable. Its buoyancy modules are
ATTACHMENTSrows on the bare cable, so their mass, volume and drag are point loads, and the line type keeps the cable's own diameter for drag, added mass and buoyancy. Until now its VIV took that diameter too, while the shedding of a module zone is set by the larger module diameter.What takes which diameter
DvivDiamVIV AMPLITUDEtableOne row per type,
Dviv > 0, and the type needs VIV (Cl > 0or aWAKE OSCILLATORrow). A deck without the section runs as before.The docs describe how to model a module zone: a section with a copy of the cable's type,
Dvivthe module diameter and its own coefficients. They also say plainly that the shedding of alternating modules and bare cable has no established model.Implementation
EI = 0lines: the diameterCD_Set_Model_VIValready takes; the driver passesDvivin place of the hydrodynamic diameter.Set_VIVtakesdviv(per element, 0 = the drag diameter).viv_diam(model, e)feedsviv_drag_termsand the amplitude-table helpers. A laterSet_Dragrecomputes the scales, so a 0 entry follows the new drag diameter. Rollback on a failedSet_VIVrestores the previous diameters.LineType.viv_diameter).Verification
tests/test_viv_diameter_deck.f90, on the taut gate line as anEI = 0line and as a finite-EI cable:Dviv = DiamDviv = DiamDviv0.2 mDviv0.2 mPython: rows read, kept and refused as natively, the builder writes them, and six native/Python parity decks agree.
Run before opening:
ctestunder the default andOPENBLAS_CORETYPE=Prescottkernels;-fcheck=allon the VIV tests;pytest,ruff,mypy, Sphinx-W,pre-commit.Docs
doc/driver_format.md: the section, and how to model a module zone.doc/theory.rst: the VIV diameter subsection.doc/capabilities.rst,CHANGELOG.md.