Repository navigation
feat: cross-flow damping on finite-EI cables (VIV DAMPING section) - #157
Merged
Merged
Conversation
An optional VIV DAMPING section row "TypeName a b [c]" splits the normal drag of a finite-EI line type in the frame of the ambient normal flow: Morison's drag in line (with the VIV AMPLITUDE drag factor) and, across it, 1/2 rho D [C_dy |w_y| + c Cdn |w|] w_y with C_dy = a + b y0/D, the cross-flow hydrodynamic damping of Thorsen et al. (2016, Eq. 1; 0.31 0.89 is their fit) at the amplitude estimate y0. Below an ambient normal flow of 0.01 m/s the force blends to Morison's, where the axes are undefined. CD_Morison_Drag_Split_Per_Length_Jac computes the split force with exact Jacobians in the relative velocity and the tangent. The dynamic finite-EI drag element takes it in the residual, the tangent and the element drag load. Statics is unchanged: at rest in the flow the split force is Morison's. Set_VIV takes cdy (2 or 3, n_elem), checks it and rolls it back with the rest of the VIV state. "0 0 1" is Morison's drag with the drag factor on the in-line part alone, so an amplified drag no longer damps the cross-flow VIV motion twice. Thorsen's quadratic form drops the linear U y' part of Morison's cross-flow damping and suits cross-flow-only VIV. The section needs Cl > 0 and a VIV AMPLITUDE table; EI = 0 lines are refused. The Python deck reader and builder take the section, with parity tests against the native reader. Tests: test_viv_cf_damping_kernel (Morison limits, the cross-flow law, the blend, Jacobians against central differences, refusals) and test_viv_cf_damping_deck (0 0 1 equals the line without the row to 1.5e-8, the in-line-only factor gives the Cd 2.4 static offset, Thorsen's form raises A/D 0.68 to 1.02, power balance within 0.2 %, six refusals). Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An optional
VIV DAMPINGsection gives a finite-EI line type a drag split in the frame of the ambient normal flow: Morison's drag in line, and the cross-flow hydrodynamic damping of Thorsen, Sævik and Larsen (J. Fluids Struct. 61, 2016, Eq. 1) across it.Model
With$\mathbf t$ the tangent, $\mathbf u_n$ the ambient flow normal to it, $\mathbf e_x = \mathbf u_n/|\mathbf u_n|$ and $\mathbf e_y = \mathbf t\times\mathbf e_x$ , the relative normal velocity $\mathbf w$ splits into $w_x$ and $w_y$ :
VIV AMPLITUDEtable and0.31 0.89 0is the published fit (still-water decay tests,0 0 1is Morison's drag with the drag factor on the in-line part only, so an amplified drag no longer damps the cross-flow VIV motion twice.Changes
CableDyn_HydroCD_Morison_Drag_Split_Per_Length_Jac: the split force, exact Jacobians in the relative velocity and the tangentCableDyn_HermiteCableDynamicSet_VIVcdy(2 or 3, n_elem) with checks and rollback; the drag element takescdy/cdy_linin the residual, the tangent and the element drag loadCableDyn_DeckDriverVIV DAMPINGsection (TypeName a b [c]), needs Cl > 0 and aVIV AMPLITUDEtable, refused onEI = 0linesLineType.viv_dampingin the builder and loaderdriver_format.md,theory.rst(cross-flow damping),capabilities.rst, CHANGELOGStatics is unchanged: at rest in the flow the split force is Morison's.
Tests
test_viv_cf_damping_kerneltest_viv_cf_damping_deck0 0 1with factor 1 is the line without the row to 1.5e-8; withCd2.4; Thorsen's form raisestest_deck_file, builder rows, end-to-end reader parity (7 decks)Local gates: full CTest under the default and Prescott BLAS kernels, Debug
-fcheck=allon the VIV, drag, checkpoint and restart tests, pytest, ruff, Sphinx-W, pre-commit.