Repository navigation
fix: bending forces in the round-off floor of the dynamic tolerance - #158
Merged
Merged
Conversation
A finite-EI dynamic step with bending damping (EI|Bb) could fail on a soft line: Newton stagnated just above the tolerance and the step recovery's smaller steps made it worse. Found on a 20 m riser on a 20 kN/m tensioner (EA_eff 4e5 N, 80 elements, Bb 500 N m^2 s, dt 1e-3 s) in VIV: the residual stopped at 1.06 times the tolerance. The bending damping takes the curvature rate from the Newmark velocity, whose rounding is gamma/(beta dt) times that of the coordinates, so its nodal forces round at about Bb gamma/(beta dt) eps |r|/l0^3. The force scale's round-off floor covered the axial forces alone, (EA + BA gamma/(beta dt)) eps |r|/l0. It now takes the bending forces, (EI + Bb gamma/(beta dt)) eps |r|/l0^3, too; that term binds only where it is the larger, so every example and test deck gives bit-identical outputs (1685 arrays over 70 decks). Test: test_hermite_bending_damping_dynamic B6, a soft line (EA 4e5 N) with Bb 1e4 N m^2 s at dt 1e-4 s. On the old floor its first step stagnates at 2.2e-7 against the tolerance 1e-8; now 200 steps converge and the motion stays bounded. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A finite-EI dynamic step with bending damping (
EI|Bb) could fail to converge on a soft line. Newton stagnated just above the tolerance, and the step recovery's smaller steps only made it worse.It was found on a 20 m vertical riser on a 20 kN/m top tensioner in VIV. That line has EA_eff 4e5 N, 80 elements, Bb 500 N·m²·s and dt 1e-3 s, and its residual stopped at 1.06 times the tolerance.
Cause
The Hermite step's convergence norm divides the residual by a force scale. That scale has a round-off floor, so a residual that no Newton step can reduce still counts as converged. The floor covered only the axial forces:
The bending damping takes the curvature rate from the Newmark velocity, whose rounding is$\gamma/(\beta\,\Delta t)$ times that of the coordinates. Its nodal forces therefore round at about
On a soft line, where EA/L0 is small (a tensioner in series, a fine mesh), this term is the larger.
A smaller step raises the damping term further ($\propto 1/\Delta t$ ), which is why the recovery could not help.
Fix
The floor now takes the larger of the axial and the bending term:
The bending term binds only where it is the larger.
doc/theory.rst(Hermite convergence) and the CHANGELOG describe the change.Tests
test_hermite_bending_damping_dynamicB6 (new): soft line, EA 4e5 N, Bb 1e4 N·m²·s, dt 1e-4 s-fchecksubset (bending, VIV, Hermite drag, restart, checkpoint)-W, pre-commit