Repository navigation
feat: wake-oscillator VIV on EI = 0 lines - #162
Merged
Merged
Conversation
The WAKE OSCILLATOR section now acts on EI = 0 lines as on finite-EI cables; a deck with the wake oscillator on an EI = 0 line was refused. At each free node next to a lifting element the van der Pol wake variable q drives the lift 1/4 rho D CL0 q U^2 over the node's tributary length, in the direction of the synchronisation lift. The forcing is the node's smoothed cross-flow acceleration, and the wake frequency that of the ambient flow normal to the line. The step follows the finite-EI cable: q predicted at the step's evaluation point under the step-start forcing, then advanced from the committed state with the acceleration linear over the step (the shared CD_VIV_Wake_Advance). The state (q, dq/dt) is held in the line's VIV phase and first motion statistic, so the rollback, step-recovery, sub-step and checkpoint copies carry it unchanged; the checkpoint layout of an EI = 0 line does not change. CD_Set_Model_VIV takes the per-element (St, eps, A) as an optional wake argument; it refuses in-line VIV and amplitude tables with it, as the finite-EI cable does. Gates (tests/test_viv_wake_deck.f90, test_viv_coupled.f90): - the taut line of the wake gate with EI = 0 locks in at 0.282 Hz and A/D 0.5856, against 0.5850 for the finite-EI cable (0.1 %), and responds uncoupled (A 0) at the wake's 0.298 Hz, A/D 0.0989 against 0.0986; - the drag and damping take out the wake-lift power within 0.3 %; - CL0 0 is the deck without the section, bit for bit; - on the coupled route a checkpoint restart continues bit for bit with the EI = 0 wake state, a rebuild without it does not, and a rewound step repeats; - a line mixing the two models and an EI = 0 type that keeps its Cl are refused by name. The Python deck reader accepts the wake oscillator on EI = 0 lines. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
WAKE OSCILLATORsection (Facchinetti et al. 2004) now acts onEI = 0lines as well as finite-EI cables. Until now a deck with the wake oscillator on anEI = 0line was refused.On the taut line of the wake-oscillator gate, the two cores agree:
EI = 0lineThe wake's own frequency is St U/D = 0.30 Hz.
Model
At each free node next to a lifting element:
CD_VIV_Wake_Advance.State
EI = 0line does not change.CD_Set_Model_VIVtakes the per-elementwakeargument. It refuses in-line VIV and amplitude tables with the wake oscillator, as the finite-EI cable does.Tests
tests/test_viv_wake_deck.f90:CL0 = 0bit-identical to no section) now run on both cores;Cl.tests/test_viv_coupled.f90: the wake case puts the wake oscillator on theEI = 0riser too. The checkpoint restart continues bit for bit, a rebuild without the VIV state does not, and a rewound step repeats.python/tests/test_deck_file.py: the reader accepts the wake oscillator on an EI = 0 line and still refuses a keptCl.Checks
ctestunder both BLAS kernels and a Debug subset;pytestagainst the native build;-W, pre-commit.