Skip to content

fix: a buoyancy module on a finite-EI line can float at the surface - #164

Merged
SMI-Lab-Inha merged 1 commit into
devfrom
feat/attachment-surface-wetting
Nov 15, 2026
Merged

SMI-Lab-Inha merged 1 commit into
devfrom
feat/attachment-surface-wetting

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

Problem

A net-buoyant ATTACHMENTS module on a finite-EI line had no static position at the free surface. Its buoyancy switched off at its node's height: below the surface its weight in water lifted it, and above the surface its weight in air sank it. The static start therefore stopped with

attachment <k> of the line (...) crossed the still-water level ... has no static position

Change

An attachment's buoyancy, Froude–Krylov force and drag now carry the immersed fraction of the sphere of its volume. Without a volume, the sphere of its drag area $C_dA = \pi r^2$ is used. This is the rule a Rigid6 body already uses:

$$ h = \min\bigl(2r,\ \max(0,\ \eta - z + r)\bigr),\qquad \phi = \frac{h^2(3r-h)}{4r^3},\qquad r = \left(\frac{3V}{4\pi}\right)^{1/3} $$

The load is $C^1$ through the surface. A node deeper than $r$ has $\phi = 1$ exactly, so its loads are unchanged to the bit.

Part What changes
Dynamics (attachment_residual) Buoyancy, Froude–Krylov force and drag are scaled by $\phi$. The height derivative $\partial\phi/\partial z$ goes into the position tangent.
Statics (CD_HermiteCable_Static_Solve) New optional att_node, att_buoyancy, att_radius. Each Newton iterate adds the lost buoyancy $\rho g V(1-\phi)$, with its stiffness $-\rho g V,\partial\phi/\partial z$ and potential $\rho g V,(z - \psi - z_w)$, where $\psi = \int \phi,dz$.
Deck attachment polish The wet/dry fixed point and the crossing error are removed.
Torsion stage Keeps its fixed point, now over the smooth loads.
Deck waves (held field) A node above the instantaneous surface takes the wave kinematics at the surface, where they were zero. This matches the internal waves of a cable since #163.

Two limits, both documented: the added mass $C_a\rho V$ stays in the constant mass matrix, and the modal analysis leaves out the hydrostatic stiffness of the surface, for a module as for a line's own.

Tests

  • test_attachment_surface (new):
    • K1, the fraction: $\partial\phi/\partial z$ and $\partial\psi/\partial z = \phi$ match central FD to $10^{-8}$. Both are continuous at the band edges, and $r = 0$ keeps the old switch.
    • K2, the static solve:
      • with the node in the band, the residual gains $\rho g V(1-\phi)$ and the tangent column matches central FD ($8.7\times10^{-9}$);
      • deeper than $r$, the residual and tangent are bit-identical to the solve without the term;
      • above the band, the residual carries the full $\rho g V$ and the tangent gains no stiffness.
  • test_static_dry_weight gate 9: the module of the old failure (200 kg, 2 m³, on a slack cable).
    • It now floats 0.348 m below the surface ($\phi = 0.81$), and the march holds that height over 3 s (drift 0).
    • In 1.5 m, 6 s Airy waves it heaves between −1.21 m and +0.48 m through its band for 18 s, with every step converged.

Checks

  • ctest 424/424 under both BLAS kernels (default and Prescott).
  • Debug subset (attachment, dry weight, Hermite, surface, waves, added mass, VIV): 56/56.
  • Every example and test deck that the dump script can run (70 of them), on this branch against dev: 1685 arrays identical bit for bit, none differ. 44 decks are skipped on both sides; one deck fails to parse in the dump script on both sides.
  • Sphinx -W and pre-commit are clean.

A net-buoyant ATTACHMENTS module on a finite-EI line had no static
position near the free surface. Its buoyancy switched off at its node's
height, so its weight in air took it below the surface and its weight
in water above it. The static start stopped with "attachment <k> ...
crossed the still-water level".

The buoyancy, Froude-Krylov force and drag of an attachment now carry
the immersed fraction of the sphere of its volume (of its drag area
without one), the formula a Rigid6 body already uses:
h = clamp(eta - z + r, 0, 2r), phi = h^2 (3r - h)/(4 r^3). The load is
continuous with its slope through the surface.

- Dynamics: the residual takes phi, with the height derivative in the
  position tangent. A node deeper than r keeps phi = 1 exactly, so its
  loads are unchanged to the bit.
- Statics: CD_HermiteCable_Static_Solve takes optional att_node,
  att_buoyancy and att_radius. It adds the buoyancy lost at the surface,
  rho g V (1 - phi), in each Newton iterate, with its stiffness and
  potential. The polish no longer needs the wet/dry fixed point or the
  crossing error. The torsion stage keeps its fixed point over the
  smooth loads.
- Deck waves: a node above the instantaneous surface takes the wave
  kinematics at the surface instead of zero, as the internal waves of a
  cable already did (#163). Line Gauss points interpolated from such
  nodes therefore change too.

The added mass stays in the constant mass matrix. The modal analysis
leaves out the surface's hydrostatic stiffness, a module's as a line's
own.

Gates:
- test_attachment_surface:
  - K1, the fraction: its slope and potential match central FD (1e-8)
    and are continuous at the band edges; r = 0 keeps the old switch.
  - K2, the static solve: with the node in the band the residual gains
    rho g V (1 - phi) and the tangent column matches central FD
    (8.7e-9). Deeper than r the residual and tangent are bit-identical
    to the solve without the term.
- test_static_dry_weight gate 9, the module of the old failure
  (200 kg, 2 m^3, on a slack cable):
  - it now floats 0.348 m below the surface (phi 0.81);
  - the march holds that height over 3 s (drift 0);
  - in 1.5 m, 6 s Airy waves it heaves between -1.21 and +0.48 m
    through its band for 18 s, every step converged.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T00:16:57.827985Z 5c6391a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35898607 | 📁 Comparing 5c6391a against latest (789cb6d)

  🔍 Preview build  

14 files changed · ± 14 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 5c6391afbf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit ecd12d6 into dev Nov 15, 2026
22 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the feat/attachment-surface-wetting branch November 15, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant