Repository navigation
fix: a buoyancy module on a finite-EI line can float at the surface - #164
Merged
Merged
Conversation
A net-buoyant ATTACHMENTS module on a finite-EI line had no static position near the free surface. Its buoyancy switched off at its node's height, so its weight in air took it below the surface and its weight in water above it. The static start stopped with "attachment <k> ... crossed the still-water level". The buoyancy, Froude-Krylov force and drag of an attachment now carry the immersed fraction of the sphere of its volume (of its drag area without one), the formula a Rigid6 body already uses: h = clamp(eta - z + r, 0, 2r), phi = h^2 (3r - h)/(4 r^3). The load is continuous with its slope through the surface. - Dynamics: the residual takes phi, with the height derivative in the position tangent. A node deeper than r keeps phi = 1 exactly, so its loads are unchanged to the bit. - Statics: CD_HermiteCable_Static_Solve takes optional att_node, att_buoyancy and att_radius. It adds the buoyancy lost at the surface, rho g V (1 - phi), in each Newton iterate, with its stiffness and potential. The polish no longer needs the wet/dry fixed point or the crossing error. The torsion stage keeps its fixed point over the smooth loads. - Deck waves: a node above the instantaneous surface takes the wave kinematics at the surface instead of zero, as the internal waves of a cable already did (#163). Line Gauss points interpolated from such nodes therefore change too. The added mass stays in the constant mass matrix. The modal analysis leaves out the surface's hydrostatic stiffness, a module's as a line's own. Gates: - test_attachment_surface: - K1, the fraction: its slope and potential match central FD (1e-8) and are continuous at the band edges; r = 0 keeps the old switch. - K2, the static solve: with the node in the band the residual gains rho g V (1 - phi) and the tangent column matches central FD (8.7e-9). Deeper than r the residual and tangent are bit-identical to the solve without the term. - test_static_dry_weight gate 9, the module of the old failure (200 kg, 2 m^3, on a slack cable): - it now floats 0.348 m below the surface (phi 0.81); - the march holds that height over 3 s (drift 0); - in 1.5 m, 6 s Airy waves it heaves between -1.21 and +0.48 m through its band for 18 s, every step converged. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A net-buoyant
ATTACHMENTSmodule on a finite-EI line had no static position at the free surface. Its buoyancy switched off at its node's height: below the surface its weight in water lifted it, and above the surface its weight in air sank it. The static start therefore stopped withChange
An attachment's buoyancy, Froude–Krylov force and drag now carry the immersed fraction of the sphere of its volume. Without a volume, the sphere of its drag area$C_dA = \pi r^2$ is used. This is the rule a Rigid6 body already uses:
The load is$C^1$ through the surface. A node deeper than $r$ has $\phi = 1$ exactly, so its loads are unchanged to the bit.
attachment_residual)CD_HermiteCable_Static_Solve)att_node,att_buoyancy,att_radius. Each Newton iterate adds the lost buoyancyTwo limits, both documented: the added mass$C_a\rho V$ stays in the constant mass matrix, and the modal analysis leaves out the hydrostatic stiffness of the surface, for a module as for a line's own.
Tests
test_attachment_surface(new):test_static_dry_weightgate 9: the module of the old failure (200 kg, 2 m³, on a slack cable).Checks
-Wand pre-commit are clean.