Repository navigation
feat: VIV FRAME section, wake frequency relative to the cable's filtered motion - #165
Merged
Merged
Conversation
…red motion
The wake oscillator took its frequency from the ambient flow normal to
the line. A cable moved through still water, by a tow or by its floater,
therefore never shed, and the model could not drive floater-induced VIV.
A new optional section VIV FRAME, rows `TypeName Tf`, sets the flow
frame of a line type's VIV model. With Tf > 0 [s] the free stream is the
ambient flow relative to the node's velocity, low-pass filtered over Tf:
U_a = |(u - vbar)_n|,
vbar_{n+1} = vbar_n + (1 - exp(-dt/Tf)) (v_{n+1} - vbar_n)
This is the exact first-order filter of the converged end velocity held
over the step, started at the node's initial velocity. The slow motion
counts as flow, and the VIV velocity, much faster than Tf, is filtered
out.
In this commit the frame sets the wake oscillator's frequency, and a row
needs a WAKE OSCILLATOR row. The synchronisation model's ambient-frame
quantities (the amplitude estimate, the cross-flow damping split) can
take the same frame later without changing the input. With Tf 0 or no
row, runs are unchanged to the bit.
- Finite-EI cables: wo_s grows from 2 to 5 rows per node when a node has
Tf > 0. The recovery, snapshot and checkpoint copies carry the new
rows, and the mirror packs SIZE(wo_s).
- EI = 0 lines: the filtered velocity takes rows 3-5 of the VIV motion
statistics (CD_VIV_NMS_AMP rows; a wake line has no amplitude table),
so the state get/set, rollback and checkpoint already carry it.
- The core setters take wake(4, ne) = Tf as an optional fourth row.
- Deck reader, Python reader and builder (viv_frame_tf), docs and
CHANGELOG.
Gates:
- test_viv_wake_deck W6: a finite-EI taut cable towed at 0.15 m/s
through still water, with Tf 10 s, locks in at A/D 0.588, 0.283 Hz.
The same cable held in a 0.15 m/s current gives 0.585, 0.282 Hz.
Without Tf the towed cable reaches A/D 0.042.
On the held cable Tf changes A/D by 0.03 % on both cores, and the
cores agree within 0.1 %.
- test_viv_wake_deck W7: VIV FRAME refusals by name (malformed row,
unknown or repeated type, negative Tf, a type without a wake
oscillator).
- test_viv_coupled: with a VIV FRAME the checkpoint blocks grow by the
filtered velocity; the restarted run continues bit for bit, a rebuild
without the VIV state does not, and a rewound step repeats.
- Python reader, builder and native-parity cases for the section.
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The wake oscillator took its frequency$\omega_f = 2\pi,\mathrm{St},U_a/D$ from the ambient flow normal to the line. A cable moved through still water, by a tow or by its floater, therefore had $U_a = 0$ and never shed. The model could not represent floater-driven VIV of a dynamic cable.
Change
A new optional$T_f > 0$ [s] the free stream is the ambient flow relative to the node's velocity, low-pass filtered over $T_f$ :
VIV FRAMEsection sets the flow frame of a line type's VIV model, one rowTypeName Tfper type. WithThis is the exact first-order filter of the converged end velocity held over the step, started at the node's initial velocity. The slow motion counts as flow; the VIV velocity, much faster than$T_f$ , is filtered out. With
Tf0 or no row, runs are unchanged to the bit.In this PR the frame sets the wake oscillator's frequency, so a row needs a
WAKE OSCILLATORrow. The frame is a section of its own, not a wake column, so that the synchronisation model's ambient-frame quantities can take the same frame later without changing the input. Those quantities are the amplitude estimate (VIV AMPLITUDE) and the cross-flow damping split (VIV DAMPING); for a cylinder moved through still water both are currently inactive.wo_sgrows from 2 to 5 rows per node when a node hasSIZE(wo_s).EI = 0lineCD_VIV_NMS_AMProws; a wake line has no amplitude table). The state get/set, rollback and checkpoint already carry them.The core setters take$T_f$ as an optional fourth row. The deck reader, Python reader and builder (
wake(4, ne)=viv_frame_tf), the input format, theory and capability docs, and the CHANGELOG are updated.Results
A taut cable (100 m, D 0.1 m, 50 kN; first mode locks in at 0.28 Hz):
Tf10 sTf10 s (finite-EI)Tf10 s (EI = 0)Tests
test_viv_wake_deckTf, the cable locks in as the held cable in the current: A/D within 5 %, frequency within 0.003 Hz (measured 0.5 %, 0.001 Hz).Tfchanges A/D by less than 2 % on both cores (measured 0.03 %), and the cores agree within 3 % (measured 0.1 %).VIV FRAMErefusals by name: a malformed row, an unknown or repeated type, a negativeTf, and a type without a wake oscillator.test_viv_coupled: with aVIV FRAME(Tf5 s) the checkpoint blocks grow by the filtered velocity. The restarted run continues bit for bit, a rebuild without the VIV state does not, and a rewound step repeats.wake_cl0; the native-parity cases acceptTf8 and 0 and refuse a negative value, three columns, or a synchronisation-model type.Checks
-Wand pre-commit: clean.