Repository navigation
build: the Release build is warning-free again - #176
Merged
Merged
Conversation
gfortran 16.2 (-Wall -Wextra) reported seven warnings on dev, none a
defect. Each site now gives the same result for every input, NaN, signed
zeros and infinities included:
- CD_VIV_Check_Amp_Table compared a row's A/D with amp(1, i - 1, e)
behind IF (i > 1), which -Wdo-subscript cannot see through ("out of
bounds (0 < 1)"). It now compares with the previous row's value, held
from -1 below every valid first row, in the same order of checks, so
every table gets the same message.
- The half-cycle start of the amplitude estimate, .NOT. (p /= 0), is
ABS(p) <= 0 (true for +-0 only, false for NaN, as before).
- The three immersed-fraction Jacobian terms, dwf /= 0, are
.NOT. (ABS(dwf) <= 0) (true for NaN, as before).
- The attachment-weight fixed point, ALL(f_att_now == f_att), is
ALL(f_att_now <= f_att .AND. f_att_now >= f_att), IEEE equality.
- test_model declares its sub-step event counter with the kind of the
counter it copies (INTEGER(int64)).
All 138 example and test-data decks write byte-identical outputs and the
same messages as the dev build; 431/431 tests pass on the default and
the Prescott OpenBLAS kernel.
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gfortran 16.2 with
-Wall -Wextrareported seven warnings ondevin the Release build. None of them is a defect. This PR rewrites each site so that it gives the same result for every input, NaN, signed zeros and infinities included. The build is back to zero warnings, so a new warning stands out again.CD_VIV_Check_Amp_Table(CableDyn_VIV.f90)-Wdo-subscript: "out of bounds (0 < 1)"amp(1, i - 1, e)behindIF (i > 1)prev, the previous row's A/D, starting at −1A/D >= 0check, soamp > -1holds there. The checks run in the same order, so every table gets the same message.CableDyn_VIV.f90)-Wcompare-reals.NOT. (p /= 0)ABS(p) <= 0CableDyn_HermiteCableDynamic.f90)-Wcompare-realsdwf /= 0.NOT. (ABS(dwf) <= 0)CableDyn_DeckDriver.f90)-Wcompare-realsALL(f_att_now == f_att)ALL(f_att_now <= f_att .AND. f_att_now >= f_att)test_model.f90-WconversionINTEGER :: ev0INTEGER(KIND(auto_m%sub_stats%events)) :: ev0INTEGER(int64).Checks
devbuild and on this one.