Skip to content

build: the Release build is warning-free again - #176

Merged
SMI-Lab-Inha merged 1 commit into
devfrom
fix/build-warnings
Nov 17, 2026
Merged

SMI-Lab-Inha merged 1 commit into
devfrom
fix/build-warnings

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

Summary

gfortran 16.2 with -Wall -Wextra reported seven warnings on dev in the Release build. None of them is a defect. This PR rewrites each site so that it gives the same result for every input, NaN, signed zeros and infinities included. The build is back to zero warnings, so a new warning stands out again.

Site Warning Before After Why it is the same
CD_VIV_Check_Amp_Table (CableDyn_VIV.f90) -Wdo-subscript: "out of bounds (0 < 1)" amp(1, i - 1, e) behind IF (i > 1) compares with prev, the previous row's A/D, starting at −1 Row 1 has already passed the A/D >= 0 check, so amp > -1 holds there. The checks run in the same order, so every table gets the same message.
Amplitude-estimate half cycle (CableDyn_VIV.f90) -Wcompare-reals .NOT. (p /= 0) ABS(p) <= 0 True only for ±0, false for NaN, as before.
Immersed-fraction Jacobian, ×3 (CableDyn_HermiteCableDynamic.f90) -Wcompare-reals dwf /= 0 .NOT. (ABS(dwf) <= 0) True for NaN, as before.
Attachment-weight fixed point (CableDyn_DeckDriver.f90) -Wcompare-reals ALL(f_att_now == f_att) ALL(f_att_now <= f_att .AND. f_att_now >= f_att) IEEE equality: ±0 equal, equal infinities equal, NaN unequal.
test_model.f90 -Wconversion INTEGER :: ev0 INTEGER(KIND(auto_m%sub_stats%events)) :: ev0 The counter it copies is INTEGER(int64).

Checks

  • Release build: 0 warnings.
  • ctest: 431/431 on the default and on the Prescott OpenBLAS kernel.
  • Example A/B: all 138 example and test-data decks write byte-identical outputs on the dev build and on this one.
    • The 19 decks that stop with an error stop with the same exit code and the same console text.
    • The only console differences are the progress-line timers.

gfortran 16.2 (-Wall -Wextra) reported seven warnings on dev, none a
defect. Each site now gives the same result for every input, NaN, signed
zeros and infinities included:

- CD_VIV_Check_Amp_Table compared a row's A/D with amp(1, i - 1, e)
  behind IF (i > 1), which -Wdo-subscript cannot see through ("out of
  bounds (0 < 1)"). It now compares with the previous row's value, held
  from -1 below every valid first row, in the same order of checks, so
  every table gets the same message.
- The half-cycle start of the amplitude estimate, .NOT. (p /= 0), is
  ABS(p) <= 0 (true for +-0 only, false for NaN, as before).
- The three immersed-fraction Jacobian terms, dwf /= 0, are
  .NOT. (ABS(dwf) <= 0) (true for NaN, as before).
- The attachment-weight fixed point, ALL(f_att_now == f_att), is
  ALL(f_att_now <= f_att .AND. f_att_now >= f_att), IEEE equality.
- test_model declares its sub-step event counter with the kind of the
  counter it copies (INTEGER(int64)).

All 138 example and test-data decks write byte-identical outputs and the
same messages as the dev build; 431/431 tests pass on the default and
the Prescott OpenBLAS kernel.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T02:38:06.364356Z b0400fa Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: b0400fab59

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35945719 | 📁 Comparing b0400fa against latest (789cb6d)

  🔍 Preview build  

15 files changed · ± 15 modified

± Modified

@SMI-Lab-Inha
SMI-Lab-Inha merged commit dfbbf33 into dev Nov 17, 2026
16 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/build-warnings branch November 17, 2026 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant