Repository navigation
fix: the side a symmetric static leaves its plane to follows the line, not its heading - #177
Merged
Merged
Conversation
…, not its heading Past the pitchfork of a current along the vertical plane of a finite-EI line (the grounded run turned sideways on the seabed), the static solve adds a cross-flow of 1 % of the horizontal current to leave the plane, then polishes at the exact current. The cross-flow was the left normal of the line's local frame, and that frame is the identity for any chord without a y component. A chord from the anchor along -x therefore took the cross-flow at +y (to its right), a chord a round-off away from -x at -y (to its left), and a deck rotated by 180 degrees about the vertical left its plane to the same global side as the original. The cross-flow now points to the left of the horizontal chord from the anchor (End B) to the fairlead (End A) whatever its heading, +y for a vertical chord as before, so the rotated deck reaches the rotated equilibrium. Of the 138 example and test-data decks one changes, tests/data/fei_hairpin_current.dat (chord along -x): it reaches the mirror image of its previous equilibrium, x, z, tension and curvature identical to the bit, y negated, the same end forces with Fy reversed. The statics matrix gains a side check (the node farthest from y = 0 on the recorded side) and mirror twins (the mirror image of the parent to 1e-6): CUR_1013 and its 180-degree rotation leave to opposite sides (the rotation failed before), and a cross current of 2 % of the deck's own, toward +y or -y, picks the side, the two mirror images of each other. The theory page states the rule and that a deck can pick the side with a small cross component of its own current. 431/431 tests pass on the default and the Prescott OpenBLAS kernel. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In a current along the vertical plane of a finite-EI line, the planar static branch can end in a pitchfork: the grounded run turns sideways on the seabed. The static solve then leaves the plane by adding a cross-flow of 1 % of the horizontal current, and polishes at the exact current. Both sides are equilibria of the symmetric problem.
The cross-flow was the left normal of the line's local frame. That frame is the identity for any chord without a y component, so the side followed the line's heading rather than the line:
So before this PR, a deck rotated by 180° about the vertical left its plane to the same global side as the original. Now the cross-flow always points to the left of the horizontal chord from the anchor to the fairlead, so the rotated deck reaches the rotated equilibrium.
Effect
Of the 138 example and test-data decks, one changes:
tests/data/fei_hairpin_current.dat, whose chord points along −x. It reaches the mirror image of its previous equilibrium:Every other deck writes byte-identical output.
Tests
The statics matrix (
tests/test_cable_statics_matrix.py) gains two checks.side: the node farthest from y = 0 lies on the recorded side, by more than 1e-3 of the line length.mirror_of: the deck reaches the mirror image in y of its parent: end forces within 1e-6, and nodes within 1e-6 of the line length.New cases built from
CUR_1013:CUR_1013CUR_1013__rot180twin_ofthe parent (same end forces) and side −y; fails before this PR (+y)CUR_1013__xpCUR_1013__xmmirror_ofCUR_1013__xpThe theory page now states the rule, and that a deck can pick the side with a small cross component of its own current.
Checks