Skip to content

fix: the side a symmetric static leaves its plane to follows the line, not its heading - #177

Merged
SMI-Lab-Inha merged 1 commit into
devfrom
fix/pitchfork-side
Nov 17, 2026
Merged

SMI-Lab-Inha merged 1 commit into
devfrom
fix/pitchfork-side

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

Summary

In a current along the vertical plane of a finite-EI line, the planar static branch can end in a pitchfork: the grounded run turns sideways on the seabed. The static solve then leaves the plane by adding a cross-flow of 1 % of the horizontal current, and polishes at the exact current. Both sides are equilibria of the symmetric problem.

The cross-flow was the left normal of the line's local frame. That frame is the identity for any chord without a y component, so the side followed the line's heading rather than the line:

Chord from the anchor (End B) to the fairlead (End A) Cross-flow before Cross-flow now
along −x, exactly +y (to its right) −y (to its left)
a round-off away from −x −y (to its left) −y (to its left)
along +x +y (to its left) +y (to its left)
vertical +y +y

So before this PR, a deck rotated by 180° about the vertical left its plane to the same global side as the original. Now the cross-flow always points to the left of the horizontal chord from the anchor to the fairlead, so the rotated deck reaches the rotated equilibrium.

Effect

Of the 138 example and test-data decks, one changes: tests/data/fei_hairpin_current.dat, whose chord points along −x. It reaches the mirror image of its previous equilibrium:

  • x, z, tension and curvature are bit-identical;
  • y is negated;
  • the end force is the same with Fy reversed, and the tangent azimuth changes sign.

Every other deck writes byte-identical output.

Tests

The statics matrix (tests/test_cable_statics_matrix.py) gains two checks.

  • side: the node farthest from y = 0 lies on the recorded side, by more than 1e-3 of the line length.
  • mirror_of: the deck reaches the mirror image in y of its parent: end forces within 1e-6, and nodes within 1e-6 of the line length.

New cases built from CUR_1013:

Case Current Check
CUR_1013 1.906 m/s along +x side +y
CUR_1013__rot180 the deck rotated by 180° about z twin_of the parent (same end forces) and side −y; fails before this PR (+y)
CUR_1013__xp plus a 2 % cross current toward +y side −y (the folded grounded run)
CUR_1013__xm plus a 2 % cross current toward −y side +y, mirror_of CUR_1013__xp

The theory page now states the rule, and that a deck can pick the side with a small cross component of its own current.

Checks

  • ctest: 431/431 on the default and on the Prescott OpenBLAS kernel.
  • Example A/B: 137 of 138 decks are byte-identical; the one that changes is the mirror case above.

…, not its heading

Past the pitchfork of a current along the vertical plane of a finite-EI
line (the grounded run turned sideways on the seabed), the static solve
adds a cross-flow of 1 % of the horizontal current to leave the plane,
then polishes at the exact current. The cross-flow was the left normal of
the line's local frame, and that frame is the identity for any chord
without a y component. A chord from the anchor along -x therefore took
the cross-flow at +y (to its right), a chord a round-off away from -x at
-y (to its left), and a deck rotated by 180 degrees about the vertical
left its plane to the same global side as the original.

The cross-flow now points to the left of the horizontal chord from the
anchor (End B) to the fairlead (End A) whatever its heading, +y for a
vertical chord as before, so the rotated deck reaches the rotated
equilibrium. Of the 138 example and test-data decks one changes,
tests/data/fei_hairpin_current.dat (chord along -x): it reaches the
mirror image of its previous equilibrium, x, z, tension and curvature
identical to the bit, y negated, the same end forces with Fy reversed.

The statics matrix gains a side check (the node farthest from y = 0 on
the recorded side) and mirror twins (the mirror image of the parent to
1e-6): CUR_1013 and its 180-degree rotation leave to opposite sides (the
rotation failed before), and a cross current of 2 % of the deck's own,
toward +y or -y, picks the side, the two mirror images of each other.
The theory page states the rule and that a deck can pick the side with a
small cross component of its own current.

431/431 tests pass on the default and the Prescott OpenBLAS kernel.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T05:19:46.007213Z 5461c22 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35947761 | 📁 Comparing 5461c22 against latest (789cb6d)

  🔍 Preview build  

15 files changed · ± 15 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 5461c222e2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit a244dfc into dev Nov 17, 2026
16 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/pitchfork-side branch November 17, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant