Repository navigation
ci: pull requests run the Debug tier without the slow-labelled tests - #181
Merged
Merged
Conversation
The two Debug (-O0) jobs held every pull request for about 2 h 10 min against 30-50 min for the rest of CI. Their purpose is the -O0 fault class (an absent OPTIONAL reached through a non-short-circuited .AND./.OR.), which lives in code the fast tests already reach; most of their time went to the 18 tests labelled slow (the long lazy-wave, mooring and statics campaigns, about 6500 of 21900 CPU-s on the Windows Debug job). A pull request now runs the Debug tier with -LE slow (an estimated 64 min at four tests at once, in step with the Release jobs). The slow tests still run on every pull request in Release on both platforms and on the Prescott kernel, and every push to dev and main runs the full suite at -O0, so each merge stays hardened without holding the PR. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
SMI-Lab-Inha
added a commit
that referenced
this pull request
Nov 17, 2026
#183) #181 took the slow-labelled tests out of the pull-request Debug tier, but its own run still held the Debug jobs for about 1 h 45 min: the remaining 414 tests cost 18,700 CPU-s at -O0 on the Windows runner, and 27 of them (the VIV deck gates, the coupled and threaded C API runs, the azimuth and graded-mesh statics, among others) take 200-1030 CPU-s each, about two thirds of the total. CMakeLists.txt gives those 27 tests the label debug_long (only where the test exists in the build), and a pull request's Debug tier runs ctest -LE 'slow|debug_long': 387 of 432 tests, about 25 minutes of tests at four at once. The skipped tests still run on every pull request in Release on both platforms and on the Prescott kernel, and the full suite runs at -O0 on every push to dev and main. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The two Debug (-O0) Fortran jobs held every pull request for about 2 h 10 min. The rest of CI finishes in 30–50 min. On the Windows Debug job, about 6 500 of 21 900 CPU-s went to the 18 tests labelled
slow: the long lazy-wave, mooring and statics campaigns.The Debug tier exists for one fault class: an absent
OPTIONALreached through a.AND./.OR.that -O0 does not short-circuit. That code is already reached by the fast tests.Change
ctest -LE slow(about 64 min estimated)dev/maindev.