Skip to content

ci: pull requests run the Debug tier without the slow-labelled tests - #181

Merged
SMI-Lab-Inha merged 1 commit into
devfrom
ci/faster-debug-tier
Nov 17, 2026
Merged

SMI-Lab-Inha merged 1 commit into
devfrom
ci/faster-debug-tier

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

Why

The two Debug (-O0) Fortran jobs held every pull request for about 2 h 10 min. The rest of CI finishes in 30–50 min. On the Windows Debug job, about 6 500 of 21 900 CPU-s went to the 18 tests labelled slow: the long lazy-wave, mooring and statics campaigns.

The Debug tier exists for one fault class: an absent OPTIONAL reached through a .AND./.OR. that -O0 does not short-circuit. That code is already reached by the fast tests.

Change

Event Debug jobs Release, Windows, Prescott jobs
pull request ctest -LE slow (about 64 min estimated) full suite, unchanged
push to dev / main full suite, unchanged full suite, unchanged
  • The slow tests still run on every pull request, in Release and on the Prescott kernel.
  • Every merge still gets the full -O0 run on its push to dev.
  • Job names are unchanged, so the required checks still match.

The two Debug (-O0) jobs held every pull request for about 2 h 10 min
against 30-50 min for the rest of CI. Their purpose is the -O0 fault
class (an absent OPTIONAL reached through a non-short-circuited
.AND./.OR.), which lives in code the fast tests already reach; most of
their time went to the 18 tests labelled slow (the long lazy-wave,
mooring and statics campaigns, about 6500 of 21900 CPU-s on the Windows
Debug job).

A pull request now runs the Debug tier with -LE slow (an estimated
64 min at four tests at once, in step with the Release jobs). The slow
tests still run on every pull request in Release on both platforms and
on the Prescott kernel, and every push to dev and main runs the full
suite at -O0, so each merge stays hardened without holding the PR.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T12:55:51.276307Z 997b2f4 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 997b2f4b1a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35956325 | 📁 Comparing 997b2f4 against latest (789cb6d)

  🔍 Preview build  

15 files changed · ± 15 modified

± Modified

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 9ab09f7 into dev Nov 17, 2026
6 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the ci/faster-debug-tier branch November 17, 2026 14:51
SMI-Lab-Inha added a commit that referenced this pull request Nov 17, 2026
#183)

#181 took the slow-labelled tests out of the pull-request Debug tier,
but its own run still held the Debug jobs for about 1 h 45 min: the
remaining 414 tests cost 18,700 CPU-s at -O0 on the Windows runner, and
27 of them (the VIV deck gates, the coupled and threaded C API runs,
the azimuth and graded-mesh statics, among others) take 200-1030 CPU-s
each, about two thirds of the total.

CMakeLists.txt gives those 27 tests the label debug_long (only where the
test exists in the build), and a pull request's Debug tier runs
ctest -LE 'slow|debug_long': 387 of 432 tests, about 25 minutes of tests
at four at once. The skipped tests still run on every pull request in
Release on both platforms and on the Prescott kernel, and the full suite
runs at -O0 on every push to dev and main.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant