Repository navigation
ci: pull-request Debug tier also skips the tests over 200 CPU-s at -O0 - #183
Merged
Merged
Conversation
#181 took the slow-labelled tests out of the pull-request Debug tier, but its own run still held the Debug jobs for about 1 h 45 min: the remaining 414 tests cost 18,700 CPU-s at -O0 on the Windows runner, and 27 of them (the VIV deck gates, the coupled and threaded C API runs, the azimuth and graded-mesh statics, among others) take 200-1030 CPU-s each, about two thirds of the total. CMakeLists.txt gives those 27 tests the label debug_long (only where the test exists in the build), and a pull request's Debug tier runs ctest -LE 'slow|debug_long': 387 of 432 tests, about 25 minutes of tests at four at once. The skipped tests still run on every pull request in Release on both platforms and on the Prescott kernel, and the full suite runs at -O0 on every push to dev and main. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#181 removed the
slowtests from the pull-request Debug tier. Even so, its own run kept the Debug jobs busy for about 1 h 45 min. On the Windows runner at -O0:Change
CMakeLists.txt: the 27 tests get the labeldebug_long. The label is applied only where the test exists in the build, usingif(TEST …).ctest -LE 'slow|debug_long', which is 387 of 432 tests, about 25 min of tests at four at once.What still runs
dev/mainChecks
Configured locally:
ctest -N -L debug_longlists 27 tests;-LE 'slow|debug_long'lists 387;