Repository navigation
fix: accept seabed recompute inputs equal to rounding - #31
Merged
Merged
Conversation
The deck driver stores the seabed recompute inputs of every finite-EI cable with seabed contact (kBot, the contact diameters and cBot/kBot), so that active line control can rebuild the nodal contact coefficients after a length change, and CD_HermiteCable_Dyn_Set_Control_Seabed checked that the inputs reproduce the installed coefficients bit for bit. The deck computes the damping as kn*(cBot/kBot) and the check computes the same product, but the optimised Intel build of the release evaluates the two with different rounding: the release driver stopped examples/buoy_clamped_cable.dat with "the inputs do not reproduce the installed nodal contact damping". The gfortran builds of the test suite round both the same way and did not show it. The check now accepts coefficients within 8 units in the last place, which still rejects inputs that do not belong to the installed coefficients. Built with the release flags (Intel Fortran 2025.3.2, /Qipo, reference LAPACK), the driver of dev stops on that deck and the fixed driver runs it and every other shipped example (51 decks). Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The clean-machine check of the 0.2.0 release assets found that the Intel-built release driver stops
examples/buoy_clamped_cable.dat:kBot, the contact diameters andcBot/kBot. Active line control (feat(control): active tension of finite-EI cables; committed lengths under the force blend #26) uses them to rebuild the nodal contact coefficients after a length change.CD_HermiteCable_Dyn_Set_Control_Seabedchecked that these inputs reproduce the installed coefficients bit for bit.kn*(cBot/kBot), and the check computes the same product. The optimised Intel release build (IFX 2025.3.2,/Qipo) rounds the two differently. The gfortran builds of CI round them the same way, so no test showed it.This blocks the 0.2.0 release: the published executable would refuse every deck whose values round this way.
Tests
test_hermite_cable_control:NEAREST) off is accepted;/Qipo, static runtime, reference LAPACK 3.12.1):devstops onbuoy_clamped_cable.datwith the message above;pre-commit run --all-filesand the Sphinx build with-Wpass.Checklist
pre-commit run --all-filespassesctest --test-dir build --output-on-failurepassespython -m pytest tests python/testspasses (if Python or validation records changed)doc/updated for changed inputs, options, or outputs (docstring only)feat:,fix:,docs:, ...)git commit -s) under theDeveloper Certificate of Origin