Repository navigation
perf(profile): split the cable assembly, CalcOutput and wave sampling - #35
Merged
Merged
Conversation
The first coupled profile showed that, on a mooring with a finite-EI power cable, CalcOutput and the SeaState sampling cost as much as the mooring step itself, and that the cable step is dominated by its residual and tangent assemblies. Choosing what to optimise first needs the inside of each. The residual and tangent assembly of a finite-EI cable now times its sections (band zeroing, tangent element kernels, tangent scatter, structural residual, weight, attachments, dry buoyancy, seabed contact, axial damping, drag, end connections, wave and held Froude-Krylov loads, torsion). The OpenFAST module splits CalcOutput into the overlay of the current kinematics, the output channels and the restore of the committed state, and the SeaState sampling into the node queries, the grid checks and the hand-over of the fields. The standalone driver and the OpenFAST module report them. Unprofiled, each new timer is skipped after one test; outputs are byte-identical with and without the profile. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second profiling step before any optimisation (follows #34). The first coupled profile showed that, on a mooring with a finite-EI power cable,
CalcOutputand the SeaState sampling cost as much as the mooring step, and that the cable step is dominated by its assemblies. This PR times the inside of each.assemble_residualtimes its sections:CalcOutput. Split into:nsuper = 1);Finite-EI cable assembly timeline.CableDyn profile partsandCableDyn Hermite assemblylines.cli.rst(example regenerated from a real run),faq.rstand the CHANGELOG describe them.Measurement
IEA-15 VolturnUS-S, DLC-1.6 environment (turbulent wind 10.6 m/s, JONSWAP sea), 600 s at
dtM = DT = 0.025 s,OMP_NUM_THREADS=1, gfortran build of this branch.CalcOutputCable assembly outside the step. The cable's residual and tangent assemblies in the step take 25.0 s, but the sections add up to 43.4 s. About 18 s of cable assembly therefore happens outside the step. The overlay and the loads, which cost little on the chain-only mooring, are the likely places. That makes the cable's work in
CalcOutputthe first candidate for optimisation, ahead of reusing factorisations.Tests
driver_profile_finite_ei: requires the new assembly line. As before, every output file must be byte-identical with and without the profile.dynamic_chain_current,lozon_gomex80_power_cable_motionandbuoy_clamped_cablerun in the same time (ratios 0.95–1.01 over two rounds, minimum of five alternating runs) and write byte-identical.outfiles.pre-commit run --all-filesand the Sphinx build with-Wpass. OpenFAST builds; the changed sources build without new warnings.Checklist
pre-commit run --all-filespassesctest --test-dir build --output-on-failurepassespython -m pytest tests python/testspasses (if Python or validation records changed)[Unreleased](heading added if missing) for user-visible changesdoc/updated for changed inputs, options, or outputsfeat:,fix:,docs:, ...)git commit -s) under theDeveloper Certificate of Origin