Repository navigation
perf(openfast): skip the discarded cable reactions in CalcOutput - #36
Merged
Merged
Conversation
At the glue rate (nsuper = 1) CalcOutput saves the committed coupled kinematics, transfers the current ones, evaluates the loads and channels and restores the committed state. The save read the kinematics with CD_AGG_GetMovingPointMesh, which also evaluated the reaction of every finite-EI cable (a full residual and added-mass assembly) only for the caller to overwrite it with the loads evaluated after the transfer. The profile put this at 17 of the 41 s of CalcOutput in a 600 s run of the IEA-15 VolturnUS-S with a 248-element power cable. CD_AGG_GetMovingPointMesh takes an optional cable_loads = .FALSE. that skips the cable reactions and returns their load columns as zero; the save uses it. The reactions write only the cable's scratch, which the loads evaluation that follows overwrites, so the outputs are unchanged: the coupled chain-only and mixed runs write byte-identical OpenFAST and CableDyn outputs, and the mixed run takes 212 s instead of 227 s. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
6 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First optimisation from the profiles of #34 and #35. At the glue rate (
nsuper = 1),CalcOutputdoes four things:Step 1 read the kinematics with
CD_AGG_GetMovingPointMesh. That call also evaluated the reaction of every finite-EI cable, which is a full residual and added-mass assembly of the line. The caller then overwrote the result with the loads from step 3.CD_AGG_GetMovingPointMeshtakes an optionalcable_loads = .FALSE.. It skips the cable reactions and returns their load columns as zero.CalcOutputsave uses it.nsuper = 1every call then evaluates the loads, which overwrite that scratch, before anything reads it.Measurement
IEA-15 VolturnUS-S, DLC-1.6 environment, 600 s at
dtM = DT = 0.025 s,OMP_NUM_THREADS=1,CABLEDYN_PROFILE=1.CalcOutput.outand CableDyn.CD.outTests
test_openfast_aggregate, no-advance transfer case: a kinematics-only read must:pre-commit run --all-filesand the Sphinx build with-Wpass. OpenFAST builds.Checklist
pre-commit run --all-filespassesctest --test-dir build --output-on-failurepassespython -m pytest tests python/testspasses (if Python or validation records changed)[Unreleased](heading added if missing) for user-visible changesdoc/updated for changed inputs, options, or outputs (no input, option or output changed)feat:,fix:,docs:, ...)git commit -s) under theDeveloper Certificate of Origin