Repository navigation
feat(init): note a dtM that does not resolve a line's axial period - #38
Merged
Merged
Conversation
A coarser mooring step is the main way to make coupled runs cheaper, but nothing told a user when dtM was too coarse for a line. With the IEA-15 MW mixed example in a turbulent 600 s OpenFAST run, the power cable (axial period 0.351 s) matches the dtM = DT fairlead tension within 0.3 % of its standard deviation at dtM = 0.05 s (7 steps per period), but at 0.1 s (3.5 steps) its axial dynamics are damped and its peak tension is 35 % high; the chains (0.78 s) keep their tension statistics within 0.3 % at 0.1 s. At initialisation each line's axial period is estimated as that of a bar fixed at both ends, twice the sum over its sections of the length over sqrt(EA/m) (unstretched lengths, dry mass, the dynamic EA of a constant-stiffness viscoelastic type). A line that dtM resolves in fewer than six steps gets an initialisation note with the period, the number of steps and a dtM that resolves it, on the standalone, mixed and OpenFAST routes. Load-dependent types (ElasticMod 3, Syrope) are not assessed. Nothing else changes. The FAQ and the OpenFAST tutorial still gave 0.1 s as the OpenFAST default dtM; since 0.2.0 it is the glue DT. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
1 similar comment
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This was referenced Oct 21, 2026
SMI-Lab-Inha
added a commit
that referenced
this pull request
Oct 22, 2026
The coupled time-step work (#38 to #40) lets CableDyn solve on a dtM larger than the OpenFAST DT. This records the verification of that change on the IEA-15 MW VolturnUS-S chain mooring in a DLC-1.6 environment (NTM 10.6 m/s turbulent wind, JONSWAP Hs 8 m / Tp 12 s, 3800 s), at dtM = 4 DT = 0.1 s against the same model at dtM = DT and against stock MoorDyn. With the coupled loads extrapolated between CableDyn solves, every platform DOF's time series differs from the dtM = DT run by at most 0.14 % of its standard deviation (0.41 % held), the tension statistics stay within 0.16 %, and the rainflow damage-equivalent loads change by at most 0.21 % at the fairleads and 1.5 % at the anchors, of the order of the reference's own sampling effect (0.94 %). Against stock MoorDyn the in-plane platform standard deviations agree within 0.03 %. validation/scripts/openfast_supercycle_ab.py computes these figures from the twin runs; its rainflow count (ASTM E1049, four-point method, half-cycle residue, a plateau of equal samples counted once) is tested against the standard's worked example. Every statistic of a run, its DEL change included, is taken over the samples it shares with the reference, and a run covering fewer of them is flagged. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First step of the coupled time-step work: tell the user when
dtMis too coarse for a line, before making larger steps attractive with a load predictor (next PR).Estimate. At initialisation each line's axial period is estimated as that of a bar fixed at both ends:
T_ax = 2 Σ l_j / sqrt(EA_j / m_j)
The sum runs over the line's sections, using unstretched lengths, dry mass per length, and the dynamic
EAof anElasticMod 2type.The note. A line that
dtMresolves in fewer than six steps gets an initialisation note with:dtMthat resolves it.The note appears on all routes: the standalone report, and the line notes of the aggregate (mixed and OpenFAST).
Not assessed: load-dependent types (
ElasticMod 3, Syrope).Nothing else changes.
Example (OpenFAST console, mixed example with
dtM = 0.1):Basis for the threshold
IEA-15 VolturnUS-S with the mixed mooring (3 chains + 248-element power cable), DLC-1.6 environment, 600 s. The table compares each run with
dtM = DT = 0.025 sover t ≥ 100 s, with zero-order-held loads:dtM = 0.05 sdtM = 0.1 sdoc/modeling.rst:Documentation fixes
doc/faq.rstanddoc/tutorial_openfast.rststill gave 0.1 s as the OpenFAST defaultdtM; since 0.2.0 it is the glueDT. The tutorial's supercycling exercise now setsdtM = 0.1explicitly.Tests
dtm_advisor. Initialises the aggregate from the mixed example:driver_advisories. The standalone report:dtM = 0.1 s(0.396 s period, 4.0 steps, remedy 0.0660 s);pre-commit run --all-filesand the Sphinx build with-Wpass.Checklist
pre-commit run --all-filespassesctest --test-dir build --output-on-failurepassespython -m pytest tests python/testspasses (if Python or validation records changed)[Unreleased](heading added if missing) for user-visible changesdoc/updated for changed inputs, options, or outputsfeat:,fix:,docs:, ...)git commit -s) under theDeveloper Certificate of Origin