Skip to content

feat(init): note a dtM that does not resolve a line's axial period - #38

Merged
SMI-Lab-Inha merged 2 commits into
devfrom
feat/dtm-advisor
Oct 21, 2026
Merged

SMI-Lab-Inha merged 2 commits into
devfrom
feat/dtm-advisor

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

Summary

First step of the coupled time-step work: tell the user when dtM is too coarse for a line, before making larger steps attractive with a load predictor (next PR).

  • Estimate. At initialisation each line's axial period is estimated as that of a bar fixed at both ends:

    T_ax = 2 Σ l_j / sqrt(EA_j / m_j)

    The sum runs over the line's sections, using unstretched lengths, dry mass per length, and the dynamic EA of an ElasticMod 2 type.

  • The note. A line that dtM resolves in fewer than six steps gets an initialisation note with:

    • the period;
    • the number of steps;
    • a dtM that resolves it.

    The note appears on all routes: the standalone report, and the line notes of the aggregate (mixed and OpenFAST).

  • Not assessed: load-dependent types (ElasticMod 3, Syrope).

  • Nothing else changes.

Example (OpenFAST console, mixed example with dtM = 0.1):

CableDyn time step dtM = 0.1 s (4 x glue DT; deck dtM)
...
Note: LINE 4: dtM = 0.1000 s resolves its axial period of 0.351 s (twice its length over
sqrt(EA/m)) in 3.5 steps, fewer than 6: its axial dynamics are damped and its tension peaks
can be wrong. A dtM of at most 0.0585 s resolves them.

Basis for the threshold

IEA-15 VolturnUS-S with the mixed mooring (3 chains + 248-element power cable), DLC-1.6 environment, 600 s. The table compares each run with dtM = DT = 0.025 s over t ≥ 100 s, with zero-order-held loads:

steps per axial period cable tension, RMS diff / std cable peak tension chain tension std
dtM = 0.05 s cable 7.0, chains 15.6 0.3 % 14.99 kN (ref 15.00) within 0.1 %
dtM = 0.1 s cable 3.5, chains 7.8 47 % 20.6 kN (+37 %) within 0.3 %
  • Advisor outcome: at 0.1 s the advisor notes only the cable. At 0.05 s it notes nothing.
  • Limits, also in doc/modeling.rst:
    • the estimate leaves out added mass and the catenary compliance;
    • it is a lower bound, not a convergence study;
    • segment-scale snap waves need far smaller steps.

Documentation fixes

doc/faq.rst and doc/tutorial_openfast.rst still gave 0.1 s as the OpenFAST default dtM; since 0.2.0 it is the glue DT. The tutorial's supercycling exercise now sets dtM = 0.1 explicitly.

Tests

  • New dtm_advisor. Initialises the aggregate from the mixed example:
    • at 0.1 s, the cable's note gives the period, the steps and the remedy, and no chain is noted;
    • at 0.05 s, nothing is noted.
  • driver_advisories. The standalone report:
    • notes a 410 m chain at dtM = 0.1 s (0.396 s period, 4.0 steps, remedy 0.0660 s);
    • does not note it at 0.05 s.
  • OpenFAST: builds, and the console prints the note at initialisation.
  • Full suite (Windows, gfortran, Release, slow tier included): 295/295. Python: 2038 passed. pre-commit run --all-files and the Sphinx build with -W pass.

Checklist

  • pre-commit run --all-files passes
  • ctest --test-dir build --output-on-failure passes
  • python -m pytest tests python/tests passes (if Python or validation records changed)
  • VALIDATION.md updated if a validation result changed (none changed)
  • CHANGELOG.md updated under [Unreleased] (heading added if missing) for user-visible changes
  • Documentation in doc/ updated for changed inputs, options, or outputs
  • Conventional Commit title (feat:, fix:, docs:, ...)
  • Commits are signed off (git commit -s) under the
    Developer Certificate of Origin

A coarser mooring step is the main way to make coupled runs cheaper,
but nothing told a user when dtM was too coarse for a line. With the
IEA-15 MW mixed example in a turbulent 600 s OpenFAST run, the power
cable (axial period 0.351 s) matches the dtM = DT fairlead tension
within 0.3 % of its standard deviation at dtM = 0.05 s (7 steps per
period), but at 0.1 s (3.5 steps) its axial dynamics are damped and
its peak tension is 35 % high; the chains (0.78 s) keep their tension
statistics within 0.3 % at 0.1 s.

At initialisation each line's axial period is estimated as that of a
bar fixed at both ends, twice the sum over its sections of the length
over sqrt(EA/m) (unstretched lengths, dry mass, the dynamic EA of a
constant-stiffness viscoelastic type). A line that dtM resolves in
fewer than six steps gets an initialisation note with the period, the
number of steps and a dtM that resolves it, on the standalone, mixed
and OpenFAST routes. Load-dependent types (ElasticMod 3, Syrope) are
not assessed. Nothing else changes.

The FAQ and the OpenFAST tutorial still gave 0.1 s as the OpenFAST
default dtM; since 0.2.0 it is the glue DT.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T08:24:50.418690Z 874364c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

read-the-docs-community Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35290817 | 📁 Comparing 874364c against latest (d3ddfeb)

  🔍 Preview build  

5 files changed · ± 5 modified

± Modified

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

1 similar comment
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 874364ce48

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 99fbaa8 into dev Oct 21, 2026
15 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the feat/dtm-advisor branch October 21, 2026 08:54
SMI-Lab-Inha added a commit that referenced this pull request Oct 22, 2026
The coupled time-step work (#38 to #40) lets CableDyn solve on a dtM
larger than the OpenFAST DT. This records the verification of that
change on the IEA-15 MW VolturnUS-S chain mooring in a DLC-1.6
environment (NTM 10.6 m/s turbulent wind, JONSWAP Hs 8 m / Tp 12 s,
3800 s), at dtM = 4 DT = 0.1 s against the same model at dtM = DT and
against stock MoorDyn.

With the coupled loads extrapolated between CableDyn solves, every
platform DOF's time series differs from the dtM = DT run by at most
0.14 % of its standard deviation (0.41 % held), the tension statistics
stay within 0.16 %, and the rainflow damage-equivalent loads change by
at most 0.21 % at the fairleads and 1.5 % at the anchors, of the order
of the reference's own sampling effect (0.94 %). Against stock MoorDyn
the in-plane platform standard deviations agree within 0.03 %.

validation/scripts/openfast_supercycle_ab.py computes these figures
from the twin runs; its rainflow count (ASTM E1049, four-point method,
half-cycle residue, a plateau of equal samples counted once) is tested
against the standard's worked example. Every statistic of a run, its DEL
change included, is taken over the samples it shares with the
reference, and a run covering fewer of them is flagged.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant