Skip to content

fix(outputs): keep the down-slope pull in a grounded finite-EI end force - #52

Merged
SMI-Lab-Inha merged 1 commit into
devfrom
fix/campaign-triage
Oct 26, 2026
Merged

SMI-Lab-Inha merged 1 commit into
devfrom
fix/campaign-triage

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

Problem

A finite-EI line end resting on the seabed passed the downward part of its end force to the floor
(force(3) = MAX(force(3), 0) in CD_HermiteCable_Dyn_End_Force). The rule predates bathymetry. On
a flat floor that downward part is the end node's weight. On a slope it also includes the line's
own pull. A cable laid down a 10° slope from its anchor reported:

  • AnchTen 1.5 % low (cos 10° of the line tension);
  • AnchFz = Point<P>Fz = 0 instead of −1.5 kN.

The statics robustness campaign found it: a sloped-seabed lazy wave whose vertical force balance
was off by 6 %.

Change

  • Normal part: the floor takes only the part of the end force that presses into it along its
    upward normal. On a flat floor this is the old rule, so the anchor keeps the line's along-floor
    pull.
  • Friction: on a frictional seabed the floor also holds the along-floor part of the end node's
    own weight, up to μ times that normal load (the smaller of the axial and lateral coefficients).
    The line's pull stays with the anchor.
  • Scope: only the reported end force changes (AnchTen, AnchFz/AnchFH, Point<P>F*, the
    end row of the static profile). The solution does not change.

Evidence

  • Flat seabeds unchanged: all 52 example decks write byte-identical outputs against dev.
    The flat-floor gates still hold, including AnchFz = 0 exactly at a grounded cable end in
    openfast_aggregate and anchor_uplift_channels.
  • New case (d) in test_anchor_uplift.py: a cable laid down a 10° frictionless slope from its
    anchor.
    • The anchor force runs 10.00° below horizontal, along the floor. Before the fix: 0.00°.
    • AnchTen continues the line tension (the next node's tension plus the end element's
      along-slope weight) to 0.1 N.
    • Both checks fail before the change.
  • static_friction_as_laid, cross slope: the finite-EI check now bounds the lateral anchor
    force in the plane of the floor.
    • The old vertical clip kept the lateral part of the pull of the run sunk into the soft penalty
      seabed (about AnchTen·δ/l0 along the slope normal); that part now goes to the floor.
    • The lateral force moves from −127 N to +203 N, about 0.1 % of the 210 kN anchor tension.
    • It stays below the 415 N reference without the sink offset.
    • The EI = 0 check is unchanged.
  • Full suite: ctest 301/301, pytest 2069 passed. The docs (outputs.rst, Anchor uplift) state
    the rule.

A finite-EI end resting on the seabed left the downward part of its end
force to the floor (force(3) = MAX(force(3), 0)), a rule from before
bathymetry: on a flat floor that part is the end node's weight, but on a
slope it also holds the line's own pull. A cable laid down a 10 deg
slope from its anchor reported AnchTen 1.5 % low (cos 10 deg of the
tension) and AnchFz = Point<P>Fz = 0 instead of -1.5 kN.

The floor now takes the part of the end force pressing into it along its
upward normal, the old rule on a flat floor, so the anchor keeps the
line's along-floor pull. On a frictional seabed it also holds the
along-floor part of the end node's own weight, up to mu times that
normal load. On the 10 deg slope the anchor force runs 10.00 deg below
horizontal and AnchTen continues the line tension to 0.1 N.

Flat seabeds are unchanged: all 52 example decks write identical
outputs. The cross-slope as-laid friction test now bounds the lateral
anchor force in the plane of the floor (203 N, below the 415 N of a
reference without the sink offset): the pull of the run sunk into the
penalty seabed, along the slope's normal, goes to the floor instead of
adding its lateral part. Found by the statics robustness campaign
(sloped-seabed lazy wave, BALANCE 6 %).

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T10:09:10.916087Z c8bbe7d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35409507 | 📁 Comparing c8bbe7d against latest (fd1936d)

  🔍 Preview build  

13 files changed · ± 13 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: c8bbe7d8c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 6b9fac4 into dev Oct 26, 2026
15 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/campaign-triage branch October 26, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant