Repository navigation
fix(outputs): keep the down-slope pull in a grounded finite-EI end force - #52
Merged
Merged
Conversation
A finite-EI end resting on the seabed left the downward part of its end force to the floor (force(3) = MAX(force(3), 0)), a rule from before bathymetry: on a flat floor that part is the end node's weight, but on a slope it also holds the line's own pull. A cable laid down a 10 deg slope from its anchor reported AnchTen 1.5 % low (cos 10 deg of the tension) and AnchFz = Point<P>Fz = 0 instead of -1.5 kN. The floor now takes the part of the end force pressing into it along its upward normal, the old rule on a flat floor, so the anchor keeps the line's along-floor pull. On a frictional seabed it also holds the along-floor part of the end node's own weight, up to mu times that normal load. On the 10 deg slope the anchor force runs 10.00 deg below horizontal and AnchTen continues the line tension to 0.1 N. Flat seabeds are unchanged: all 52 example decks write identical outputs. The cross-slope as-laid friction test now bounds the lateral anchor force in the plane of the floor (203 N, below the 415 N of a reference without the sink offset): the pull of the run sunk into the penalty seabed, along the slope's normal, goes to the floor instead of adding its lateral part. Found by the statics robustness campaign (sloped-seabed lazy wave, BALANCE 6 %). Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A finite-EI line end resting on the seabed passed the downward part of its end force to the floor
(
force(3) = MAX(force(3), 0)inCD_HermiteCable_Dyn_End_Force). The rule predates bathymetry. Ona flat floor that downward part is the end node's weight. On a slope it also includes the line's
own pull. A cable laid down a 10° slope from its anchor reported:
AnchTen1.5 % low (cos 10° of the line tension);AnchFz=Point<P>Fz= 0 instead of −1.5 kN.The statics robustness campaign found it: a sloped-seabed lazy wave whose vertical force balance
was off by 6 %.
Change
upward normal. On a flat floor this is the old rule, so the anchor keeps the line's along-floor
pull.
own weight, up to μ times that normal load (the smaller of the axial and lateral coefficients).
The line's pull stays with the anchor.
AnchTen,AnchFz/AnchFH,Point<P>F*, theend row of the static profile). The solution does not change.
Evidence
dev.The flat-floor gates still hold, including
AnchFz= 0 exactly at a grounded cable end inopenfast_aggregateandanchor_uplift_channels.test_anchor_uplift.py: a cable laid down a 10° frictionless slope from itsanchor.
AnchTencontinues the line tension (the next node's tension plus the end element'salong-slope weight) to 0.1 N.
static_friction_as_laid, cross slope: the finite-EI check now bounds the lateral anchorforce in the plane of the floor.
seabed (about AnchTen·δ/l0 along the slope normal); that part now goes to the floor.
outputs.rst, Anchor uplift) statethe rule.