Repository navigation
fix(openfast): restart a finite-EI cable from its committed boundary - #54
Merged
Merged
Conversation
openfast -restart did not continue a run with a finite-EI cable bit for bit. The checkpoint rebuild moves each coupled end to the restored input mesh, the glue's input at the restart time, and the cable's mirror held only its free DOFs: its fairlead kept the restored mesh's bits instead of the boundary the uninterrupted run committed (with NumCrctn = 0 that run stepped with the extrapolated input). The EI=0 lines already reload their committed coupled motion. On the IEA-15 mixed deck restarted at 6 s, the lazy-wave cable's .CD.out channels drifted by up to 9.4e-7 (relative) within 4 s, while the chain-only deck stayed exact. The cable mirror gains a boundary block, reloaded after the move: [q; v; a] of the held DOFs (the held accelerations move here from the force-blend block, so the configuration blend restores them too), the end-connection directions and the parent frame (orientation, angular velocity and acceleration). Unpacking checks the orientation before it writes anything. The parent frame of a torsion cable now reloads as committed instead of being re-derived from its end frames. With the fix every .CD.out and OpenFAST row from 6 s to 10 s matches the uninterrupted run bit for bit at dtM = DT and 2 DT, NumCrctn 0 and 1, and with a rigid fairlead END CONNECTIONS row (before: 3 to 6 rows of the cable's channels differed in each). The mirror test covers the new layout, its round trip and the orientation check. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
openfast -restartdid not continue a run with a finite-EI cable bit for bit.The checkpoint rebuild moves each coupled end to the restored input mesh, which holds the glue's
input at the restart time. The cable's mirror held only its free DOFs, so its fairlead kept the
restored mesh's bits instead of the boundary the uninterrupted run committed. (With
NumCrctn = 0, that run stepped with the extrapolated input.) The EI = 0 lines already reloadtheir committed coupled motion.
Reproduction: the IEA-15 mixed deck (chains plus the lazy-wave cable), restarted at 6 s.
.CD.outchannels drifted by up to 1.0e-7 relative (AnchTen4).dtM= 2DT), the drift reached 9.4e-7.A per-step bit-checksum dump of the cable state pinned the cause. At the first step after the
restart, the inputs, accelerations, end-connection directions and parent frame matched the
continuous run, but q, v and the cached committed force differed in their last bits.
Change
The cable mirror gains a boundary block (
CD_HFMF_BoundaryMirrorSize), reloaded after the move,holding:
configuration blend restores them too.
Unpacking checks the orientation before it writes anything. A torsion cable's parent frame now
reloads as committed, instead of being re-derived from its end frames. The OpenFAST shell
accounts for the block in its free-DOF count, and its comments on the coupled-motion mirror now
describe what the code does.
Evidence
OpenFAST v5 built with gfortran on this branch; IEA-15 mixed deck, checkpoint at 6 s, run to 10 s.
Every
.CD.outand OpenFAST output row from 6 to 10 s is compared:dtM=DT,NumCrctn0NumCrctn1dtM= 2DTEND CONNECTIONSThe mirror test covers the new layout, its round trip and the orientation check. ctest 302/302,
pytest 2069 passed. CHANGELOG,
VALIDATION.md(checkpoint-restart row) andARCHITECTURE.mdupdated.