Skip to content

feat(viv): cross-flow VIV on finite-EI cables - #56

Merged
SMI-Lab-Inha merged 10 commits into
devfrom
feat/viv-fei
Oct 27, 2026
Merged

SMI-Lab-Inha merged 10 commits into
devfrom
feat/viv-fei

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

The cross-flow VIV synchronisation model of #55 now runs on finite-EI (cubic-Hermite) cables in
the standalone driver: the same LINE TYPES columns Cl or Cl dF cF on an EI > 0 type.

Model. The lift is a distributed load per unit deformed length,
f = 1/2 rho d Cl cos(phi) U (t x v_r), with t the unit tangent of the centreline, v_r the
relative flow and cos(phi) interpolated linearly between the element's end nodes. It is
integrated against the Hermite shape functions at the drag element's three Gauss points (a
point above the surface carries none), with its exact position and velocity Jacobians in the
tangent (the residual path and the parallel tangent-only path). Each node carries a phase,
driven by the node's cross-flow motion along its own tangent, the slope degrees of freedom;
d, cF and dF at a node are the length-weighted averages over its lifting elements, and the
phases start at 2 pi i/N from End A. As on EI = 0 lines the phase is explicit: the step's
evaluations take the phase predicted from the step-start rate (at t_n+1 under the force blend,
whose committed force F_n keeps phi_n; at the generalised-alpha level under the configuration
blend), and the commit is the Heun update. With VIV the converged force is not cached as the
next step's F_n (it took the predicted phase).

No smoothing is needed: the Hermite tangent and the integrated lift leave no mesh-scale mode
for the synchronisation loop to pump.

State. The phases and running mean squares are saved and restored with the kinematics by the
recovering step, the snapshot and the deallocation; every evaluation outside a step (end
forces, node recovery, the held-field update, the committed acceleration) takes the committed
phase. The phase commit cannot fail, so a step is never left half committed: a node whose end
tangent is degenerate takes the step-start rate over the step. An internal wave family (Set_Waves) is refused on a VIV cable; deck waves and current
reach the standalone Hermite march as its held fluid field, which the phase follows.

Routes. build_one_hermite_cable installs VIV only for the standalone finite-EI march. A
finite-EI line with two moving ends (compatibility route), a finite-EI line beside bodies, rods
or free points (multibody march), the single-cable CD_Init_Deck_HermiteCable entry and the
aggregate (coupled, mixed) route refuse Cl > 0 by name; DeckFile mirrors the refusals.

Validation (VALIDATION.md L2-VIV-EI, gated in viv_lockin and hermite_viv):

  • the feat(viv): cross-flow vortex-induced vibration of EI = 0 lines #55 benchmark line as a finite-EI cable with EI = 1 N m^2: mid/quarter-span A/D
    0.662/0.421 against the EI = 0 line's 0.663/0.421 at the same frequency, unchanged at dtM
    1e-2, 2e-3 and 5e-4 s;
  • a bending-stiff, neutrally buoyant cable (EA 5e9 N, EI 5e7 N m^2, beta = pi^2 EI/(T L^2) ~ 1)
    against the EI = 0 string of equal first-mode frequency, tension T(1 + beta): the same
    mode-1 lock-in (A/D within 2.5 %, same frequency) for U <= 0.24 m/s; for U >= 0.27 m/s the
    string jumps to mode 2 while the cable stays in mode 1, its bending having raised f2/f1 to
    about 3.15;
  • a lazy-wave power cable (examples/lazy_wave_buoyancy_smeared.dat with Cl 0.8, 0.5 m/s
    current) shows out-of-plane VIV at 0.47 Hz with the fairlead tension oscillating at twice
    that frequency, and stays still without the lift.

Tests: hermite_viv (the setter's refusals, the lock-in with and without lift, a mid-run
snapshot replaying the state and phase bit for bit, the recovering step equal to the plain
step), viv_kernels section 7 (the per-length lift and its flow and tangent Jacobians against
central differences), viv_lockin (the two comparisons above, the EI = 1 cable at dtM 0.01 and
0.002 s), and the deck-file tests. Full suite: 305/305 ctest, 2082 pytest; every shipped
example's output is byte-identical to dev.

The synchronisation model on the cubic-Hermite cable: a per-length lift
k U (t x v_r) Gauss-integrated over each element with k = 1/2 rho D Cl
cos(phi) interpolated between the nodes, exact Jacobians in q and v, the
node phase sampled along the slope-DOF tangent, explicit predictor and
Heun commit as on EI = 0 lines. Wired through the step, the recovering
step, the snapshot, the end force and the node recovery, and installed by
the standalone finite-EI deck march; the other routes refuse it.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…ument finite-EI VIV (wip)

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…ing (wip)

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…wip)

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…EI lock-in at a fine step (wip)

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T23:18:43.090459Z d5106fc Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

read-the-docs-community Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35428055 | 📁 Comparing d5106fc against latest (fd1936d)

  🔍 Preview build  

18 files changed · ± 18 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

💡 Codex Review

model%viv_k = 0.5_wp*model%rho_w*model%diam*cl

P2 Badge Keep VIV coefficients synchronized with drag reconfiguration

If a caller invokes CD_HermiteCable_Dyn_Set_Drag again after enabling VIV, changing the water density or diameter updates the drag configuration but leaves viv_k and viv_dn at their installation-time values. Subsequent steps therefore combine the new drag with the old lift magnitude and shedding frequency. For example, doubling the diameter leaves the lift coefficient unchanged and produces twice the intended shedding frequency. Update these dependent VIV quantities when drag is reconfigured, or explicitly reject incompatible reconfiguration while VIV is enabled.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

The lift scale 1/2 rho D Cl and the node shedding diameter were set once
from the drag configuration of the moment VIV was installed; a later
CD_HermiteCable_Dyn_Set_Drag with another density or diameter left them
behind (doubling the diameter kept the old lift and doubled the shedding
frequency). The element Cl is now kept, and both are taken again from
the drag whenever it is reconfigured, its rollback included. The Hermite
VIV test reconfigures the drag both ways.

viv_lockin runs its eight decks side by side and allows a checked Debug
build 2400 s; it timed out at 600 s on the Debug CI jobs.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

Fixed in e3a9e9c: the element Cl is now kept, and the lift scale 1/2 rho D Cl and the node shedding diameter are recomputed from the drag whenever CD_HermiteCable_Dyn_Set_Drag reconfigures it (its rollback path included). hermite_viv now reconfigures the drag to twice the diameter and back and checks both quantities. The same push makes viv_lockin run its decks in parallel with a Debug-build timeout, which fixes the Debug CI timeouts.

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e3a9e9c821

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/CableDyn_HermiteCableDynamic.f90 Resolved
CD_HermiteCable_Dyn_Set_VIV left the committed acceleration at its
no-lift value, unlike the other load setters: installed on a model at
rest in a cross current, the first step's phase rate and the
generalised-alpha inertia took an acceleration without the lift, and
removing VIV (all-zero Cl) kept the lift in it. The setter now solves
the consistent acceleration after installing or removing the lift; if
that fails, the previous VIV configuration, its phases and running mean
squares, and the acceleration are restored. The Hermite VIV test checks
that installing the lift moves the acceleration and removing it brings
the no-lift value back.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: a6f62013e7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

viv_lockin runs four driver processes at once but counted as one ctest
job, so under ctest --parallel 4 it shared the four CI cores with three
more tests: on the Windows Debug job attachment_cross_current, which
overlapped it, went from about 190 s on dev to 572 s and then past its
600 s timeout. PROCESSORS 4 makes ctest run nothing beside it, as for
the other tests that run their decks four at a time.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: d5106fced6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 7980bcc into dev Oct 27, 2026
21 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the feat/viv-fei branch October 27, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant