Repository navigation
fix(outputs): note that line nodes are numbered from 1, MoorDyn's from 0 - #57
Merged
Merged
Conversation
CableDyn numbers a line's nodes from 1 at End A, while MoorDyn-C and MoorDyn-F number them from 0 at End A, and CableDyn runs a line written anchor-first from its fairlead. A MoorDyn deck's L<L>N<J> therefore named another node without notice: on the VIV benchmark L1N12 read the node at 22 m where MoorDyn reads 24 m. The numbering stays; a run whose OUTPUTS name line nodes, or whose LINES Outputs flag writes the per-line files, now prints a note giving the correspondence (N<J-1>, or N<NumSegs+1-J> on an anchor-first line), on the standalone driver and in OpenFAST. The outputs and migration pages state it. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CableDyn numbers a line's nodes from 1 at End A. MoorDyn-C and MoorDyn-F number them from 0 at End A. CableDyn also runs a line written anchor-first from its fairlead. So a MoorDyn deck's
L<L>N<J>channels name a different node in CableDyn, with no warning.Example: on a 100 m line with 50 segments, written in CableDyn's order,
L1N12PZreads the node at 22 m in CableDyn and the node at 24 m in MoorDyn. Confirmed from the t = 0 sag shape, against both MoorDyn codes.The numbering itself is unchanged; existing CableDyn decks and outputs are not affected.
Changes:
Outputsflag writes the per-line node files. The note gives the correspondence:N<J>here is MoorDyn'sN<J-1>, orN<NumSegs+1-J>on a line written anchor-first.L<L>N<J>…,Ten,Curv,BendMom,StfMom,Torq,Twist<L>N<J>.WrScr, for the deck OUTPUTS of the.CD.outfile).outputs.rststates the numbering and both correspondences;migrating.rst"Node identity" row replaces "MoorDyn node numbers are not reproduced";options.rstlinks theN0rejection to it;ei0_slack_dynamicschecks that a run with a LINESpflag prints the note and a run without node outputs does not.Checks:
-W;CableDyn_OF.f90compiles. No OpenFAST run was made: no shipped OpenFAST example asks for line-node channels, and the OpenFAST side calls the same check the standalone test covers.