Skip to content

fix(outputs): note that line nodes are numbered from 1, MoorDyn's from 0 - #57

Merged
SMI-Lab-Inha merged 1 commit into
devfrom
fix/node-channel-notice
Oct 27, 2026
Merged

SMI-Lab-Inha merged 1 commit into
devfrom
fix/node-channel-notice

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

CableDyn numbers a line's nodes from 1 at End A. MoorDyn-C and MoorDyn-F number them from 0 at End A. CableDyn also runs a line written anchor-first from its fairlead. So a MoorDyn deck's L<L>N<J> channels name a different node in CableDyn, with no warning.

Example: on a 100 m line with 50 segments, written in CableDyn's order, L1N12PZ reads the node at 22 m in CableDyn and the node at 24 m in MoorDyn. Confirmed from the t = 0 sag shape, against both MoorDyn codes.

The numbering itself is unchanged; existing CableDyn decks and outputs are not affected.

Changes:

  • Notice: a run prints one note when its OUTPUTS name a line node, or when a LINES Outputs flag writes the per-line node files. The note gives the correspondence: N<J> here is MoorDyn's N<J-1>, or N<NumSegs+1-J> on a line written anchor-first.
    • Channels covered: L<L>N<J>…, Ten, Curv, BendMom, StfMom, Torq, Twist<L>N<J>.
    • Printed by the standalone driver and by OpenFAST (WrScr, for the deck OUTPUTS of the .CD.out file).
    • Rod nodes already use MoorDyn's numbering (0 = End A) and are left alone.
  • Docs:
    • outputs.rst states the numbering and both correspondences;
    • the migrating.rst "Node identity" row replaces "MoorDyn node numbers are not reproduced";
    • options.rst links the N0 rejection to it;
    • CHANGELOG entry.
  • Test: ei0_slack_dynamics checks that a run with a LINES p flag prints the note and a run without node outputs does not.

Checks:

  • ctest 305/305 and pytest against the built driver (2092 passed);
  • fprettify clean; docs build with -W;
  • OpenFAST built with this branch's CableDyn module, so CableDyn_OF.f90 compiles. No OpenFAST run was made: no shipped OpenFAST example asks for line-node channels, and the OpenFAST side calls the same check the standalone test covers.

CableDyn numbers a line's nodes from 1 at End A, while MoorDyn-C and
MoorDyn-F number them from 0 at End A, and CableDyn runs a line written
anchor-first from its fairlead. A MoorDyn deck's L<L>N<J> therefore
named another node without notice: on the VIV benchmark L1N12 read the
node at 22 m where MoorDyn reads 24 m. The numbering stays; a run whose
OUTPUTS name line nodes, or whose LINES Outputs flag writes the per-line
files, now prints a note giving the correspondence (N<J-1>, or
N<NumSegs+1-J> on an anchor-first line), on the standalone driver and in
OpenFAST. The outputs and migration pages state it.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T05:55:02.649906Z a03044c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35434038 | 📁 Comparing a03044c against latest (fd1936d)

  🔍 Preview build  

18 files changed · ± 18 modified

± Modified

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 3f54f1c into dev Oct 27, 2026
15 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/node-channel-notice branch October 27, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant