Skip to content

fix(statics): solve light slack finite-EI lines; keep a line's azimuth continuous - #59

Merged
SMI-Lab-Inha merged 2 commits into
devfrom
fix/light-slack-statics
Oct 27, 2026
Merged

SMI-Lab-Inha merged 2 commits into
devfrom
fix/light-slack-statics

Conversation

@SMI-Lab-Inha

@SMI-Lab-Inha SMI-Lab-Inha commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

Two items from the robustness backlog.

1. Light slack finite-EI lines

A finite-EI line longer than its span with no net weight, or too little for its bending stiffness, failed its static solve.

Cause. With no catenary to start from, both routes ended in one of two ways:

  • on the compressed straight strut, which is a saddle;
  • stalled at the round-off of the axial forces, about EA·ε·|r|/h. A weightless line's force scale is 1 N, which puts that floor above the tolerance.

On a 120 m line with EI = 1e4 N·m², a net weight of 0.01 N/m passed and 0.001 N/m failed.

Fix: a weight-continuation route, run only when both routes have failed (light_line_route).

  • Eligible lines: slack, planar, in still water, over a level seabed, with no attachments and no tensile_safety, and with |w| < 100·EI/L³.
  • Auxiliary weight: the line is built recursively with 100·EI/L³ added to every element. Its sign is the sign of the net weight; a weightless line gets a downward one.
  • Continuation: that equilibrium is carried back to the line's own weight in steps of a quarter, the last step from 1/256 to zero, with a failed step halved. The line is held in the vertical plane of its chord throughout.
  • Tolerance: the steps also accept the round-off floor of the axial forces, 8·EA·ε·|r|max/hmin.
  • Acceptance: the result goes through the same audit and stability check as the routes' results.

Recursive builds. The weight continuation, the coarse current pass and the still-water references now inherit the outer build's allowance for a Fixed End A (fixed_fairlead). Before, they ran without the standalone controls and refused it.

Weightless line. It is the pinned-pinned elastica. Nothing in the deck chooses the side of the bow, so it is solved bowed downward (the limit of a vanishing weight) and a note says so. The note is printed by a standalone run and returned to the coupled aggregate. With its ends one above the other it is still refused, and the message now names that cause.

Results (120 m pinned line, ends 113 m apart):

CableDyn Exact elastica
End thrust 7.0563 N 7.0564 N
Mid-span bow 17.9399 m 17.9399 m
  • The same line with both ends Fixed (legal in a deck with a Connect point) gives the same result.
  • At ±0.001 N/m the line bows down or up as expected, and the heavy and buoyant results are mirror images.
  • A 20 s march from the weightless bow stays at rest.
  • At w = 0 the tangent has exactly one zero eigenvalue, the bow turning about the chord. Every other mode is positive.

2. Azimuth range

The tangent azimuth of a line along +X jumped between 0 and about 360 from one output row to the next as the line swayed a fraction of a degree either side of 0. The sign of a round-off component did the same. On the IEA-15 mixed OpenFAST deck, 315 to 485 of the 801 rows of each cable azimuth channel read 359.9x.

Fix. A line whose static chord heads within 45° of +X now reports its azimuths in (−180, 180]. Every other line keeps [0, 360).

  • The cut of each line's range then lies at least 45° from its heading.
  • The range is fixed for the run, from the deck positions, so the line's motion cannot switch it.
  • A round-off component across the cut reads on its included side.

Implementation.

  • The flag is set at parse time (DeckLine%azi_signed) and carried onto the EI = 0 model and the cable.
  • The standalone, aggregate, multibody and C API channel paths all read it.
  • C API lines built without a deck keep [0, 360).

Checks

  • Test suite: ctest 307/307. This includes:
    • the new light_slack_statics test against the exact elastica;
    • driver_channels azimuth cases;
    • driver_msg_weightless_finite_ei (now solves, with the note) and _vertical (refused by name);
    • light_slack_statics with both ends Fixed, and flagship_compression_note checking that the aggregate receives the weightless-bow note (it fails without the fix).
  • C API test. test_long_failure_message_is_kept_whole needed a new message source: the weightless deck it used now solves, and no other deck's message is longer than 1024 characters. It now uses a missing deck at a 1,100-character path, a 1,319-character message.
  • Examples: all 52 shipped example decks are byte-identical to dev.
  • OpenFAST: built with this branch and rerun on the IEA-15 mixed deck for 20 s.
    • Every non-azimuth channel is identical to dev.
    • The azimuths are equal modulo 360 to the print precision.
    • No row reads near 360; the cable's azimuths now swing between −0.17° and +0.50°.
  • Docs and format: the docs build with -W, and fprettify is clean on the changed lines.

…h continuous

A finite-EI line longer than its span with no net weight, or too little
for its bending stiffness, failed its static solve. With no catenary to
start from, both routes reached the compressed straight strut (a saddle)
or stalled at the round-off of the axial forces, EA eps |r|/h, which a
weightless line's unit force scale puts above the tolerance (0.001 N/m on
a 120 m line with EI 1e4 failed; 0.01 N/m passed). When both routes fail
on a slack, planar line in still water with |w| < 100 EI/L^3, the line is
now solved with that auxiliary weight (of the sign of its net weight,
downward for a weightless line) and carried back to its own weight by a
continuation in the weight, held in the vertical plane of its chord and
accepting the round-off floor of the axial forces; the result is audited
and stability-checked as the routes' are. A weightless line bows as the
pinned-pinned elastica: end thrust 7.0563 N and mid-span bow 17.9399 m
against 7.0564 N and 17.9399 m exact. Nothing in the deck chooses the side
of its bow, so it is solved bowed downward and a note says so; with its
ends one above the other it is still refused, now by that cause.

The tangent azimuth of a line along +X jumped between 0 and about 360
from one output row to the next as the line swayed a fraction of a degree
to either side, or by the sign of a round-off component: on the IEA-15
mixed OpenFAST deck 315 to 485 of 801 rows of each cable azimuth channel
read 359.9x. A line whose static chord heads within 45 deg of +X now
reports its azimuths in (-180, 180], every other line in [0, 360) as
before, so the cut of a line's range lies at least 45 deg from its
heading; a round-off component across the cut reads on its included side.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T13:08:47.451807Z 5715cee Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

read-the-docs-community Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35442694 | 📁 Comparing 5715cee against latest (fd1936d)

  🔍 Preview build  

24 files changed · ± 24 modified

± Modified

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e38ff8a776

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/CableDyn_DeckDriver.f90 Resolved
Comment thread src/CableDyn_DeckDriver.f90 Resolved
…htless-bow note

The recursive builds of a finite-EI line (weight continuation, coarse
current pass, still-water references) ran without the standalone
controls, so they refused a Fixed End A that the standalone build of the
same line admits; the weight continuation of a weightless line with both
ends Fixed (legal in a deck with dynamic points) failed on it. They now
inherit the outer build's allowance (fixed_fairlead). All 52 examples are
unchanged.

The weightless-bow note was reported before the build cleared its note
buffer, so the coupled aggregate, which prints nothing itself, never
received it. It is now reported with the other initialisation
notes.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 5715ceeb8e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 149c064 into dev Oct 27, 2026
21 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/light-slack-statics branch October 27, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant