Skip to content

feat(viv): cross-flow VIV on the coupled routes - #60

Merged
SMI-Lab-Inha merged 2 commits into
devfrom
feat/viv-coupled
Oct 28, 2026
Merged

SMI-Lab-Inha merged 2 commits into
devfrom
feat/viv-coupled

Conversation

@SMI-Lab-Inha

@SMI-Lab-Inha SMI-Lab-Inha commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

MoorDyn-F runs its VIV model inside OpenFAST, but CableDyn refused Cl > 0 on the aggregate route. That route serves OpenFAST, FAST.Farm and the standalone runner of a mixed EI = 0 / finite-EI deck. This PR lifts the refusal on all three.

Changes

  • Lift on the aggregate. The aggregate installs the lift on its finite-EI cables (install_viv), as the standalone Hermite march does. Its EI = 0 lines already built it through init_one_model. The phase follows the host's fluid field (CD_AGG_SetFluidFields).
  • Correction rewinds. The in-memory snapshot/restore already carried the VIV state on both line kinds, so OpenFAST's correction iterations needed no change.
  • OpenFAST checkpoint. The state mirror (x%states) now carries the VIV state: the phase and the two running mean squares per node, then the averaging time.
    • An EI = 0 line ends its span with this block. The block is sized by CD_System_Line_VIV_MirrorSize and goes through CD_Get/Set_System_Line_VIV_State, which sit over the model-level CD_Get/Set_Model_VIV_State.
    • A cable's mirror carries the same block before its torsion block (CD_HFMF_VIVMirrorSize).
    • A reload also sets the rollback and recovery copies of the state, and the in-step phase.
  • Linearisation. The variable registration covers the new blocks. Linearisation stays quasi-static, with no continuous states.
  • Averaging window. Without VIVrmsWindow, both line kinds average over MoorDyn's 500 steps of the deck dtM, also when OpenFAST steps CableDyn at a dtM adjusted to its DT. With no deck dtM, they average over 500 coupling steps.
  • Single-cable entry. CD_Init_Deck_HermiteCable applies no fluid field, so it still refuses Cl > 0. Its message now points to the aggregate.
  • Python. DeckFile drops the coupled/mixed refusal. On the coupled route it does not ask for water in the deck, since the host supplies it.
  • Docs. capabilities, coupling, theory, migrating, troubleshooting and CHANGELOG.

Checks

  • New viv_coupled test (22 s). An EI = 0 riser and a finite-EI cable (EI 1 N·m²) sit side by side on the coupled aggregate in a 0.15 m/s host current: each 100 m long at 50 kN, 50 segments.
    • Lock-in over 60–120 s:

      A/D Frequency
      Riser 0.6645 0.292 Hz
      Cable 0.6646 0.292 Hz
      MoorDyn-F 0.662 0.293 Hz
      Standalone CableDyn 0.665
    • With Cl = 0 both lines stay still (A/D below 4e-5).

    • Checkpoint restart, using the shell's rebuild recipe: it continues bit for bit. A rebuild without the VIV reload diverges.

    • A correction rewind repeats bit for bit.

    • Averaging window: deck dtM 0.001 s at a 0.01 s coupling step gives both line kinds 0.5 s; with no deck dtM, both get 5 s.

  • OpenFAST 5 with CompMooring = 5. This ran on the IEA-15 MW mixed deck with Cl 0.8 on the lazy-wave cable, a SeaState 0.5 m/s current across it, no waves, 60 s. It was checkpointed at 30 s and restarted.
    • The restarted CableDyn and OpenFAST outputs are identical to the uninterrupted run at every row (max difference 0).
    • The lift raises the cable's lateral sway by 4–10 % along its span over the Cl = 0 run.
  • Test suite: ctest 308/308; Python 793 passed.
  • Examples: all 52 shipped examples are unchanged. None uses Cl > 0 on these routes.
  • Format: fprettify is clean.

Remaining VIV refusals: a finite-EI line beside bodies, rods or free points (next PR), and a finite-EI line with two moving ends (the Cosserat compatibility element, which has no VIV).

MoorDyn-F runs its VIV model inside OpenFAST; CableDyn refused Cl > 0 on
the aggregate route (OpenFAST, FAST.Farm and the standalone runner of a
mixed EI = 0 / finite-EI deck). The aggregate now installs the lift on
both line kinds, and the phase follows the host's fluid field. The
in-memory correction rewind already carried the VIV state; the OpenFAST
checkpoint now does too: an EI = 0 line ends its span of the state
mirror with its phases, running mean squares and averaging time, and a
cable's mirror carries the same block before its torsion block. A
restart reloads them with their rollback and recovery copies.

A riser and a cable side by side in a 0.15 m/s host current lock in at
A/D 0.665 at 0.292 Hz (MoorDyn-F 0.662 at 0.293 Hz); a checkpoint
rebuild continues bit for bit, and one without the VIV reload does not.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T15:29:54.041868Z 04b6bd9 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

read-the-docs-community Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35446341 | 📁 Comparing 04b6bd9 against latest (fd1936d)

  🔍 Preview build  

24 files changed · ± 24 modified

± Modified

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 39b3322e25

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/CableDyn_DeckDriver.f90 Resolved
Without VIVrmsWindow an EI = 0 line averages over MoorDyn's 500 steps
of the deck dtM, but a cable took 500 steps of the step it was built
with, which a coupled host adjusts from the deck dtM to its DT: deck dtM
0.001 s at DT 0.01 s gave 0.5 s and 5 s in one run. The cable now takes
the deck dtM too, and the step only when the deck has none. Standalone
runs are unchanged (their cables are built at the deck dtM). The options
reference now lists the window on every route.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 04b6bd9d68

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit abd9ad6 into dev Oct 28, 2026
26 of 27 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the feat/viv-coupled branch October 28, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant