Repository navigation
feat(viv): cross-flow VIV of finite-EI cables on the multibody march - #61
Merged
Merged
Conversation
A finite-EI line on a Rigid6 body or rod, or in a deck with Free or Connect points, runs on the multibody march, which refused Cl > 0. That march refreshes each cable's held fluid field every step and steps the cable through the same snapshot and restore the VIV state already rides in, so the builds now install the lift as the Hermite march's do. A taut cable beside a weighted Connect point locks in as on the Hermite route (mid/quarter A/D 0.662/0.421 at 0.300 Hz on both), and a clamped cable on a moving Rigid6 buoy runs with it. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A finite-EI cable runs on the multibody march when its deck has a Rigid6 body or rod, or Free or Connect points. That march refused
Cl > 0, so VIV of such a cable was not possible. This PR lifts the refusal.Changes
install_viv, as the Hermite march's do. Both builds are covered: clamped and pinned.CD_HFMF_Snapshot/CD_HFMF_Restore. That pair already carries the VIV phase and running mean squares, so a re-step does not advance the phase twice.DeckFiledrops the matching refusal. A finite-EI line with two moving ends still refusesCl > 0: that is the Cosserat compatibility element, which has no VIV.Checks
viv_lockin, new case: the same 100 m finite-EI cable (EI 1 N·m², 0.15 m/s current) as the Hermite case, with End A Fixed. A 5 t Connect point hung on two chains 300 m away puts the deck on the multibody march.The gate is within 1 % and one frequency bin.
A cable on a moving buoy.
buoy_clamped_cable(a clamped cable on a moored Rigid6 buoy) withCl 0.8, in current, ran 30 s on the monolithic body step: at most 3 outer iterations, no step halvings.Python:
buoy_clamped_cablewithCl 0.8passes the validator; it was refused before.Test suite: ctest all green; Python 2064 passed.
Examples: all 52 shipped examples byte-identical to dev (none uses
Cl > 0on the multibody march).Format: fprettify and ruff are clean.
Remaining VIV refusal: a finite-EI line with two moving ends.
Signed-off-by: Jae Hoon Seo jaehoon.seo@inha.ac.kr