Repository navigation
feat(outputs): LINES Outputs flag V, the VIV lift at the nodes - #62
Merged
Merged
Conversation
MoorDyn's line flag V writes the cross-flow VIV lift force at each node. CableDyn now writes it to <root>.Line<L>.V.out on the dynamic runs of the standalone routes that carry VIV (EI = 0 models, the point system, Rigid6 bodies, rods, the multibody march and the Hermite march), End A to End B. An EI = 0 line's end nodes carry none, as MoorDyn's; on a finite-EI line each element's consistent lift is lumped to its two nodes, so at the interior nodes of a taut line in lock-in it matches the EI = 0 line within 0.1 %. As in MoorDyn the flag is upper case: its v (node velocities) is not written and stays a parse error. The mixed runner refuses V with p and t; the two-moving-end finite-EI route, which carries no VIV, refuses it by name. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…two moving ends The deck validator mirrored neither native refusal of the compatibility route (a finite-EI deck with a moving End B, which carries no VIV): Cl > 0 on any line and, new with the flag, LINES Outputs V. A farm-shared cable from Turbine1 to Turbine2 now fails in DeckFile with the native messages. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MoorDyn's line flag
Vwrites the cross-flow VIV lift at each node of a line. CableDyn rejected the flag, so the lift was not reachable as an output. This PR adds it.Changes
<root>.Line<L>.V.out. The LINESOutputsflagVwrites the lift(x, y, z)at every node, End A to End B, at the same times as.out.EI = 0models and the point system;EI = 0lines. The lift comes fromCD_Get_Model_VIV_Lift, at the committed state. The end nodes carry none, as in MoorDyn.CD_HermiteCable_Dyn_VIV_Node_Liftsums the translational part of each element's consistent lift load at its two nodes. The writer turns it from the cable's solve frame into the global frame.v(node velocities) is not written and stays a parse error, with a message that says so.EI = 0/ finite-EI runner refusesValong withpandt.Cl > 0on that route.Checks
viv_lockin. It reads the V files of theEI = 0line, the finite-EI cable on the Hermite march and the same cable on the multibody march, all in lock-in:EI = 0line's end nodes carry no lift;EI = 0line's end half-segments carry no lift while a cable element shares its lift between its two nodes.msg_line_flag_velocitytest: lower-casevfails with a message that namesV.Cl > 0is refused too. The native driver gives the same messages on that deck.Signed-off-by: Jae Hoon Seo jaehoon.seo@inha.ac.kr