Skip to content

feat(outputs): LINES Outputs flag V, the VIV lift at the nodes - #62

Merged
SMI-Lab-Inha merged 2 commits into
devfrom
feat/viv-lift-output
Oct 28, 2026
Merged

SMI-Lab-Inha merged 2 commits into
devfrom
feat/viv-lift-output

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

MoorDyn's line flag V writes the cross-flow VIV lift at each node of a line. CableDyn rejected the flag, so the lift was not reachable as an output. This PR adds it.

Changes

  • New file <root>.Line<L>.V.out. The LINES Outputs flag V writes the lift (x, y, z) at every node, End A to End B, at the same times as .out.
  • Routes. The file is written on the dynamic runs of every standalone route that carries VIV:
    • EI = 0 models and the point system;
    • Rigid6 bodies and rods;
    • the multibody march and the Hermite march.
  • EI = 0 lines. The lift comes from CD_Get_Model_VIV_Lift, at the committed state. The end nodes carry none, as in MoorDyn.
  • Finite-EI lines. CD_HermiteCable_Dyn_VIV_Node_Lift sums the translational part of each element's consistent lift load at its two nodes. The writer turns it from the cable's solve frame into the global frame.
  • Case. The flag is upper case, as in MoorDyn. Its lower-case v (node velocities) is not written and stays a parse error, with a message that says so.
  • Refusals.
    • The mixed EI = 0 / finite-EI runner refuses V along with p and t.
    • The two-moving-end finite-EI route has no VIV and refuses the flag by name.
    • The Python deck validator follows both refusals. It also gains the missing native refusal of Cl > 0 on that route.
  • Docs: outputs, migrating and CHANGELOG.

Checks

  • viv_lockin. It reads the V files of the EI = 0 line, the finite-EI cable on the Hermite march and the same cable on the multibody march, all in lock-in:
    • the EI = 0 line's end nodes carry no lift;
    • at the interior nodes, the standard deviation of the cross-flow lift over 60–120 s agrees within 1 % across all three;
    • the exception is each end node's neighbour, where the EI = 0 line's end half-segments carry no lift while a cable element shares its lift between its two nodes.
  • New msg_line_flag_velocity test: lower-case v fails with a message that names V.
  • Python: the flag is accepted and case-checked. It is refused on the mixed route, and on a farm-shared finite-EI cable (Turbine1 to Turbine2), where Cl > 0 is refused too. The native driver gives the same messages on that deck.
  • Test suite: ctest 309/309; Python 2027 passed.
  • Examples: all 52 shipped examples byte-identical to dev.
  • Format: fprettify and ruff are clean.

Signed-off-by: Jae Hoon Seo jaehoon.seo@inha.ac.kr

MoorDyn's line flag V writes the cross-flow VIV lift force at each node.
CableDyn now writes it to <root>.Line<L>.V.out on the dynamic runs of
the standalone routes that carry VIV (EI = 0 models, the point system,
Rigid6 bodies, rods, the multibody march and the Hermite march), End A
to End B. An EI = 0 line's end nodes carry none, as MoorDyn's; on a
finite-EI line each element's consistent lift is lumped to its two
nodes, so at the interior nodes of a taut line in lock-in it matches
the EI = 0 line within 0.1 %. As in MoorDyn the flag is upper case: its
v (node velocities) is not written and stays a parse error. The mixed
runner refuses V with p and t; the two-moving-end finite-EI route,
which carries no VIV, refuses it by name.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…two moving ends

The deck validator mirrored neither native refusal of the compatibility
route (a finite-EI deck with a moving End B, which carries no VIV):
Cl > 0 on any line and, new with the flag, LINES Outputs V. A farm-shared
cable from Turbine1 to Turbine2 now fails in DeckFile with the native
messages.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T06:55:14.166423Z b2a48c4 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35462317 | 📁 Comparing b2a48c4 against latest (fd1936d)

  🔍 Preview build  

24 files changed · ± 24 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: b2a48c40cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 31f7fef into dev Oct 28, 2026
21 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the feat/viv-lift-output branch October 29, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant