Repository navigation
fix(viv): seed the shedding phase from the deck's End A; MoorDyn-C's riser - #63
Merged
Merged
Conversation
…riser MoorDyn seeds the phase at 2 pi i/N with node i counted from the line's AttachA. CableDyn counted from its own End A, which on a line written anchor first (the common MoorDyn row order, turned around by the reader) is MoorDyn's node N, and on a finite-EI mesh the static solve refined the node index no longer named the deck nodes. CD_Deck_VIV_Phase_Seed now gives MoorDyn's seed node by node: counted from the deck's End A, kept at the deck nodes of a refined mesh, interpolated in arc length at the nodes the refinement added. Both line kinds take it (an optional phase_seed of their VIV setters). Lines written fairlead first on the deck mesh are unchanged. MoorDyn-C's VIV test, the catenary riser of Thorsen et al. in a uniform 0.2 m/s current (written anchor first), joins the validation set (viv_riser): over 20-40 s at dtM 1e-3 s the fairlead tension averages 69.92 N against MoorDyn-C's 69.93 N, ranges 3.73 N against 3.72 N, and oscillates with a period of 0.4853 s against the measured 0.4808 s and MoorDyn-C's 0.4811 s, converging with dtM (0.4829 s at 2.5e-4 s). VALIDATION records it and the coupled VIV, which it listed as unsupported. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MoorDyn seeds each node's VIV shedding phase at 2π i/N, with node i counted from the line's AttachA. CableDyn counted from its own End A. For two kinds of line that gives a different start:
Changes
CD_Deck_VIV_Phase_Seedgives MoorDyn's seed node by node:CD_Set_Model_VIV(EI = 0) andCD_HermiteCable_Dyn_Set_VIV(finite-EI) gain an optionalphase_seed. It is checked for size and finiteness.Checks
New
viv_risertest: MoorDyn-C's own VIV case, the catenary riser of Thorsen et al. in a uniform 0.2 m/s current, written anchor first. Results over 20–40 s atdtM1e-3 s:The period converges with
dtM(0.4829 s at 2.5e-4 s).viv_coupledcovers the seed on the coupled routes.Test suite: ctest 310/310; Python 2027 passed.
Examples: all 52 shipped examples are byte-identical to dev. None uses
Cl > 0.Format: fprettify is clean.
Signed-off-by: Jae Hoon Seo jaehoon.seo@inha.ac.kr