Skip to content

fix(viv): seed the shedding phase from the deck's End A; MoorDyn-C's riser - #63

Merged
SMI-Lab-Inha merged 1 commit into
devfrom
feat/viv-seed-riser
Oct 29, 2026
Merged

SMI-Lab-Inha merged 1 commit into
devfrom
feat/viv-seed-riser

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

MoorDyn seeds each node's VIV shedding phase at 2π i/N, with node i counted from the line's AttachA. CableDyn counted from its own End A. For two kinds of line that gives a different start:

  • A line written anchor first (the usual MoorDyn row order). The reader turns it around, so CableDyn's node 1 is MoorDyn's node N.
  • A finite-EI mesh the static solve refined. The node index no longer names the deck nodes.

Changes

  • CD_Deck_VIV_Phase_Seed gives MoorDyn's seed node by node:
    • counted from the deck's End A;
    • held at the deck nodes of a refined mesh;
    • interpolated in unstretched arc length at the nodes the refinement added.
  • Both line kinds take it. CD_Set_Model_VIV (EI = 0) and CD_HermiteCable_Dyn_Set_VIV (finite-EI) gain an optional phase_seed. It is checked for size and finiteness.
  • Routes. The standalone, multibody and coupled builds all pass it, since they share the line builders.
  • Unchanged decks. Lines written fairlead first on the deck mesh keep their phases exactly.
  • Docs: theory, VALIDATION and CHANGELOG. VALIDATION had listed coupled VIV as unsupported; it now records it.

Checks

  • New viv_riser test: MoorDyn-C's own VIV case, the catenary riser of Thorsen et al. in a uniform 0.2 m/s current, written anchor first. Results over 20–40 s at dtM 1e-3 s:

    CableDyn MoorDyn-C Measured
    Mean fairlead tension 69.92 N 69.93 N
    Tension range 3.73 N 3.72 N
    Period 0.4853 s 0.4811 s 0.4808 s

    The period converges with dtM (0.4829 s at 2.5e-4 s).

  • viv_coupled covers the seed on the coupled routes.

  • Test suite: ctest 310/310; Python 2027 passed.

  • Examples: all 52 shipped examples are byte-identical to dev. None uses Cl > 0.

  • Format: fprettify is clean.

Signed-off-by: Jae Hoon Seo jaehoon.seo@inha.ac.kr

…riser

MoorDyn seeds the phase at 2 pi i/N with node i counted from the line's
AttachA. CableDyn counted from its own End A, which on a line written
anchor first (the common MoorDyn row order, turned around by the reader)
is MoorDyn's node N, and on a finite-EI mesh the static solve refined
the node index no longer named the deck nodes. CD_Deck_VIV_Phase_Seed now
gives MoorDyn's seed node by node: counted from the deck's End A, kept at
the deck nodes of a refined mesh, interpolated in arc length at the nodes
the refinement added. Both line kinds take it (an optional phase_seed of
their VIV setters). Lines written fairlead first on the deck mesh are
unchanged.

MoorDyn-C's VIV test, the catenary riser of Thorsen et al. in a uniform
0.2 m/s current (written anchor first), joins the validation set
(viv_riser): over 20-40 s at dtM 1e-3 s the fairlead tension averages
69.92 N against MoorDyn-C's 69.93 N, ranges 3.73 N against 3.72 N, and
oscillates with a period of 0.4853 s against the measured 0.4808 s and
MoorDyn-C's 0.4811 s, converging with dtM (0.4829 s at 2.5e-4 s).
VALIDATION records it and the coupled VIV, which it listed as
unsupported.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T01:45:04.188319Z 64b724a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35487277 | 📁 Comparing 64b724a against latest (fd1936d)

  🔍 Preview build  

24 files changed · ± 24 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 64b724a4ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 4754a69 into dev Oct 29, 2026
21 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the feat/viv-seed-riser branch October 29, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant