Repository navigation
feat(syrope): composite lines, a Syrope section between chains - #67
Conversation
A Syrope line had to be a single taut section. A LINE can now carry Syrope sections between plain EI = 0 sections, such as the chain-polyester-chain mooring of a floating platform. init_one_syrope_model builds each Syrope section's working curve and solves the static start through init_one_model with a secant EA per element. On a composite line the tension varies along a sagging Syrope section, so each Syrope element takes the secant of its rest curve at its own tension: every element starts on its curve, its slow strain at rest. One secant per section left the elements away from the mean off the curve, and their slow strains moved the fairlead tension by 1.4e-5 within 2 s; now a still run keeps it to the printed digits. The tension update stays a contraction where the chains' weight and the geometry set the tension. The line's sections split into runs of one secant for the model build (the mesh is unchanged), the chains keep their BA damping, and a tension above the OWC table or a slack Syrope element stops with a named error. A single-section line keeps its secant from the mean strain: all 52 example decks are bit-identical. SYROPE IC applies to every Syrope section of a line; the Python deck reader accepts it on any line with a Syrope section. New test syrope_composite (every polyester element on its OWC to 2e-11, the equilibrium start, the Tmax0 working curve, the named refusals) and example composite_chain_syrope_chain.dat on a moving vessel. The driver format, the rope guide and the tutorial no longer describe the current, waves and bathymetry the Syrope hydrodynamics now carry as refused. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a5d8426b6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ite line The composite static solve starts its Syrope elements at the working curve's alpha, so on a taut line the first trial tension can lie above the top of the OWC table although the equilibrium is well inside it (20 m of rope stretched to 20.7 m: 5.36 MN at alpha against the table's 4.39 MN top, 2.04 MN on the curve). Such an iterate now takes the curve's secant at the table's top row and the update continues; only a converged tension above the table is refused, by the same message. New gate in syrope_composite: that taut two-section rope builds with every element on its OWC to 5e-11 (the unfixed code refuses it at 5.355 MN). Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52c4a78346
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The tension update of a composite line's Syrope secants contracts by 1 - secant/tangent of the rest curve, slowly near a working curve's zero-tension strain: a lightly loaded SYROPE IC rope (Tmax0 2.5 MN, about 53 kN of tension) still moved its secants by 5e-5 after the 50 iterations and was refused. The last two solves now give the line's response at each element, a falling line in (strain, tension); its crossing with the rising rest curve (bisection over the table) is the next secant. The step is taken only beyond the tension update in the same direction and at most 100 times as far, else the tension update stands; the convergence test still measures how far each element sits off its curve. That rope now converges in 18 solves, every element on the Tmax0 working curve to 6e-10 (new gate in syrope_composite); the chain-polyester-chain lines converge in 13. Full suite passes; both Syrope examples are bit-identical. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
A Syrope line had to be a single taut section. A LINE can now carry
Syrope sections between plain EI = 0 sections, such as the
chain-polyester-chain mooring of a floating platform.
init_one_syrope_model builds each Syrope section's working curve and
solves the static start through init_one_model with a secant EA per
element. On a composite line the tension varies along a sagging Syrope
section, so each Syrope element takes the secant of its rest curve at its
own tension: every element starts on its curve, its slow strain at rest.
One secant per section left the elements away from the mean off the curve,
and their slow strains moved the fairlead tension by 1.4e-5 within 2 s;
now a still run keeps it to the printed digits. The tension update stays a
contraction where the chains' weight and the geometry set the tension. The
line's sections split into runs of one secant for the model build (the
mesh is unchanged), the chains keep their BA damping, and a tension above
the OWC table or a slack Syrope element stops with a named error. A
single-section line keeps its secant from the mean strain: all 52 example
decks are bit-identical.
SYROPE IC applies to every Syrope section of a line; the Python deck
reader accepts it on any line with a Syrope section. New test
syrope_composite (every polyester element on its OWC to 2e-11, the
equilibrium start, the Tmax0 working curve, the named refusals) and
example composite_chain_syrope_chain.dat on a moving vessel. The driver
format, the rope guide and the tutorial no longer describe the current,
waves and bathymetry the Syrope hydrodynamics now carry as refused.