Repository navigation
fix: findings of the 0.4.0 end-to-end validation in OpenFAST and FAST.Farm - #83
Merged
Merged
Conversation
…es runs A standalone TURBINES deck that mixes EI = 0 lines and finite-EI cables (a power cable shared by two turbines beside their chain legs) stopped with the internal message "no farm init was given (pass n_turbines + turbine_ref_pos)": the driver called the aggregate without the deck's TURBINES context. The driver now passes deck_turbines to CD_AGG_Init_From_Deck. The aggregate's parse then places the Turbine<J> points from the TURBINES rows as the single-route parse does, a finite-EI end on a Turbine<J> point starts turned by its turbine's PtfmInit rotation (turbine_end_dcm), and the per-turbine motionFile records move the points and turn each moving column's frames with its own turbine (col_turb). A Turbine<J> point in a run without a farm is refused by point, naming FAST.Farm and the TURBINES section. Gate 9 (ctest mixed_route_turbines): a two-turbine deck (PtfmInit offsets and yaws, heave and roll records) with a clamped cable restrained in torsion and two chains, against its cable-only and legs-only decks. The chains agree bit for bit; the cable agrees within the coupled Newton controls (4.2e-3 of the range) and, marched through the library with the single-cable route's controls, to 0.44 printed units. With the coupled controls given to the single-cable route, a trial wrote the mixed run's cable byte for byte. The gate fails on the old code (the mixed deck does not run). The IEA 15 MW FAST.Farm twin (60 s) reproduces the split decks to 3.2e-6 of the channel maxima and FAST.Farm to 2.3e-5. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
A coupled deck with both bodies (Rigid6 or Point3) and rods stops at init, in OpenFAST CompMooring = 5, FAST.Farm and the C API: the aggregate step advances either the body march or the rod march. MoorDyn-F runs such a deck, and the OpenFAST and capability pages listed coupled bodies and coupled rods without the limit; the message spoke of "one body/rod family per step". The message now says what the coupled route takes (bodies or rods; a rod fixed to a body counts as a rod, a zero-length rod is a point) and where such a deck runs (MoorDyn CompMooring = 3, or the standalone multibody march for a deck without CoupledPinned objects). doc/openfast.rst, doc/coupling.rst, doc/capabilities.rst and doc/troubleshooting.rst state the limit, and the Python validator refuses the deck with caller_driven=True. The lift itself is left for a later release. Gates: test_deck_native_parity (the validator refuses a buoy with a body-fixed rod for the coupled route, accepts it standalone, and accepts the buoy alone and with a zero-length rod) and test_objects (the C API refusal names the limit and the routes; it fails on the old message). Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…on Windows GNU FAST.Farm.exe built through integration/openfast with the GNU compilers on Windows has MinGW's 2 MiB stack reserve and stops with 0xC00000FD (stack overflow) while it initialises the turbines of a farm, before any output. The release does not ship FAST.Farm.exe, so FAST.Farm users always take this route. The new patch 0022 (numbered after 0021 of the version-stamp branch) links openfast.exe and FAST.Farm.exe with a 256 MiB reserve on WIN32 with the GNU compilers (-Wl,--stack,268435456, the CableDyn driver's reserve); the Visual Studio projects of the release keep their own. integration/openfast/README.md and NOTICE name it, and tests/test_documentation.py checks the patch. Checked on the two-turbine IEA 15 MW shared-mooring farm: the patched build has the 256 MiB reserve; the same FAST.Farm.exe with its header set back to 2 MiB stops with 0xC00000FD after "Running ElastoDyn", and with the reserve it runs to normal termination. The full series, 0022 included, applies to a clean OpenFAST 2895884d2 checkout, and 0021 applies on top of it. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
From the OpenFAST/FAST.Farm end-to-end validation of 0.4.0: - OpenFAST printed "SeaState wave/current kinematics drive the mooring hydro" also for a WaterKin file with WaveKinMod 0 and CurrentMod 0, which correctly gives still water; it is printed only when a SeaState component is taken. - The body/rod static start reported "largest move 0.000E+00 m" for a pinned rod that had turned (only translations were counted); it now reports the move of every point the objects carry and the largest turn of a body or rod. - A mixed or FAST.Farm deck refused for a deck current said "Remove the current OPTION" also when the current came from the CurrentMod 1 table of its WaterKin file; the refusal names the declaring input. - The torsion note reported the pretwist as the imposed twist, leaving out the PtfmInit/TURBINES turn of the end frames; it reports the line's total twist Twist<L> beside Pretwist(B) - Pretwist(A). - In FAST.Farm the time-step messages called DT_Mooring the glue DT. Test needles updated and added (driver_cli_torsion_nmodes, mixed_route_torsion, openfast_aggregate, msg_pinned_rod_turn). Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Findings of the 0.4.0 end-to-end validation in OpenFAST and FAST.Farm (besides E2E-D2, fixed by #81).
TURBINESdeck ofEI = 0and finite-EI lines runs. A power cable shared by two turbines beside their chain legs stopped with the internal message "no farm init was given (pass n_turbines + turbine_ref_pos)": the driver called the aggregate without the deck'sTURBINEScontext. It now passes it; theTurbine<J>points are placed from theTURBINESrows, a finite-EI end on aTurbine<J>point starts turned by its turbine'sPtfmInit, and each turbine'smotionFilemoves its points and turns its columns' frames. ATurbine<J>point in a run without a farm is refused by point.doc/openfast.rst,doc/coupling.rst,doc/capabilities.rstanddoc/troubleshooting.rststate it, and the Python validator refuses the deck caller-driven.FAST.Farm.exeof the CMake route gets a stack reserve on Windows GNU. With MinGW's 2 MiB default it stopped with0xC00000FDwhile initialising a farm's turbines. New patch0022linksopenfast.exeandFAST.Farm.exewith a 256 MiB reserve on WIN32 with the GNU compilers; the release's Visual Studio projects keep their own.CurrentMod 1table orcurrentOPTION); the torsion note reports the total twistTwist<L>besidePretwist(B) - Pretwist(A); FAST.Farm namesDT_Mooring, not a glueDT.Checks
Prescottand the default).-fcheck=all) on the 38 touched tests.PrescottandHaswellkernels: same exit codes, no fallback, stall or relaxed-tolerance note.driver_cli_torsion_nmodes,mixed_route_torsion,openfast_aggregate,msg_pinned_rod_turn).-W.