Skip to content

fix(hydro): an EI = 0 line above the surface carries its dry weight without a seabed - #84

Merged
SMI-Lab-Inha merged 1 commit into
devfrom
fix/no-seabed-surface
Nov 3, 2026
Merged

SMI-Lab-Inha merged 1 commit into
devfrom
fix/no-seabed-surface

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

Summary

On a deck without a seabed (no WtrDpth or bathymetry), an EI = 0 line was built without the still-water level. It was modelled fully submerged up to an end above the surface (submerged weight, drag and added mass), with a warning. The same line on a deck with a seabed, and a finite-EI line with or without one, took its dry weight above the surface.

  • A 42 m chain hung wholly above the surface carried 13 % less than its weight in air.
  • A chain sagging through the surface differed by 7.7 % from the same deck with a seabed far below.
  • A 50 t Connect clump hung above the surface started 2 cm off.

The line model (init_one_model), the static-only solve and the force balance of points and objects (prepare_line) now take the still-water level on every deck. On the reproducers, the no-seabed decks give exactly the seabed decks' results, and the clump holds its start. The warning is gone. Lines wholly below the surface are unchanged.

Checks

  • New test no_seabed_surface, 4 gates, every one failing on the old code:
    1. weight in air to 1.3e-9 (the output's 8 digits);
    2. no seabed against seabed, identical;
    3. clump start identical, no move over 2 s;
    4. no warning.
  • ctest 359 of 359; the touched tests on the Prescott, Haswell and Zen kernels; Debug build (-fcheck=all) on the touched tests with their own timeouts.
  • Example A/B 53 of 53 identical, including the no-seabed connect_weighted_point.
  • pre-commit, Sphinx -W.

…ithout a seabed

On a deck without WtrDpth or a bathymetry an EI = 0 line was built
without the still-water level: it was modelled fully submerged
(submerged weight, drag and added mass) up to an end above the surface,
with a warning, while the same line with a seabed, and a finite-EI line
with or without one, took its dry weight above the surface. A 42 m chain
hung wholly above the surface carried 13 % less than its weight in air.

The line model, the static-only solve and the force balance of points
and objects now take the still-water level on every deck; the warning
is gone. Lines wholly below the surface are unchanged (53 of 53
examples identical).

New test no_seabed_surface: a chain wholly above the surface carries
its weight in air, a chain sagging through the surface and a Connect
clump hung above it agree with the same decks with a seabed, the clump
holds its start, and no warning is printed; every gate fails on the
old code.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T10:07:00.511142Z cb354f8 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35608629 | 📁 Comparing cb354f8 against latest (fd1936d)

  🔍 Preview build  

33 files changed · ± 33 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: cb354f87b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 43810b5 into dev Nov 3, 2026
21 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/no-seabed-surface branch November 3, 2026 11:57
@SMI-Lab-Inha SMI-Lab-Inha mentioned this pull request Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant