Repository navigation
fix(openfast): linearise from double-precision loads in a single-precision OpenFAST - #85
Merged
Merged
Conversation
…ision OpenFAST The release openfast.exe is OpenFAST's Visual Studio Release configuration, single precision (ReKi = 4 bytes). The linearisation of the line dynamics differenced the ReKi output mesh over a 1 um position step; with fairlead loads of a few MN the 7-digit mesh cannot resolve the change, and the reduced mooring stiffness of the IEA-15 MW UMaine chains read 3.2e3 N/m in surge against MoorDyn-F's 7.7e4 N/m (symmetry error 1.18), with the line modes, A and B unaffected. The gfortran CMake builds this was validated with are double precision. lin_eval now keeps its coupled loads and deck channels in double precision, and the two linearisation Jacobians pack those (pack_lin_outputs) in place of the ReKi mesh. A double-precision build packs the same values. RELEASE.md asks for the linearisation check on the release executable as well. Checked with gfortran OpenFAST builds at DOUBLE_PRECISION=OFF: before, openfast_lin_ab.py fails as the release executable does; after, it passes (surge 7.721e4 vs 7.716e4 N/m, symmetry 7e-6, fairlead blocks to 1.1e-3, the mixed cable deck's point stiffness to its static solves to 1e-4). Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release
openfast.exeis built as OpenFAST's Visual StudioReleaseconfiguration, which is single precision (ReKi= 4 bytes). The 0.4.0 linearisation of the line dynamics differenced theReKioutput mesh over a 1 µm position step. With fairlead loads of a few MN, the 7-digit mesh cannot resolve the change, so the release executable linearised the mooring wrongly:AandBand the line modes were unaffected;CandDwere off by 4e-4.The gfortran CMake builds this feature was validated with are double precision.
lin_evalnow keeps its coupled loads and deck channels in double precision, and the two linearisation Jacobians pack those (pack_lin_outputs) in place of theReKimesh. A double-precision build packs the same values.Checks
validation/scripts/openfast_lin_ab.pyon the IEA-15 MW UMaine twin decks plus the mixed cable deck:openfast.exe(Intel, single)DOUBLE_PRECISION=OFF, beforeDOUBLE_PRECISION=OFF, afterRELEASE.mdnow asks for the linearisation check on the release executable too.-W.