Repository navigation
fix(capi): name the real scope of the aggregate refusals - #87
Conversation
CableDyn_UpdatePointFluidFields and CableDyn_CalcOutputDerivatives refused a deck on the coupled aggregate by naming bodies and rods only, so a deck with a finite-EI line and neither read as a wrong diagnosis. Both messages now name finite-EI lines, bodies and rods. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
CableDyn_UpdatePointFluidFieldsandCableDyn_CalcOutputDerivativesrefuse a deck on the coupled aggregate, but their messages named bodies and rods only. A deck with a finite-EI line runs on the same route, so it got a diagnosis of objects it does not have. Both messages now name finite-EI lines, bodies and rods.No solver behaviour changes.
Checks
python/tests/test_native_model.py: 21 passed against a fresh Release build; the refusal test now matches the new wording.