Skip to content

fix(capi): name the real scope of the aggregate refusals - #87

Merged
SMI-Lab-Inha merged 2 commits into
devfrom
fix/capi-aggregate-messages
Nov 7, 2026
Merged

SMI-Lab-Inha merged 2 commits into
devfrom
fix/capi-aggregate-messages

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

Summary

CableDyn_UpdatePointFluidFields and CableDyn_CalcOutputDerivatives refuse a deck on the coupled aggregate, but their messages named bodies and rods only. A deck with a finite-EI line runs on the same route, so it got a diagnosis of objects it does not have. Both messages now name finite-EI lines, bodies and rods.

No solver behaviour changes.

Checks

  • python/tests/test_native_model.py: 21 passed against a fresh Release build; the refusal test now matches the new wording.

CableDyn_UpdatePointFluidFields and CableDyn_CalcOutputDerivatives
refused a deck on the coupled aggregate by naming bodies and rods only,
so a deck with a finite-EI line and neither read as a wrong diagnosis.
Both messages now name finite-EI lines, bodies and rods.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T10:22:10.848415Z b1fb050 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: f454e4d5a2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@read-the-docs-community

read-the-docs-community Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35717181 | 📁 Comparing b1fb050 against latest (3d04008)

  🔍 Preview build  

1 file changed
± changelog.html

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: b1fb050a98

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 4a65052 into dev Nov 7, 2026
15 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/capi-aggregate-messages branch November 7, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant