Repository navigation
feat(capi): step decks in moving water in-process - #88
Conversation
On a deck with finite-EI lines, bodies or rods the C API and Python ran in still water only: a deck current was refused, and no call reached the line nodes. - A steady deck current (current, WaterKin CurrentMod 1, MoorDyn-C Currents 1) is marched in-process, in the static start and in every step, also from host start positions. - A host can supply the ambient fluid at every node instead (ABI 1.4): CableDyn_SetHostFluid before the initialization, then CableDyn_NFluidNodes, CableDyn_GetFluidNodePositions and CableDyn_UpdateFluidFields; in Python set_host_fluid, n_fluid_nodes, fluid_node_positions and update_fluid_fields. A steady deck current then sets the static start only, as a host's current does in OpenFAST. - The field follows the standalone march and OpenFAST: sampled at t + dt at the step-start nodes and held over the step. The first field, at t = 0, sets the start acceleration, on EI = 0 lines too, and a step without a field is refused. Stepped in current and regular waves, a cable matches the standalone driver to the digits of its output (NRMSE 2e-7), with a stiffener and as-laid seabed friction too; SaveState and RestoreState carry the field. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b733ee3ce9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
On a deck with finite-EI lines, bodies or rods, the C API and Python ran in still water only: a deck current was refused and no call reached the line nodes. This adds moving water to in-process stepping (ABI 1.4).
current, WaterKinCurrentMod 1table or MoorDyn-CCurrents 1profile is marched in-process, in the static start and in every step, also from host start positions.CableDyn_SetHostFluidbefore the initialization, thenCableDyn_NFluidNodes,CableDyn_GetFluidNodePositionsandCableDyn_UpdateFluidFields(Pythonset_host_fluid,n_fluid_nodes,fluid_node_positions,update_fluid_fields). A steady deck current then sets the static start only, and the host's field is the whole water of the march.t + dtat the step-start nodes and held over the step. The first field, att = 0, sets the start acceleration, onEI = 0lines too. A step without a field is refused.SaveState/RestoreStatecarry the field.examples/python/step_in_moving_water.pyis a complete loop.OpenFAST and the standalone driver are unchanged: the new aggregate arguments are optional and they pass none of them.
Checks
Stepped in current and regular waves against the standalone driver on the same motion:
EI = 0, host fieldThese are at the digits of the driver's output. A step at 301 nodes takes 3.5 ms including
CalcOutput, plus 0.3 ms for the host's field.OPENBLAS_CORETYPE=Prescott; pytest passes; no new compiler warnings.