Repository navigation
feat(openfast): range graphs in coupled runs and a SeaState depth-grid note - #90
Merged
Merged
Conversation
The LINES Outputs flag r and RangeStart now work in OpenFAST as on the standalone routes: <RootName>.CD.Line<L>.range.out holds the minimum, maximum and mean at every node over the rows of .CD.out in the window. The module samples the aggregate once per committed mooring step, at t = 0 and in CD_UpdateStates after the commit, so an intermediate supercycle call, a CalcOutput probe and an abandoned step add nothing. A retried step takes its sample back: CD_AGG_Snapshot/Restore carry the accumulators, and on the glue's state copy the rebuild reloads them from the OtherState. The accumulators are double precision on every host build and ride the checkpoint (OtherState range_state), so a restart writes the file of an uninterrupted run. This changes the checkpoint format. The file is written at the end of a run that reaches TMax. A run that stops earlier says so and writes none, and the file of an earlier run goes at initialisation, so nothing stale stands in for the result. A range file that cannot be completed is now removed on every route. RangeStart is held against the host's run time: a coupled deck needs no TMax, and a deck TMax neither clamps nor bounds the window there. A FAST.Farm shared mooring and the C API refuse the flag by name, the C API now also on an EI = 0 deck, which it accepted without writing a file. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
…grid SeaState's depth levels are cosine-spaced, so the grid is coarsest at the bottom: the deepest interval is Z_Depth*sin(pi/(2*(NZ - 1))), about 22 m at 200 m depth with NZ = 15, and the field is linear across it down to the seabed, unlike a deck depth table. The OpenFAST module now says so at initialisation when that interval exceeds 5 % of the depth (NZ below 33) and a line lies in it, with the interval, the nodes in it and the NZ that brings it under 5 %. For the 1/7-power current the linear ramp is up to 62 % low whatever the interval is, so the interval alone sets how much of the column carries the difference: the depth integral lacks 3/7*(H/D)^(8/7), 1.4 % at the threshold and 3.5 % at NZ = 15. The note applies only when waves or a current come from SeaState and the grid reaches the seabed; a shorter grid has the out-of-grid warning. It is printed once, at initialisation, and changes no result. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Range graphs in coupled OpenFAST runs. The LINES flag
rwas refused in OpenFAST. A single-turbine coupled run now writes<RootName>.CD.Line<L>.range.outfromRangeStart, as the standalone route does..CD.out; supercycle calls,CalcOutputprobes and retried steps add nothing.ReKiis.TMax. A stale file is removed at the start, and a range file that cannot be completed is deleted on any route.EI = 0route used to ignore it silently.RangeStartis accepted in coupled decks withoutTMax.Checkpoint format: OtherState gains the range state, so checkpoints from earlier builds cannot be restarted.
SeaState depth grid note. The deepest interval of SeaState's cosine grid is coarse, and the current falls linearly across it, so near the seabed the field differs from a deck depth table.
doc/openfast.rstsays so, and an initialisation note states the interval when it exceeds 5 % of the depth and a line reaches into it (NZbelow 33).Checks
.CD.out: worst relative difference 4.2e-7, its print rounding, swept overdtM= 1, 2 and 4DTand five window starts, in double and single precision..CD.outand.outidentical to 0.4.0, continuous and after a restart..CD.out.OPENBLAS_CORETYPE=Prescottand in Debug; pytest passes.The CHANGELOG entry lands with the release batch.