Repository navigation
fix(deck): run a static check without dtM - #91
Merged
Merged
Conversation
A standalone deck with TMax 0 and no dtM stopped with a message about a dynamic run. The check marches no step, so it needs no time step: the parser now builds such a deck on a nominal step that no result depends on, on every standalone route (single line, finite-EI, mixed aggregate, multibody, deck current, waves, motion records). A record is read for its t = 0 row only, whatever its step. The nominal step is not reported as the deck's own, so a caller that marches the deck still needs dtM. The pointer of a deck without TMax now says to give TMax = 0, and the Python validator follows the same rule. A mixed deck that marches no step no longer prints the dtM advisory. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A deck with
TMax 0and nodtMstopped with "dynamic run requires both dtM and TMax options", which describes a dynamic run on a static check. A static check needs no time step, so it now runs on every standalone route.CD_Deck_Query_dtMandCD_Init_Deck_Systemdo not report that step as the deck's own, so no caller can march on it.t = 0row only.TMaxnow says "give TMax = 0".python/cabledyn/deck_file.pymirrors the rule.dtMon finite-EI, body and rod decks, becauseCableDyn_Stepmarches on it, and says so.Deck syntax:
TMax 0no longer needsdtM.Checks
TMax 0with and withoutdtMgive byte-identical files and identical messages. The 20 decks with no clock match0.05 dtMplusTMax 0byte for byte.vesselMotionandmotionFileroutes match with and withoutdtM.TMax, old driver against new: files and messages identical on 55 of 58 decks; the other 3 refuse standalone on both drivers and differ only in the hint text.static_checkhas 15 failures on the old driver.OPENBLAS_CORETYPE=Prescott; Debug suite 359 of 359; pytest passes; no new compiler warnings.The CHANGELOG entry lands with the release batch.