Skip to content

fix(deck): run a static check without dtM - #91

Merged
SMI-Lab-Inha merged 2 commits into
devfrom
fix/static-check-without-dtm
Nov 7, 2026
Merged

SMI-Lab-Inha merged 2 commits into
devfrom
fix/static-check-without-dtm

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

Summary

A deck with TMax 0 and no dtM stopped with "dynamic run requires both dtM and TMax options", which describes a dynamic run on a static check. A static check needs no time step, so it now runs on every standalone route.

  • The parser builds the deck on a nominal step and marks it as a static-check clock. CD_Deck_Query_dtM and CD_Init_Deck_System do not report that step as the deck's own, so no caller can march on it.
  • At this clock a motion record is read for its t = 0 row only.
  • The hint for a deck without TMax now says "give TMax = 0". python/cabledyn/deck_file.py mirrors the rule.
  • The C API keeps needing dtM on finite-EI, body and rod decks, because CableDyn_Step marches on it, and says so.

Deck syntax: TMax 0 no longer needs dtM.

Checks

  • All 34 shipped decks with a clock: TMax 0 with and without dtM give byte-identical files and identical messages. The 20 decks with no clock match 0.05 dtM plus TMax 0 byte for byte.
  • Mixed, mixed with current, vesselMotion and motionFile routes match with and without dtM.
  • Positive TMax, old driver against new: files and messages identical on 55 of 58 decks; the other 3 refuse standalone on both drivers and differ only in the hint text.
  • static_check has 15 failures on the old driver.
  • CTest 359 of 359 on the default kernel and with OPENBLAS_CORETYPE=Prescott; Debug suite 359 of 359; pytest passes; no new compiler warnings.

The CHANGELOG entry lands with the release batch.

A standalone deck with TMax 0 and no dtM stopped with a message about a
dynamic run. The check marches no step, so it needs no time step: the
parser now builds such a deck on a nominal step that no result depends
on, on every standalone route (single line, finite-EI, mixed aggregate,
multibody, deck current, waves, motion records). A record is read for
its t = 0 row only, whatever its step.

The nominal step is not reported as the deck's own, so a caller that
marches the deck still needs dtM. The pointer of a deck without TMax now
says to give TMax = 0, and the Python validator follows the same rule.

A mixed deck that marches no step no longer prints the dtM advisory.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T12:35:27.199024Z 2e65501 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35718684 | 📁 Comparing 2e65501 against latest (3d04008)

  🔍 Preview build  

3 files changed
± file_formats.html
± options.html
± troubleshooting.html

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 2e655018ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit b069946 into dev Nov 7, 2026
21 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/static-check-without-dtm branch November 7, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant