Skip to content

feat(python): read the modal output file - #93

Merged
SMI-Lab-Inha merged 2 commits into
devfrom
fix/read-output-modes
Nov 7, 2026
Merged

SMI-Lab-Inha merged 2 commits into
devfrom
fix/read-output-modes

Conversation

@SMI-Lab-Inha

Copy link
Copy Markdown
Owner

Summary

read_output could not read the two-table <root>.modes.out file. It now returns NaturalModes, the frequency table, with .shapes holding a ModeShapes table; both subclass OutputTable. DriverResult gains modes_output and read_modes().

A file with only a frequency table, which the driver never writes, is refused as truncated.

Checks

  • On dev a real file fails with expected 5 fields, got 9.
  • 25 tests on real driver files: EI = 0 and finite-EI lines, several lines, torsion on one of two lines, lines with no free nodes and empty tables, plus physics checks (a string frequency within 2 %, the 47.1 s first period of chain_modes.dat).
  • lazy_wave_modes (1025 nodes) and torsion_lazy_wave_modes.dat read correctly.
  • CTest 359 of 359 on the default kernel and with OPENBLAS_CORETYPE=Prescott.

The CHANGELOG entry lands with the release batch.

read_output stopped at the second table of <root>.modes.out with a field
count error. It now reads the frequency and mode-shape tables into a
NaturalModes table, whose shapes attribute is a ModeShapes table, with
accessors by line and mode. Twist columns, negative eigenvalues and lines
without free nodes read as the driver writes them. A file without a
mode-shape table, or whose tables do not hold the same modes, is refused.

DriverResult gains modes_output and read_modes.

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T13:59:58.668284Z ae1204f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@read-the-docs-community

read-the-docs-community Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Documentation build overview

📚 CableDyn | 🛠️ Build #35719527 | 📁 Comparing ae1204f against latest (3d04008)

  🔍 Preview build  

5 files changed · ± 5 modified

± Modified

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 618db0910c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
@SMI-Lab-Inha

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: ae1204f9d3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SMI-Lab-Inha
SMI-Lab-Inha merged commit 22ce413 into dev Nov 7, 2026
21 checks passed
@SMI-Lab-Inha
SMI-Lab-Inha deleted the fix/read-output-modes branch November 7, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant