Repository navigation
feat(python): read the modal output file - #93
Conversation
read_output stopped at the second table of <root>.modes.out with a field count error. It now reads the frequency and mode-shape tables into a NaturalModes table, whose shapes attribute is a ModeShapes table, with accessors by line and mode. Twist columns, negative eigenvalues and lines without free nodes read as the driver writes them. A file without a mode-shape table, or whose tables do not hold the same modes, is refused. DriverResult gains modes_output and read_modes. Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
read_outputcould not read the two-table<root>.modes.outfile. It now returnsNaturalModes, the frequency table, with.shapesholding aModeShapestable; both subclassOutputTable.DriverResultgainsmodes_outputandread_modes().A file with only a frequency table, which the driver never writes, is refused as truncated.
Checks
deva real file fails withexpected 5 fields, got 9.EI = 0and finite-EI lines, several lines, torsion on one of two lines, lines with no free nodes and empty tables, plus physics checks (a string frequency within 2 %, the 47.1 s first period ofchain_modes.dat).lazy_wave_modes(1025 nodes) andtorsion_lazy_wave_modes.datread correctly.OPENBLAS_CORETYPE=Prescott.The CHANGELOG entry lands with the release batch.