Repository navigation
ci: run the suite and the examples on the Prescott kernel - #94
Merged
Merged
Conversation
A result that depends on the BLAS kernel passes on the runners' own AVX2
and AVX-512 kernels. Add a Linux Release job, separate from the required
ones, that runs the full CTest with OPENBLAS_CORETYPE=Prescott and then
every shipped example deck through tests/check_example_fallbacks.py.
The scan fails on a non-zero exit, a timeout and a fallback note, and lists
the offending decks. It matches the wording the solver prints for an
equilibrium accepted above the requested tolerance ("residual floor above"),
which does not contain "looser tolerance".
OPENBLAS_CORETYPE is ignored by an OpenBLAS without dynamic architecture
support and an unknown name falls back to detection, so the job first has
OpenBLAS name its kernel (OPENBLAS_VERBOSE=2) and stops on any other kernel
or none. example_fallback_scan proves the scan fails where it should.
Signed-off-by: Jae Hoon Seo <jaehoon.seo@inha.ac.kr>
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Linux job,
round-off kernel (conda gfortran, ubuntu-latest, Prescott), runs the full CTest on the Prescott OpenBLAS kernel, then runs every shipped example deck and fails on a fallback note where a deck should converge cleanly. A test that passes on one kernel and fails on another is a bug.tests/check_example_fallbacks.pylists offending decks and works on Linux and Windows;example_fallback_scantests the scan itself.Core:line and fails if the requested kernel did not take effect. The conda-forge package the CI uses is aDYNAMIC_ARCHbuild that honoursOPENBLAS_CORETYPE.Checks
The CHANGELOG entry lands with the release batch.