fix(manifest): store full 40-char SHAs (PR #81 static review)

Static review on PR #81 caught a real correctness bug in the
manifest pinning: I stored 12-char abbreviated SHAs in
``external/MANIFEST.toml`` (e.g. ``dd5feaaaa500``), but
``scripts/verify_external_data.py:118-126`` compares
``spec["sha"]`` to ``git rev-parse HEAD`` with exact string
equality. ``git rev-parse HEAD`` returns the full 40-char object
ID, so every populated git-backed entry would FAIL verification
even when checked out to the intended commit. The
``Generate verifier report`` step in ``.github/workflows/
validation.yml`` would have failed on every workflow run, which
defeats the entire 1.8.1 pinning effort.

Fix
---

- Replace each 12-char abbreviation in ``external/MANIFEST.toml``
  with the full 40-char SHA (read again from the same local
  clones, this time without ``rev-parse --short``).
- Update the ``git checkout`` commands in ``.github/workflows/
  validation.yml`` to use the full SHAs so the workflow and the
  manifest are byte-identical references.

Verified locally
----------------

``python scripts/verify_external_data.py --strict`` now reports
``9 PASS, 0 WARN, 0 SKIP, 0 FAIL`` (previously was
``1 PASS, 8 WARN, 0 SKIP, 0 FAIL`` in 1.8.0 with TBD pins; the
abbreviated-SHA version of 1.8.1 would have flipped that to
``8 FAIL`` — exactly the contradiction the static-review pass
flagged).

Author: SMI-Lab-Inha

.github/workflows/validation.yml

@@ -84,27 +84,32 @@ jobs:
       # ---------------------------------------------------------------
 
       - name: Clone OpenFAST r-test at manifest-pinned SHA
-        # 1.8.1 manifest pin: dd5feaaaa500 (NREL 5MW land / monopile
-        # / OC3 spar regression decks).
+        # 1.8.1 manifest pin (NREL 5MW land / monopile / OC3 spar
+        # regression decks). Full 40-char SHA matches what
+        # ``scripts/verify_external_data.py`` compares ``git rev-parse
+        # HEAD`` against — abbreviated SHAs in the manifest would
+        # silently FAIL the verifier (static review on PR #81).
         run: |
           git clone https://github.com/OpenFAST/r-test.git \
             external/OpenFAST_files/r-test
-          git -C external/OpenFAST_files/r-test checkout dd5feaaaa500
+          git -C external/OpenFAST_files/r-test \
+            checkout dd5feaaaa500ba7283140107806300d551cff0a7
 
       - name: Clone IEA-3.4-130-RWT at manifest-pinned SHA
-        # 1.8.1 manifest pin: 824f8d65196f.
         run: |
           git clone https://github.com/IEAWindTask37/IEA-3.4-130-RWT.git \
             external/OpenFAST_files/IEA-3.4-130-RWT
-          git -C external/OpenFAST_files/IEA-3.4-130-RWT checkout 824f8d65196f
+          git -C external/OpenFAST_files/IEA-3.4-130-RWT \
+            checkout 824f8d65196f9f84ee66df5e58e3a48a70a8f0c5
 
       - name: Clone IEA-15-240-RWT at manifest-pinned SHA
-        # 1.8.1 manifest pin: 86d51c8a1ee6 (v1.1 tower redesign —
-        # Allen 2020 free-decay reference).
+        # 1.8.1 manifest pin (v1.1 tower redesign — Allen 2020
+        # free-decay reference).
         run: |
           git clone https://github.com/IEAWindTask37/IEA-15-240-RWT.git \
             external/OpenFAST_files/IEA-15-240-RWT
-          git -C external/OpenFAST_files/IEA-15-240-RWT checkout 86d51c8a1ee6
+          git -C external/OpenFAST_files/IEA-15-240-RWT \
+            checkout 86d51c8a1ee65be4f3686087a5c443c0b57e5cfb
 
       # ---------------------------------------------------------------
       # Run the verifier + integration suite.

external/MANIFEST.toml

@@ -40,7 +40,7 @@ maintainer = "Jae Hoon Seo <jaehoon.seo@inha.ac.kr>"
 # NREL 5MW land + monopile + OC3 Hywind integration tests.
 [clone.openfast_r-test]
 repo = "https://github.com/OpenFAST/r-test.git"
-sha = "dd5feaaaa500"                     # pinned 1.8.1 (was TBD in 1.8.0)
+sha = "dd5feaaaa500ba7283140107806300d551cff0a7"  # pinned 1.8.1
 relative_path = "external/OpenFAST_files/r-test"
 fetch_at = "shallow"                     # ``git clone --depth=1`` is enough
 hashes = { }                             # populated by --update; see script docstring
@@ -55,29 +55,29 @@ hashes = { }                             # populated by --update; see script doc
 
 [clone.iea_3_4_130]
 repo = "https://github.com/IEAWindTask37/IEA-3.4-130-RWT.git"
-sha = "824f8d65196f"                     # pinned 1.8.1 (was TBD in 1.8.0)
+sha = "824f8d65196f9f84ee66df5e58e3a48a70a8f0c5"  # pinned 1.8.1
 relative_path = "external/OpenFAST_files/IEA-3.4-130-RWT"
 fetch_at = "shallow"
 hashes = { }
 
 [clone.iea_10_198]
 repo = "https://github.com/IEAWindTask37/IEA-10.0-198-RWT.git"
-sha = "350cf06f5db9"                     # pinned 1.8.1 (was TBD in 1.8.0)
+sha = "350cf06f5db9cec12bcd73c2b174a5d9642958d8"  # pinned 1.8.1
 relative_path = "external/OpenFAST_files/IEA-10.0-198-RWT"
 fetch_at = "shallow"
 hashes = { }
 
 [clone.iea_15_240]
 repo = "https://github.com/IEAWindTask37/IEA-15-240-RWT.git"
-sha = "86d51c8a1ee6"                     # pinned 1.8.1 (was TBD in 1.8.0)
+sha = "86d51c8a1ee65be4f3686087a5c443c0b57e5cfb"  # pinned 1.8.1
 relative_path = "external/OpenFAST_files/IEA-15-240-RWT"
 fetch_at = "shallow"
 notes = "v1.1 tower redesign is the pinned target — Allen 2020 free-decay reference."
 hashes = { }
 
 [clone.iea_22_280]
 repo = "https://github.com/IEAWindTask37/IEA-22-280-RWT.git"
-sha = "57979ece000e"                     # pinned 1.8.1 (was TBD in 1.8.0)
+sha = "57979ece000ec5cc394962b964805ddf20e387be"  # pinned 1.8.1
 relative_path = "external/OpenFAST_files/IEA-22-280-RWT"
 fetch_at = "shallow"
 hashes = { }
@@ -87,7 +87,7 @@ hashes = { }
 # ---------------------------------------------------------------------------
 [clone.wisdem]
 repo = "https://github.com/WISDEM/WISDEM.git"
-sha = "40a68818e7f2"                     # pinned 1.8.1 (was TBD in 1.8.0)
+sha = "40a68818e7f225065150786daff8d33f7e05d850"  # pinned 1.8.1
 relative_path = "external/OpenFAST_files/WISDEM"
 fetch_at = "shallow"
 hashes = { }
@@ -111,15 +111,15 @@ hashes = { }                             # populated by --update on a maintainer
 # ---------------------------------------------------------------------------
 [clone.moorpy]
 repo = "https://github.com/NREL/MoorPy.git"
-sha = "1fb29f8eca26"                     # pinned 1.8.1 (was TBD in 1.8.0)
+sha = "1fb29f8eca2618543b2df7056adfdfce0265737b"  # pinned 1.8.1
 relative_path = "external/MoorPy"
 fetch_at = "shallow"
 notes = "Optional — used for cross-comparison against pybmodes.mooring on OC3 Hywind."
 hashes = { }
 
 [clone.raft]
 repo = "https://github.com/WISDEM/RAFT.git"
-sha = "a1e6a0a95326"                     # pinned 1.8.1 (was TBD in 1.8.0)
+sha = "a1e6a0a95326edaca713e031d9d06a5fd057d8fa"  # pinned 1.8.1
 relative_path = "external/RAFT"
 fetch_at = "shallow"
 notes = "Optional — used for the WindIO floating screening-tier cross-check."