Repository navigation
docs: add the conda-forge feedstock step to the release checklist - #147
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fca09a6cd5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| appeared a day after the PyPI release, comment | ||
| ``@conda-forge-admin, please update version`` on a feedstock issue | ||
| to trigger one. |
There was a problem hiding this comment.
If the automatic version PR does not appear, following this fallback by commenting on an existing issue will not trigger the documented update operation. The conda-forge infrastructure documentation specifies entering this phrase “in the title of an issue on a feedstock.” Instruct maintainers to open an issue with that title instead, so the recovery step actually requests the missing release PR.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Right, the admin bot reads that command from the issue title. Fixed in d010336: the fallback now says to open a new feedstock issue titled with the command, and notes that a comment won't trigger it.
|
@codex review |
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
conda-forge was still at 1.18.0 after 1.19.0 and 1.19.1 reached PyPI. conda-forge builds from conda-forge/pybmodes-feedstock, not from this repository, and the bot's
pybmodes v1.19.0PR there (#5) sat unmerged from 30 September, so 1.19.0 never reached the channel. The checklist ended at the GitHub release and never mentioned the feedstock.This adds a step 12 for it:
files.pythonhosted.org/packages/<hash>/path tied to the 1.19.0 file into notebooks: use shared pybmodes.plots.style.apply_style #5, which breaks on the next version.python_minmatchpyproject.toml, since the bot does not track new or raised dependencies.@conda-forge-admin, please update version.conda search -c conda-forge "pybmodes==X.Y.Z".It also gives "Post-release sanity" its own number (13; it was a second 11) and adds the fast-forward of
devtomainthere, now that development happens ondev.Sphinx builds clean with
-W. Documentation only, no code changes.