Add regression test for issue #165 (QF_UFBV incremental) - #654
Merged
Conversation
The QF_UFBV benchmark attached to issue #165 previously ran for hours; it now solves in under a second. Add it as a regression test to guard against both a re-hang and incorrect results. All check-sat verdicts match z3 4.16; the two get-value results are logically forced (identical across yices SAT engines and build modes), so the gold is portable.
|
coverage: 71.206% (+0.02%) from 71.191% — iss165-regression-test into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test for issue #165.
The attached QF_UFBV benchmark used to run for hours; on current
masterit solves in <1s. This locks that in astests/regress/iss165.smt2(run with--incremental), guarding against both a re-hang (60s harness timeout) and incorrect results (gold check).Notes:
check-satverdicts match z3 4.16.get-valueresults are logically forced — byte-identical across yices SAT engines and across debug/release — so the gold is portable across CI compilers/platforms.Closes #165.