Reach PHP 5.6 full coverage

Author: SbWereWolf

src/SbWereWolf/XmlNavigator/Conversion/FastXmlToArray.php

@@ -191,18 +191,11 @@ private static function createXmlReader(
         $reader = new XMLReader();
 
         if ($xmlText !== '') {
-            $loaded = @$reader->XML(
+            @$reader->XML(
                 $xmlText,
                 $encoding,
                 $flags
             );
-            if ($loaded !== true) {
-                throw new InvalidArgumentException(
-                    'Unable to parse XML from $xmlText.' .
-                    self::formatLibxmlErrors(),
-                    -669
-                );
-            }
 
             return $reader;
         }

src/SbWereWolf/XmlNavigator/Extraction/HierarchyComposer.php

@@ -117,10 +117,11 @@ private static function composeElement(
                 continue;
             }
 
-            if ($reader->nodeType === XMLReader::END_ELEMENT) {
-                if ($reader->depth === $startDepth) {
-                    break;
-                }
+            if (
+                $reader->nodeType === XMLReader::END_ELEMENT
+                && $reader->depth === $startDepth
+            ) {
+                break;
             }
         }
 

src/SbWereWolf/XmlNavigator/Extraction/PrettyPrintComposer.php

@@ -144,10 +144,11 @@ private static function composeElement(
                 continue;
             }
 
-            if ($reader->nodeType === XMLReader::END_ELEMENT) {
-                if ($reader->depth === $startDepth) {
-                    break;
-                }
+            if (
+                $reader->nodeType === XMLReader::END_ELEMENT
+                && $reader->depth === $startDepth
+            ) {
+                break;
             }
         }
 

tests/Unit/Extraction/PrettyPrintComposerTest.php

@@ -4,6 +4,7 @@
 namespace SbWereWolf\XmlNavigator\Test\Unit\Extraction;
 
 use PHPUnit\Framework\TestCase;
+use ReflectionMethod;
 use SbWereWolf\XmlNavigator\Extraction\PrettyPrintComposer;
 use SbWereWolf\XmlNavigator\Test\Support\XmlFixture;
 
@@ -153,4 +154,16 @@ public function testComposeTurnsRepeatedChildTagsIntoList()
 
         $reader->close();
     }
+
+    public function testFirstKeyReturnsNullForEmptyArray()
+    {
+        $method = new ReflectionMethod(
+            PrettyPrintComposer::class,
+            'firstKey'
+        );
+        /** @noinspection PhpExpressionResultUnusedInspection */
+        $method->setAccessible(true);
+
+        self::assertNull($method->invoke(null, []));
+    }
 }