Repository navigation
Forward ExtendedJumpArray properties to wrapped state (#57) - #669
Merged
ChrisRackauckas merged 2 commits intoSep 27, 2026
Merged
ChrisRackauckas merged 2 commits into
ChrisRackauckas merged 2 commits into
Conversation
VariableRateJump affect! functions with ArrayPartition state can use integrator.u.x instead of the integrator.u.u.x workaround (SciML#57). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Cursor Agent <noreply@cursor.com> Agent-Harness: Cursor Agent CLI 2026.09.26-dd393fe Agent-Model: auto Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/issue-backlog/jobs/fix-JumpProcesses.jl-57/log.txt on amdci2.julia.csail.mit.edu
Complete both ODE derivatives, use deterministic jump increments, assert trajectory results, dedupe propertynames, and document property forwarding. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Cursor Agent <noreply@cursor.com> Agent-Harness: Cursor Agent CLI 2026.09.26-dd393fe Agent-Model: auto Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/issue-backlog/jobs/fix-JumpProcesses.jl-57/log.txt on amdci2.julia.csail.mit.edu
ChrisRackauckas
marked this pull request as ready for review
September 27, 2026 14:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExtendedJumpArraynow overloadsgetproperty/propertynamesso unknown properties (e.g..xon anArrayPartitionstate) forward to the wrappedu, while.uand.jump_uremain real fields. This lets VariableRateJumpaffect!useintegrator.u.x[...]as in the issue #57 reporter example, instead of theintegrator.u.u.xworkaround. A regression test was added totest/extended_jump_array.jl(InterfaceI / defaultGROUP=All).Round-1 review follow-up: complete both ODE derivatives (zero the second partition), use a deterministic unit jump increment with a jump counter, assert exponential decay and accumulated jumps for
VR_FRM/VR_Direct, dedupepropertynames, and document the forwarding contract on the type.Failing before (src fix stashed)
Passing after
Verification (round 2 / review follow-up)
include("test/extended_jump_array.jl")→ExtendedJumpArray file | 51 51, exit 0 (keepseja.x === eja.u.xalias check; numerical trajectory asserts for both VR aggregators).GROUP=Allviajulia --project=<resolved test env> test/runtests.jl→COMMAND_EXIT_CODE=0;ExtendedJumpArray Tests | 51 51; all nonempty groups green through CPU SSA / explicit tau kernels.--inplaceon changed files (would rewrite large pre-existing regions); kept intentional edits and confirmed newgetproperty/propertynamesblocks are Runic-clean in isolation.typosclean.Test group run (default All) — tail
What I did NOT verify
setproperty!forwarding is needed for assigning whole partitions (reporter only mutates via.x[i])getpropertyoverloadWhat a reviewer should push back on
.x/ ArrayPartitionintegrator.u.ufor broadcasts should be updated further now that.xworksFixes #57
Please ignore this draft until reviewed by @ChrisRackauckas.
Risk assessment
ExtendedJumpArraygetsgetproperty/propertynamesthat forward names other thanuandjump_uto the wrapped state. This is additive: existing field access resolves exactly as before, and the hot path compiles to a plain field load with no allocations. No existing API changes.FieldError: ... no field x).@allocatedis 0 foreja.u,eja.jump_uandeja.x.🤖 Generated with Cursor Agent CLI 2026.09.26-dd393fe (model: auto), transcript /home/crackauc/sandbox/goals/issue-backlog/jobs/fix-JumpProcesses.jl-57/log.txt on amdci2.julia.csail.mit.edu
Risk assessment and review coordination by 🤖 Claude Code (model: claude-opus-5-5[1m]), https://claude.ai/code/session_01NdFVhANTF4nepTbqYxjfRP
Risk assessment
ExtendedJumpArray, which is exported and isintegrator.ufor every VariableRateJump problem with an ODE/SDE. Reading.uand.jump_uworks exactly as before. Any other property name, which used to throwFieldError, now resolves on the wrapped state, andpropertynamesnow also lists the wrapped state's properties. Two side effects:haspropertyorpropertynamescould now take different branches. That includes ConstructionBasegetproperties/setproperties, which would stop matching the 2-field constructor.uorjump_u(e.g. a ComponentArray), that component is hidden behind the field of the same name. The docstring says so.e958a8aapass. They cover InterfaceI and InterfaceII (Julia 1, lts, x86), QA, Downgrade, GPU, Docs, Typos and both benchmarks. TheExtendedJumpArray Tests | 51 51line appears in the InterfaceI logs for Julia 1, x86 and lts. No check fails, so I had nothing to compare against master and there is no regression. One caveat: thejulia prelanes did not run any tests. The workflow skipped them because 1.13.0 is not a release candidate, then reported them as passing.RecursiveArrayToolsis already a main dependency, so it isn't a new test dependency.exp(-1)and the jump count against the accumulated state.versionstays at 9.33.1, which is fine because the release bump is separate.haspropertyeffect or the skipped pre lanes. It does disclose the partial Runic run, and there's no format CI check.getproperty/propertynamesforward with a real regression test, and CI green on every lane that runs tests with nothing failing to compare against master.🤖 Risk assessment posted by an AI agent (fleet master) — harness: Devin CLI (Mac) / fusion-claude-opus-5-5-high-sidekick-swe-2-medium; dispatched by Claude Code head, model claude-opus-5-5[1m]
Conversation: local Claude Code session 3cd6500a-1f81-46b5-ac0b-c466e15b6a53 on Chris's Mac (session ID, no URL)