QA: make OptimizationOptimisers imports explicit (#1397)

Agent-Harness: Codex CLI 0.160.0
Agent-Model: gpt-6-luna
Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/qa-hygiene/jobs/optimisers-fixes/log.txt on amdci2

Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Devin <noreply@cognition.ai>

Author: 4 people

lib/OptimizationOptimisers/src/OptimizationOptimisers.jl

@@ -1,7 +1,7 @@
 module OptimizationOptimisers
 
-using Logging
-using Optimisers
+using Logging: Logging, @logmsg, LogLevel
+using Optimisers: Optimisers
 # The Optimisers rules are this package's whole point: `using Optimization,
 # OptimizationOptimisers` has to be enough to write `solve(prob, Adam(0.05))`, exactly
 # as the docs show. They are re-surfaced by name below rather than by blanket
@@ -22,9 +22,9 @@ using Optimisers: ADADelta, ADAGrad, ADAM, ADAMW, AMSGrad, AbstractRule, AccumGr
 @doc "Deprecated alias for [`RAdam`](@ref)." RADAM
 # Not re-exported: the optimization API comes from `Optimization`/`OptimizationBase`,
 # which the user loads directly. This package's public surface is its own solvers.
-using OptimizationBase
+using OptimizationBase: OptimizationBase, OptimizationCache
 using SciMLLogging: @SciMLMessage
-using SciMLBase
+using SciMLBase: SciMLBase
 
 export Optimisers
 

lib/OptimizationOptimisers/test/qa/qa.jl

@@ -16,9 +16,6 @@ const OPTIMISERS_REEXPORTS = (
 )
 
 # ExplicitImports findings, all tracked against SciML/Optimization.jl:
-#  * no_implicit_imports broken: the module relies on `using`
-#    module names (SciMLBase/OptimizationBase/...) that cannot be made
-#    explicit without restructuring.
 #  * the ignored *_are_public / *_via_owners names are owned by SciMLBase,
 #    OptimizationBase, the backend, or Base and are not (yet) declared public;
 #    the proper fix is upstream `public` declarations, not a local change.
@@ -44,7 +41,6 @@ run_qa(
         all_qualified_accesses_via_owners = (; ignore = (:OptimizationStats,)),
         all_qualified_accesses_are_public = (; ignore = (:OptimizationState, :OptimizationStats, :__init, :__solve, :_check_and_convert_maxiters, :allowscallback, :allowsfg, :isa_dataiterator, :requiresgradient)),
     ),
-    ei_broken = (:no_implicit_imports,),
     reexports_allow = OPTIMISERS_REEXPORTS,
 )