[sean0407]

Summary

+halted = false
for epoch in 1:maxiters
  for d in data
    if callback(state)
+     halted = true
      break # exit the data loop
    end
  end
+ halted && break # exit the epoch loop
end

A callback returning true currently exits only the inner data loop, so later Sophia epochs continue. This change propagates that halt to the outer epoch loop.

Evidence

• Before: isolated Julia 1.12.4 reproduction reached halt calls=50 retcode=Success with a callback that returned true on call 5.
• After: Pkg.test() for lib/OptimizationSophia passed (5 passed, 0 failed), including a regression test that stops at callback 5 with maxiters = 50.

Merge Danger

Door: Two-way

Blast Radius: Sophia

The change affects early termination in the Sophia solver loop; reverting the commit restores the prior behavior.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.